Received: by 2002:a05:6359:c8b:b0:c7:702f:21d4 with SMTP id go11csp776933rwb; Mon, 26 Sep 2022 05:51:58 -0700 (PDT) X-Google-Smtp-Source: AMsMyM4Ew5t4qSgL1woVYXfNsFgbWGIYDO81E9NpXPqo5GiUoV9FojRQ440ofBU9LW8cOMaluDk0 X-Received: by 2002:a17:906:9751:b0:783:87e0:4e38 with SMTP id o17-20020a170906975100b0078387e04e38mr4028864ejy.257.1664196717936; Mon, 26 Sep 2022 05:51:57 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1664196717; cv=none; d=google.com; s=arc-20160816; b=mzAWvPizt2yI9QSqO6okfJLiMzLOc4VU4Q/zYbVPzgKSaYH2K11soB516kFz8nshCj +lcgrbRV3BkfgNN+0IBSMiTNbW9npBW+ESGXU+kbC2NfDVwocLJ3Y7U9Pens6HFiIRyS ZE7hUa6EzNxUH5a6AffdvzO6cjJQAluaH6lNg0joeGUyuIK7CIEr/ouOMviygHnQLvuj Sx9tLxMebAB8Q6cvqcK7Ft9rirah1ZPKDy/zTh4UOAhAYbVvvUkxpn4hhDlpHQnKIlLT 6st36btPh331BphkyrOAsbCR9lPSbSiBxcZYBGOMK9SeoXx7oE7wPqAy3dCLWMj/E+8i AEPw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :user-agent:references:in-reply-to:message-id:date:subject:cc:to :from:dkim-signature; bh=s/eAGxKT2YXZNE6AXCZUWiGuSfl3Fq/8/JmnJd50qdA=; b=SLD60248mJX4Ik0hP1BGPGAe68UnrHfSyhmJdeRf9nECv+nSnN6zv19yeR1g48YF64 NYlvbuOIfF4NOMGi7mIyIYCd2s2q6nF33QyCaUin79LifrsFVvtRLQVkh3mZU9kdU7uy 8TtUsvSaJVhor62qxNeDIbk+JJ+iZYcGyaz0+KtZZjv50reV/uPwGhco2EfHtn1zB6nY frqmv7yVFNRiNdH4+KC5TyFxi6Og7I9aYM3RsExz9XCpJoXa7NKUZ8uu02z5hJgNXwOg MFwO3ibZzFbL4kiRuCwjD9vnZqFuBD+lF8vciC+YhiUy2MGdsrQjUukLUHmpCUVqa9pK BYPw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b=OTqUW0xg; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id j11-20020a508a8b000000b004539a0fc32dsi15270659edj.317.2022.09.26.05.51.31; Mon, 26 Sep 2022 05:51:57 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b=OTqUW0xg; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S237689AbiIZLRU (ORCPT + 99 others); Mon, 26 Sep 2022 07:17:20 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:53822 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S237608AbiIZLQV (ORCPT ); Mon, 26 Sep 2022 07:16:21 -0400 Received: from ams.source.kernel.org (ams.source.kernel.org [145.40.68.75]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 1FC7A65641; Mon, 26 Sep 2022 03:37:24 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id 9E0B1B80757; Mon, 26 Sep 2022 10:35:44 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id EF019C4347C; Mon, 26 Sep 2022 10:35:42 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1664188543; bh=QlhGB4CupNlE5Ql5M5U7uGoDAhrr38NVyD/sKJ3vxrE=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=OTqUW0xgtIm3jM7kL/NXfEx9TLdrPi8LE21EENjC5/HNoCeSAMzoHFxTVvMkOZQgF S73XdDV+WViYb1MXEEh34Rt+GeLzapVe72RyXMruAWJWFSifLsQuzh64yXHIRu1Yb5 +awvAdgJ1ZJHckM0DTirD2MIIL1SNnOeZWNRvFDU= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Felix Fietkau , Kalle Valo Subject: [PATCH 5.15 042/148] wifi: mt76: fix reading current per-tid starting sequence number for aggregation Date: Mon, 26 Sep 2022 12:11:16 +0200 Message-Id: <20220926100757.596969888@linuxfoundation.org> X-Mailer: git-send-email 2.37.3 In-Reply-To: <20220926100756.074519146@linuxfoundation.org> References: <20220926100756.074519146@linuxfoundation.org> User-Agent: quilt/0.67 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-7.2 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_HI, SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Felix Fietkau commit c3a510e2b53785df31d882a773c4c0780b4c825f upstream. The code was accidentally shifting register values down by tid % 32 instead of (tid * field_size) % 32. Cc: stable@vger.kernel.org Fixes: a28bef561a5c ("mt76: mt7615: re-enable offloading of sequence number assignment") Signed-off-by: Felix Fietkau Signed-off-by: Kalle Valo Link: https://lore.kernel.org/r/20220826182329.18155-1-nbd@nbd.name Signed-off-by: Greg Kroah-Hartman --- drivers/net/wireless/mediatek/mt76/mt7615/mac.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) --- a/drivers/net/wireless/mediatek/mt76/mt7615/mac.c +++ b/drivers/net/wireless/mediatek/mt76/mt7615/mac.c @@ -1038,7 +1038,7 @@ u32 mt7615_mac_get_sta_tid_sn(struct mt7 offset %= 32; val = mt76_rr(dev, addr); - val >>= (tid % 32); + val >>= offset; if (offset > 20) { addr += 4;