Received: by 2002:a05:6359:c8b:b0:c7:702f:21d4 with SMTP id go11csp779457rwb; Mon, 26 Sep 2022 05:54:00 -0700 (PDT) X-Google-Smtp-Source: AMsMyM4MdYgcTDK3tHh/LiffF5PDxOkuYtko4notpXjAzL31k0ozAmTGgjSh+0tyoMMJIfHZyXYu X-Received: by 2002:a17:907:3e86:b0:6f5:917:10cc with SMTP id hs6-20020a1709073e8600b006f5091710ccmr18641771ejc.53.1664196840091; Mon, 26 Sep 2022 05:54:00 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1664196840; cv=none; d=google.com; s=arc-20160816; b=rUEy06NaW0Zj8OLy9K6OpYbq8bLz+EL8gmoSLkz4shXeAD9OpPLBy7R10GPWDM8M2j BPd0IZQiNp2syyL3r3nLdVDo4aBVUA8RVKivpNFoGYIa5rDmYz76EjznxrUgT0R9L7g8 izxEHf6UgXPzQtOu8knkSokF0I77xWJx9nUt/6h7LQRXcmCEoVX/iTOkCrPML5dPHQeE +iMZPC1RW/mjOk04c4LASyIbzxc0k/kbUvoN803DWR4fSjF8VtJ8pbLjFTYv2zU7o+JX Rlt18gttaklGsoRkQqQMj4l2jJfoaz/WZFlH3QoYf9F/iAIq/bPXdIiuVFJSl28tmCG8 6OQw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :user-agent:references:in-reply-to:message-id:date:subject:cc:to :from:dkim-signature; bh=vhy5D0lJjWsyUAVuFArcvGqjMRbwKlWp4V80HJGUplg=; b=PZR3nqLnbjSkWg8RhjZaNkkEV15LkfChf8lqggh7rGtWMa0VjjvUYkz+7KfLClYElJ HXooerNfufOEo3N3YQ19kGiIlgrZ3RSySjjqbOfvl8GmnwilZczNPpRxXX0lDafpUzSs XZ/ycq6nkFo3v15TXLgUH2g0myRplMJjlgL7crWVk3486UBwIQl9v4i5airxvyGiStbc 0zwgGlnTVADs2WjhQ1CBf81eRozb+fz7eGUCANkPSX8q0L93GHCuvcba++UdwMik0qC+ yUbngWf+2zbsKKli8rH3bnt2+9mWhwFjkuBhZIx1dzAlXx8ojW6+btGWkyNIR1nqdAFU fJEQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b="i/3uHmjl"; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id qa34-20020a17090786a200b007417e9a2c71si16071126ejc.352.2022.09.26.05.53.33; Mon, 26 Sep 2022 05:54:00 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b="i/3uHmjl"; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S237842AbiIZLY7 (ORCPT + 99 others); Mon, 26 Sep 2022 07:24:59 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:52030 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S236094AbiIZLXa (ORCPT ); Mon, 26 Sep 2022 07:23:30 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 8DE3E1C13A; Mon, 26 Sep 2022 03:39:54 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id B272760B55; Mon, 26 Sep 2022 10:39:04 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id B0B1BC433D6; Mon, 26 Sep 2022 10:39:03 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1664188744; bh=fTOFobLztgWomUcePqED+YQQvKqRE3uuRHz5dNeFLEM=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=i/3uHmjlTvCbQQZbhqhqOH5c+CXc1PJpy1tDkDBUlLRh4l1WvlrEmH60lnqFIsXHR /449tAZ9PZJjD1xfN1SErAdXoqVmQK90TFFJlm7BEYAiQ16Pv2/8YhjxP9FiCuzM/r XFiLhh/AcsAh9EvuA8mQmb0voxtamqatp9ZwrnxY= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Leo Yan , Lieven Hey , Arnaldo Carvalho de Melo , Sasha Levin Subject: [PATCH 5.15 107/148] perf jit: Include program header in ELF files Date: Mon, 26 Sep 2022 12:12:21 +0200 Message-Id: <20220926100800.128448782@linuxfoundation.org> X-Mailer: git-send-email 2.37.3 In-Reply-To: <20220926100756.074519146@linuxfoundation.org> References: <20220926100756.074519146@linuxfoundation.org> User-Agent: quilt/0.67 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-7.2 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_HI, SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Lieven Hey [ Upstream commit babd04386b1df8c364cdaa39ac0e54349502e1e5 ] The missing header makes it hard for programs like elfutils to open these files. Fixes: 2d86612aacb7805f ("perf symbol: Correct address for bss symbols") Reviewed-by: Leo Yan Signed-off-by: Lieven Hey Tested-by: Leo Yan Cc: Leo Yan Link: https://lore.kernel.org/r/20220915092910.711036-1-lieven.hey@kdab.com Signed-off-by: Arnaldo Carvalho de Melo Signed-off-by: Sasha Levin --- tools/perf/util/genelf.c | 14 ++++++++++++++ tools/perf/util/genelf.h | 4 ++++ 2 files changed, 18 insertions(+) diff --git a/tools/perf/util/genelf.c b/tools/perf/util/genelf.c index 953338b9e887..02cd9f75e3d2 100644 --- a/tools/perf/util/genelf.c +++ b/tools/perf/util/genelf.c @@ -251,6 +251,7 @@ jit_write_elf(int fd, uint64_t load_addr, const char *sym, Elf_Data *d; Elf_Scn *scn; Elf_Ehdr *ehdr; + Elf_Phdr *phdr; Elf_Shdr *shdr; uint64_t eh_frame_base_offset; char *strsym = NULL; @@ -285,6 +286,19 @@ jit_write_elf(int fd, uint64_t load_addr, const char *sym, ehdr->e_version = EV_CURRENT; ehdr->e_shstrndx= unwinding ? 4 : 2; /* shdr index for section name */ + /* + * setup program header + */ + phdr = elf_newphdr(e, 1); + phdr[0].p_type = PT_LOAD; + phdr[0].p_offset = 0; + phdr[0].p_vaddr = 0; + phdr[0].p_paddr = 0; + phdr[0].p_filesz = csize; + phdr[0].p_memsz = csize; + phdr[0].p_flags = PF_X | PF_R; + phdr[0].p_align = 8; + /* * setup text section */ diff --git a/tools/perf/util/genelf.h b/tools/perf/util/genelf.h index d4137559be05..ac638945b4cb 100644 --- a/tools/perf/util/genelf.h +++ b/tools/perf/util/genelf.h @@ -50,8 +50,10 @@ int jit_add_debug_info(Elf *e, uint64_t code_addr, void *debug, int nr_debug_ent #if GEN_ELF_CLASS == ELFCLASS64 #define elf_newehdr elf64_newehdr +#define elf_newphdr elf64_newphdr #define elf_getshdr elf64_getshdr #define Elf_Ehdr Elf64_Ehdr +#define Elf_Phdr Elf64_Phdr #define Elf_Shdr Elf64_Shdr #define Elf_Sym Elf64_Sym #define ELF_ST_TYPE(a) ELF64_ST_TYPE(a) @@ -59,8 +61,10 @@ int jit_add_debug_info(Elf *e, uint64_t code_addr, void *debug, int nr_debug_ent #define ELF_ST_VIS(a) ELF64_ST_VISIBILITY(a) #else #define elf_newehdr elf32_newehdr +#define elf_newphdr elf32_newphdr #define elf_getshdr elf32_getshdr #define Elf_Ehdr Elf32_Ehdr +#define Elf_Phdr Elf32_Phdr #define Elf_Shdr Elf32_Shdr #define Elf_Sym Elf32_Sym #define ELF_ST_TYPE(a) ELF32_ST_TYPE(a) -- 2.35.1