Received: by 2002:a05:6359:c8b:b0:c7:702f:21d4 with SMTP id go11csp806602rwb; Mon, 26 Sep 2022 06:11:09 -0700 (PDT) X-Google-Smtp-Source: AMsMyM5RVvi44/VOJV7dpBRIQPaIcagJPulrNGIzIkljuRmJ43QJn3Hk7cZOfOSZ2SrUQ9uTpOoh X-Received: by 2002:a17:907:a421:b0:783:c25a:cee0 with SMTP id sg33-20020a170907a42100b00783c25acee0mr1595114ejc.94.1664197869342; Mon, 26 Sep 2022 06:11:09 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1664197869; cv=none; d=google.com; s=arc-20160816; b=01ZdsG0xZRp7zcIUlHCRLpLfa6xb/a9VEn17Iv5VEl7kI1ExW/Jd/h0blPYoGf0fux B0dKPTN6GTXvkO8PnbfzfF/11z0GACNw3H+IaqPlkKpa3UhEtvh7QsL2DbAIZnqZVA3T q/2FKEHLx598oAYtegVnuwB6Gpala5AMgKIOAY7yvCLBZrRS2/9r5kCNjdnjIdDOkyty lhYKQ+JdLgktXvURqLQoVWyqn9QQWz8aFotHrDhCRr/RTUkvw9mJ3Ssg700MNsXjBJLy bwmKUmYYSmWSJyUwxnvQi64DU2NKp3r8xgp/UVfyaO5tSYFSKnwoW6sA0tpH7HeukXwi tS8w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :user-agent:references:in-reply-to:message-id:date:subject:cc:to :from:dkim-signature; bh=jY10rdMJl93acoq/gtlAIGmnr7Ry0nVJyWG2ZgLhHXk=; b=Hsn74t4EEnfer+tdGIlgGuMuRtAXRt6o9jh+3KDtVtjkJI+TEDdK57qydvyaTBSdm8 wanN9MiJqUlsnpTMxqTox/cnBhpOfNrrAMt7xZdSHV0r1mwM7KgKVoOmnIk/qyQTQKML S+/0j9XsYdz9vFkY3mDYQy51IcXNjapU5t2rsKD4WvxTDAP49gnqq3hKzD5u9dGCkyO2 OTFEHTXIWzxVkma42uxCLl9YGVS+Gak9fVeoP4l+v5VlZlPcv+kfRdGH7VxR7rshuwcX 8b2dsgOwM1W7jEpwik0L2EWWrkjuSIMgFhqesFlpMQBGhnMuBXWVvMITi9goF4/k2Azt 0AJQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b=KEHT+KCL; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id ed10-20020a056402294a00b00456f8d9b2cdsi6105135edb.452.2022.09.26.06.10.43; Mon, 26 Sep 2022 06:11:09 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b=KEHT+KCL; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S235463AbiIZLRO (ORCPT + 99 others); Mon, 26 Sep 2022 07:17:14 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:53804 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S235020AbiIZLQU (ORCPT ); Mon, 26 Sep 2022 07:16:20 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [IPv6:2604:1380:4641:c500::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 90F2A6524A; Mon, 26 Sep 2022 03:37:29 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 3C59A60A55; Mon, 26 Sep 2022 10:37:23 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 32045C433C1; Mon, 26 Sep 2022 10:37:22 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1664188642; bh=d0NGvshIdLgsFhFa/UwAVgqQUXbygA154sf3xuY/DGE=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=KEHT+KCLuXGalUiUREMJxUjmcMr+9jGwkwaxoWuGgIo0OEwf/I+sM4iX4tbalXxS/ xIrxMTlQ8E1Xh2F0Cggyx0KcWKJSfBWA4JACdyMJotw3miJmAyOYS1c+NDnlJWDXFA ZcLnx5Q8anWKKlA4a7hgG9S5UEe6QNvOIfpJArQM= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Himanshu Madhani , Rafael Mendonca , "Martin K. Petersen" , Sasha Levin Subject: [PATCH 5.15 074/148] scsi: qla2xxx: Fix memory leak in __qlt_24xx_handle_abts() Date: Mon, 26 Sep 2022 12:11:48 +0200 Message-Id: <20220926100758.808496532@linuxfoundation.org> X-Mailer: git-send-email 2.37.3 In-Reply-To: <20220926100756.074519146@linuxfoundation.org> References: <20220926100756.074519146@linuxfoundation.org> User-Agent: quilt/0.67 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-7.2 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_HI, SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Rafael Mendonca [ Upstream commit 601be20fc6a1b762044d2398befffd6bf236cebf ] Commit 8f394da36a36 ("scsi: qla2xxx: Drop TARGET_SCF_LOOKUP_LUN_FROM_TAG") made the __qlt_24xx_handle_abts() function return early if tcm_qla2xxx_find_cmd_by_tag() didn't find a command, but it missed to clean up the allocated memory for the management command. Link: https://lore.kernel.org/r/20220914024924.695604-1-rafaelmendsr@gmail.com Fixes: 8f394da36a36 ("scsi: qla2xxx: Drop TARGET_SCF_LOOKUP_LUN_FROM_TAG") Reviewed-by: Himanshu Madhani Signed-off-by: Rafael Mendonca Signed-off-by: Martin K. Petersen Signed-off-by: Sasha Levin --- drivers/scsi/qla2xxx/qla_target.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/drivers/scsi/qla2xxx/qla_target.c b/drivers/scsi/qla2xxx/qla_target.c index b86f6e1f21b5..4b4ca2a9524d 100644 --- a/drivers/scsi/qla2xxx/qla_target.c +++ b/drivers/scsi/qla2xxx/qla_target.c @@ -2166,8 +2166,10 @@ static int __qlt_24xx_handle_abts(struct scsi_qla_host *vha, abort_cmd = ha->tgt.tgt_ops->find_cmd_by_tag(sess, le32_to_cpu(abts->exchange_addr_to_abort)); - if (!abort_cmd) + if (!abort_cmd) { + mempool_free(mcmd, qla_tgt_mgmt_cmd_mempool); return -EIO; + } mcmd->unpacked_lun = abort_cmd->se_cmd.orig_fe_lun; if (abort_cmd->qpair) { -- 2.35.1