Received: by 2002:a05:6359:c8b:b0:c7:702f:21d4 with SMTP id go11csp816577rwb; Mon, 26 Sep 2022 06:17:28 -0700 (PDT) X-Google-Smtp-Source: AMsMyM6eTtRbX5GV/DaR6VCKssDWWOncziqRU/vLvkgBm4ovzAjEu3B/ao9VN3XuA2a6malgGUD5 X-Received: by 2002:a05:6402:5024:b0:440:e4ad:f7b6 with SMTP id p36-20020a056402502400b00440e4adf7b6mr23091570eda.358.1664198248386; Mon, 26 Sep 2022 06:17:28 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1664198248; cv=none; d=google.com; s=arc-20160816; b=SGEC/Ru67SG/BSwz5QZnobhdBcrLdrPbauKM41DnCyuHAzMVrBvUwSdkMWMNfZnrKN dIb3aASHq1HVNmn3GCyesIdHltvzrxEgBSwQRNR+dblf34ewQAbvtBHoil8c7nSxMyJu EGPkeBj5JaChBBLYFW31ZkZzlD0E0LACab66oBH7mC5DmDHLIpgM4ydXE9I6qm7pGthP fYRjqatw+qiJyW5+HOehDl7D4AlnWuaWNoW7TptpucVgoRBekn5HjFMXI38/oCvoovvt tMhmr+oIXm09+ZENG32Aa2FIOP7y9rueA28HRVI5ujW7Hy5XXe5Zc5HpgXnUCh+3v1MT jUBA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :user-agent:references:in-reply-to:message-id:date:subject:cc:to :from:dkim-signature; bh=YwJFH1amYwRkyflYP6LPYYLMgewT5RrghLA0fE6Jx4U=; b=MKClaB8F5Q9MXUljDQ4JUEqXGqJTMN4/wNwzYNvfsAnPT3YpX4ILaMsa7KkFtgONIV kessYsR9eHn2tz9/FvOHjzCC6QEscZ9PwDjJBH6KeiGJgoKdqMjmdPNlzvi+63nfhXc2 EA8uo5wzmQSc/qHZN2ixDIXJdes/b/SdQ5hapMkLtBn0FIbIPPqh4hRraZ2/6oJMt1vp lqYvwYyoloGEEbvqIL0aqS1lBqhsPjpO+hjLNn2XyTADPRX1fxuK7X/VLLy0phl3lkJ9 MqntLL+opBrVy73Cu89MK559Yg3lAyscxA2bgLf0ID11fPSSxSVSgSkWNoSyPBMOqbVW EwoQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b=QYTQt1ST; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id ed10-20020a056402294a00b00456f8d9b2cdsi6105135edb.452.2022.09.26.06.17.02; Mon, 26 Sep 2022 06:17:28 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b=QYTQt1ST; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S237831AbiIZLWK (ORCPT + 99 others); Mon, 26 Sep 2022 07:22:10 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:45470 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S237739AbiIZLUN (ORCPT ); Mon, 26 Sep 2022 07:20:13 -0400 Received: from ams.source.kernel.org (ams.source.kernel.org [IPv6:2604:1380:4601:e00::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 4699352FFD; Mon, 26 Sep 2022 03:39:10 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id 0EA8BB80883; Mon, 26 Sep 2022 10:32:58 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 5DE3DC433D7; Mon, 26 Sep 2022 10:32:56 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1664188376; bh=0BEwOcdvfMkUKYaNeHKKXFlAaEzB4sCcBK6PLkpw9YY=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=QYTQt1ST3CQSJUo6QMUXA+P4GdGeXPL/uEPmTcTPzNsB4qFU6dk0QAXR2+PaUZU9R ZMLMHlhvkITGzuxKB98OxATGyM+YvoSSldZyVCd6rMnlpcMDPbLD7bp31XTdyt8vIi Ro/iCkHcEYxee8Q6udtuOHUPyonVKL1HW25Ex9CI= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Daniel Wheeler , Krunoslav Kovac , Aric Cyr , Pavle Kotarac , Yao Wang1 , Alex Deucher , Sasha Levin Subject: [PATCH 5.10 130/141] drm/amd/display: Limit user regamma to a valid value Date: Mon, 26 Sep 2022 12:12:36 +0200 Message-Id: <20220926100759.156412703@linuxfoundation.org> X-Mailer: git-send-email 2.37.3 In-Reply-To: <20220926100754.639112000@linuxfoundation.org> References: <20220926100754.639112000@linuxfoundation.org> User-Agent: quilt/0.67 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-7.2 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_HI, SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Yao Wang1 [ Upstream commit 3601d620f22e37740cf73f8278eabf9f2aa19eb7 ] [Why] For HDR mode, we get total 512 tf_point and after switching to SDR mode we actually get 400 tf_point and the rest of points(401~512) still use dirty value from HDR mode. We should limit the rest of the points to max value. [How] Limit the value when coordinates_x.x > 1, just like what we do in translate_from_linear_space for other re-gamma build paths. Tested-by: Daniel Wheeler Reviewed-by: Krunoslav Kovac Reviewed-by: Aric Cyr Acked-by: Pavle Kotarac Signed-off-by: Yao Wang1 Signed-off-by: Alex Deucher Signed-off-by: Sasha Levin --- drivers/gpu/drm/amd/display/modules/color/color_gamma.c | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/drivers/gpu/drm/amd/display/modules/color/color_gamma.c b/drivers/gpu/drm/amd/display/modules/color/color_gamma.c index 09bc2c249e1a..3c4390d71a82 100644 --- a/drivers/gpu/drm/amd/display/modules/color/color_gamma.c +++ b/drivers/gpu/drm/amd/display/modules/color/color_gamma.c @@ -1524,6 +1524,7 @@ static void interpolate_user_regamma(uint32_t hw_points_num, struct fixed31_32 lut2; struct fixed31_32 delta_lut; struct fixed31_32 delta_index; + const struct fixed31_32 one = dc_fixpt_from_int(1); i = 0; /* fixed_pt library has problems handling too small values */ @@ -1552,6 +1553,9 @@ static void interpolate_user_regamma(uint32_t hw_points_num, } else hw_x = coordinates_x[i].x; + if (dc_fixpt_le(one, hw_x)) + hw_x = one; + norm_x = dc_fixpt_mul(norm_factor, hw_x); index = dc_fixpt_floor(norm_x); if (index < 0 || index > 255) -- 2.35.1