Received: by 2002:a05:6359:c8b:b0:c7:702f:21d4 with SMTP id go11csp824714rwb; Mon, 26 Sep 2022 06:23:05 -0700 (PDT) X-Google-Smtp-Source: AMsMyM5PtkMvArXCD3+6jTAerjC9tSv6Pg1gCsNO0/9NooIh/Z9HofGy6tVNGAUrRA6UJ3jqqypR X-Received: by 2002:a17:90b:4d07:b0:1ef:521c:f051 with SMTP id mw7-20020a17090b4d0700b001ef521cf051mr37124730pjb.164.1664198585011; Mon, 26 Sep 2022 06:23:05 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1664198585; cv=none; d=google.com; s=arc-20160816; b=aJI2mBbFvcOGeNpFdegH++MV+ROJOn1PI/e/ZLe6qLcMmP3XE1zmLZpQ+qjhRFnHRj /6/p+O4nFFZjkNG7q7IxECLBsPwpGGpa6vzufLPZcVGl9AB/q4aoH1sra0iKrj+QTP2C E6+7Bct6VoYSqkiesXmdgNaPCIWyIDxgoRQhEc6LdexiwQAiC0xulolx5EvjU8yaRYlR YT+6OGdzKsNdNTfRMl3doRj3mM+GP2uDW8mB2kCacI2BJoknrAqVYz/qXdIwkKol0h3W P5xgKpeWZZ0lwUwkZSYX1GEnm5aSrslru+VLL02Jx8Wq5FVmBbruqBDYIny6y31YojjA K+bQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :user-agent:references:in-reply-to:message-id:date:subject:cc:to :from:dkim-signature; bh=20PLVrJveLrJ1c/hRWXwZ/IgKwPY7+sZ0HdaBNwWNQ4=; b=OvoGmtJRbgFte5gTMvcJCJDCfrDF3vZyknSAWBZ23VZMDbPLCu8Pbcw+dhBx3he2D/ Os7w1SHx/MsvHIjildJOQ3dX2mbqQHGXohV221pXtLtKdtIAkDlGU6Y40iPW3cQOLQyz 1KuqtG305TQjKn+V9NqqBfKr8tmgdq2XMvFIkgrXHv1e2CbZRlpoXCAQNOeZK93lapEO 8d5yAyMRn5JwpPDxLiui9p6dfNZcBIFYg78Rtzayf2jHQX5EziD2SwMG8E5cj0JNSJ2M yRzQuLDJWEFVpR3ZmIElfByjovTPN72ZSmjsG7SdQSmsafrA465LBUB2EuD7MGZVFASK 4huQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b=ng1zSi9c; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id ga22-20020a17090b039600b001f561cba131si11145153pjb.179.2022.09.26.06.22.53; Mon, 26 Sep 2022 06:23:04 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b=ng1zSi9c; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234432AbiIZLJt (ORCPT + 99 others); Mon, 26 Sep 2022 07:09:49 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:34156 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S237317AbiIZLH1 (ORCPT ); Mon, 26 Sep 2022 07:07:27 -0400 Received: from ams.source.kernel.org (ams.source.kernel.org [IPv6:2604:1380:4601:e00::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 6ED124F184; Mon, 26 Sep 2022 03:34:22 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id 7591AB80951; Mon, 26 Sep 2022 10:32:39 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 68E10C433D6; Mon, 26 Sep 2022 10:32:37 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1664188358; bh=d3/eqmFXu7LB/HIH21OLTWzjzAcENNgY5giWW1aZF/Q=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=ng1zSi9cu77960wa1GowV1BOXGfE4+VlRYxcjuC4uwnbruGVFG9Q5gWl2xQyVYgWz n8QhdZ18G267SZ615Igo4ZD8QNEUjmBU3bJG5P3NubStIJMNb/4RFeI7U6SGcinbZW vTeKPmmZAhY8LWIUoqjGFpDcglzZ+O6xio8/Pejw= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Miaoqian Lin , Liang He , Jakub Kicinski , Sasha Levin Subject: [PATCH 5.10 092/141] of: mdio: Add of_node_put() when breaking out of for_each_xx Date: Mon, 26 Sep 2022 12:11:58 +0200 Message-Id: <20220926100757.760655669@linuxfoundation.org> X-Mailer: git-send-email 2.37.3 In-Reply-To: <20220926100754.639112000@linuxfoundation.org> References: <20220926100754.639112000@linuxfoundation.org> User-Agent: quilt/0.67 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-7.2 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_HI, SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Liang He [ Upstream commit 1c48709e6d9d353acaaac1d8e33474756b121d78 ] In of_mdiobus_register(), we should call of_node_put() for 'child' escaped out of for_each_available_child_of_node(). Fixes: 66bdede495c7 ("of_mdio: Fix broken PHY IRQ in case of probe deferral") Co-developed-by: Miaoqian Lin Signed-off-by: Miaoqian Lin Signed-off-by: Liang He Link: https://lore.kernel.org/r/20220913125659.3331969-1-windhl@126.com Signed-off-by: Jakub Kicinski Signed-off-by: Sasha Levin --- drivers/net/mdio/of_mdio.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/net/mdio/of_mdio.c b/drivers/net/mdio/of_mdio.c index ea0bf13e8ac3..5bae47f3da40 100644 --- a/drivers/net/mdio/of_mdio.c +++ b/drivers/net/mdio/of_mdio.c @@ -332,6 +332,7 @@ int of_mdiobus_register(struct mii_bus *mdio, struct device_node *np) return 0; unregister: + of_node_put(child); mdiobus_unregister(mdio); return rc; } -- 2.35.1