Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <0b9ce76d-4c0d-615d-3345-5803fb29db45@huawei.com>
Date:   Mon, 26 Sep 2022 11:27:19 +0100
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101
 Thunderbird/91.6.1
Subject: Re: [PATCH v4 0/7] libsas and drivers: NCQ error handling
To:     "Martin K. Petersen" <martin.petersen@oracle.com>
CC:     <jejb@linux.ibm.com>, <jinpu.wang@cloud.ionos.com>,
        <damien.lemoal@opensource.wdc.com>, <linux-scsi@vger.kernel.org>,
        <linux-kernel@vger.kernel.org>, <linuxarm@huawei.com>,
        <yangxingui@huawei.com>
References: <1663840018-50161-1-git-send-email-john.garry@huawei.com>
 <yq1a66npc3b.fsf@ca-mkp.ca.oracle.com>
From:   John Garry <john.garry@huawei.com>
In-Reply-To: <yq1a66npc3b.fsf@ca-mkp.ca.oracle.com>
Content-Type: text/plain; charset="UTF-8"; format=flowed
Content-Transfer-Encoding: 8bit
Precedence: bulk

On 25/09/2022 19:02, Martin K. Petersen wrote:

Hi Martin,

>> Based on mkp-scsi @ 6.1/scsi-staging 7f615c1b5986 ("scsi:
>> scsi_transport_fc: Use %u for dev_loss_tmo")
> Can you please rebase on top of the latest staging? There are a couple
> of pm8001 conflicts.

Sorry about that, I did test that it applied ok but I did not test 
building it again. Anyway, this is the only issue I saw:

drivers/scsi/pm8001/pm8001_hwi.c: In function ‘pm8001_mpi_task_abort_resp’:
drivers/scsi/pm8001/pm8001_hwi.c:3520:15: error: ‘pm8001_dev’ undeclared 
(first use in this function); did you mean ‘pm8001_dbg’?
  3520 |   atomic_dec(&pm8001_dev->running_req);
       |               ^~~~~~~~~~
       |               pm8001_dbg

Was there another issue?

Thanks,
John