Received: by 2002:a05:6359:c8b:b0:c7:702f:21d4 with SMTP id go11csp839919rwb; Mon, 26 Sep 2022 06:33:34 -0700 (PDT) X-Google-Smtp-Source: AMsMyM4rWM55JrWTnpOfW5j42PUFBLAf1KOhCYwHaQrdoddLSybfuf7arzYCT1tKedOmeeijCDRk X-Received: by 2002:a05:6a00:22d6:b0:543:7003:21ab with SMTP id f22-20020a056a0022d600b00543700321abmr23596624pfj.54.1664199213860; Mon, 26 Sep 2022 06:33:33 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1664199213; cv=none; d=google.com; s=arc-20160816; b=iU4LMBYccwUCr3wnr++cs+Pekt9YXrGX8jfWDWTANMYt4tmehCveL3ZvsPCvtKbPJ1 syf/2fopxT/o/u8nwIlwOlOkdxbX8mZdA6/3ENaQabhrJpanlM2bA7HbaK0Fis9TgSbI Wtg0g+BErBj7Qi5+piDqhS/fqYHBTwGyswOF2EhcGFJmfgCKZPJU5zRhP9IHwMWWP06r u2vwhKuUM2Yj5OiWGPGUnO3afBZhhCfLneyuw6B+rUQ10fNbLHcqdrzmfJUyxYBfmiWy xALlQC97djiLEGA7Guca1TJQ8YqP8SHTUJX0DI+JCb8mILkzcAV4HFCHqWGCqJgU1Prf fQrw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :user-agent:references:in-reply-to:message-id:date:subject:cc:to :from:dkim-signature; bh=gJqDDJPN0x12D0mmk7G0F1Xxa1UNJsGTriJ/6oXcR1I=; b=grfg56uf4uLdR9hbwtyCCoqUyOxj1ZsBsKQldAOPh3Lg4vkEwPvqWvSBojVxZciOth uVTwunfb+M4DPNItInhir8AgKvHl1lyfKMnqTowo3QkCD8EHZtik2ehG/GGaN5yLuzsJ Y+qxQQUv+PFg7kTXJR2nmEzLY6tjjQOuTHy6PtpEzd6yl8z5jxameNENtBoLkUAt038f a1lEniOlH/jhFGJZgtWACbUrV81gtqDEmKGMWpN066VCzAwRX44+jWGiRtT62+0Jl5OH Qidsds6wqsmZ3E6v4cq+fmFyA8KfVVfmf30jG/S8Xoh0tABOx3BVgsJ9e3PCi9Vxr0Vk bAyA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b=nkhvyZjc; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id r124-20020a632b82000000b0043c700ff7f6si8770150pgr.721.2022.09.26.06.33.21; Mon, 26 Sep 2022 06:33:33 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b=nkhvyZjc; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234779AbiIZN1K (ORCPT + 99 others); Mon, 26 Sep 2022 09:27:10 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:46518 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S234116AbiIZN0t (ORCPT ); Mon, 26 Sep 2022 09:26:49 -0400 Received: from ams.source.kernel.org (ams.source.kernel.org [IPv6:2604:1380:4601:e00::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 1B2A857236; Mon, 26 Sep 2022 04:51:37 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id C4A96B8095C; Mon, 26 Sep 2022 10:39:55 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 10717C433D6; Mon, 26 Sep 2022 10:39:53 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1664188794; bh=nXLbPcp/lmo1PNRr7WbCA1M/+VZrKaywAvL2mtf1Ros=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=nkhvyZjcRHRGJTruBr3qVzXSyR2O8gksdDWZxA7iSnlEY1u1lxCt7inTEedtI42VQ 7r5u4SSdw18PLHUUcye/fze5XxsTvgHrRTq5jpkMGhZBL/0f65EI6B3IT3+nGbr7LL QrORVKXNxLogFeBB0cB1OZ4SPjYEtoS2B4PQwQUQ= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Miaoqian Lin , Liang He , Jakub Kicinski , Sasha Levin Subject: [PATCH 5.15 092/148] of: mdio: Add of_node_put() when breaking out of for_each_xx Date: Mon, 26 Sep 2022 12:12:06 +0200 Message-Id: <20220926100759.525282902@linuxfoundation.org> X-Mailer: git-send-email 2.37.3 In-Reply-To: <20220926100756.074519146@linuxfoundation.org> References: <20220926100756.074519146@linuxfoundation.org> User-Agent: quilt/0.67 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-7.2 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_HI, SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Liang He [ Upstream commit 1c48709e6d9d353acaaac1d8e33474756b121d78 ] In of_mdiobus_register(), we should call of_node_put() for 'child' escaped out of for_each_available_child_of_node(). Fixes: 66bdede495c7 ("of_mdio: Fix broken PHY IRQ in case of probe deferral") Co-developed-by: Miaoqian Lin Signed-off-by: Miaoqian Lin Signed-off-by: Liang He Link: https://lore.kernel.org/r/20220913125659.3331969-1-windhl@126.com Signed-off-by: Jakub Kicinski Signed-off-by: Sasha Levin --- drivers/net/mdio/of_mdio.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/net/mdio/of_mdio.c b/drivers/net/mdio/of_mdio.c index 9e3c815a070f..796e9c7857d0 100644 --- a/drivers/net/mdio/of_mdio.c +++ b/drivers/net/mdio/of_mdio.c @@ -231,6 +231,7 @@ int of_mdiobus_register(struct mii_bus *mdio, struct device_node *np) return 0; unregister: + of_node_put(child); mdiobus_unregister(mdio); return rc; } -- 2.35.1