Received: by 2002:a05:6359:c8b:b0:c7:702f:21d4 with SMTP id go11csp890542rwb; Mon, 26 Sep 2022 07:09:59 -0700 (PDT) X-Google-Smtp-Source: AMsMyM63CNATDUhrNBnZQFXePJrK8S2GZUupMxvceghQzUK7/li4+WfbrZNf3873QqeCtaQNiidX X-Received: by 2002:a05:6402:4150:b0:44a:ec16:def4 with SMTP id x16-20020a056402415000b0044aec16def4mr23035841eda.21.1664201398984; Mon, 26 Sep 2022 07:09:58 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1664201398; cv=none; d=google.com; s=arc-20160816; b=oV5vJ5L8p9bg/HzgOhcSTQLaEkP2o7eTW3gMMEH8iBJkV/mUnRxiW8LfTUoIQv5gqj C34Fjtd4HdoJFdBq4TJvJA32QAxprcAyg8hLbCfVtGI+BBCZbDIg38WuD1LdljgU4Wqf 2kmyppdUdiL44IikeszoHnks8bc0MZRCyPppHiFCVKwHNN5fjnMi67MqJX/yQe0lEBUi o0iRnOmAuPiIaLwKPHgLetdbZ+keQJ9Hxw0He3nbse+/LX5lZXCSg6363GI44JlmcWsM J5YvS75CtTpZfID/KSoz44UzU2o1zziZiJIBCgf+Ec76h0VhBOMqSR9++2m7rpPX7WhW DXjQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :user-agent:references:in-reply-to:message-id:date:subject:cc:to :from:dkim-signature; bh=/UPhgFJHYrbaTSuHQxx6vvmJQrNYa3PFU3jduJRYvHI=; b=ayGLp0fT2CUfQAzZoDuefMDQhaD77Dwq3AZfsO9CouIsxNCQiKZkRQ2zQWNfdiD6hA Ork5wKSmPTPd/8SffJD3prKYFQ2JYnZJ//nfTEFWVoBjNby4LlC3pGkkzLpK7O27Nf2O idCkI3xpJIWTnWSFjgB2dmnf0MmU6ZL6KOrPDS3Wpe0hm5uHb67Bh5lMjJPjkRowBHDa ww1m0m7CDVzXaKs8VpVLhaVUbM7VcW7jjIs3GJ1JnAV1LMyb91jwV9mHcbxYnupDK1cn 5PwGsVkFIr8ZtxnEs1kvpJlnWV3VcMO5c/0+2W2EODzIaAO0yhEz66qkIA1npS/E9a05 z03Q== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b=Ru6Os3WQ; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id ca23-20020aa7cd77000000b004523826ed4asi14517406edb.572.2022.09.26.07.09.33; Mon, 26 Sep 2022 07:09:58 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b=Ru6Os3WQ; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S238087AbiIZLhN (ORCPT + 99 others); Mon, 26 Sep 2022 07:37:13 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:49114 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S238081AbiIZLft (ORCPT ); Mon, 26 Sep 2022 07:35:49 -0400 Received: from ams.source.kernel.org (ams.source.kernel.org [145.40.68.75]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 338646EF04; Mon, 26 Sep 2022 03:43:50 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id 81BD2B8095B; Mon, 26 Sep 2022 10:43:50 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id D4C83C433C1; Mon, 26 Sep 2022 10:43:48 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1664189029; bh=hbX0O4j5USK+7RKpbhjOSEOCaH0sBE6gjVM88scBssA=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=Ru6Os3WQv+crTxS24IqmSwkuYbSEWls9F+cu75VkBzcWo/+Rbv9HDHwzv8KFYRIkO bP9udvc7Ni6U9I9Bp2pBLc8rNU6UlHB8wkKKL3rmJx6ffrAfu+YPT2RJRsQhD8YxWJ onzWpy9gjX1EPRX7oW2a95GSCo95TWe3jjsD4L+o= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Felix Fietkau , Kalle Valo Subject: [PATCH 5.19 050/207] wifi: mt76: fix reading current per-tid starting sequence number for aggregation Date: Mon, 26 Sep 2022 12:10:39 +0200 Message-Id: <20220926100808.862244223@linuxfoundation.org> X-Mailer: git-send-email 2.37.3 In-Reply-To: <20220926100806.522017616@linuxfoundation.org> References: <20220926100806.522017616@linuxfoundation.org> User-Agent: quilt/0.67 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-7.2 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_HI, SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Felix Fietkau commit c3a510e2b53785df31d882a773c4c0780b4c825f upstream. The code was accidentally shifting register values down by tid % 32 instead of (tid * field_size) % 32. Cc: stable@vger.kernel.org Fixes: a28bef561a5c ("mt76: mt7615: re-enable offloading of sequence number assignment") Signed-off-by: Felix Fietkau Signed-off-by: Kalle Valo Link: https://lore.kernel.org/r/20220826182329.18155-1-nbd@nbd.name Signed-off-by: Greg Kroah-Hartman --- drivers/net/wireless/mediatek/mt76/mt7615/mac.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) --- a/drivers/net/wireless/mediatek/mt76/mt7615/mac.c +++ b/drivers/net/wireless/mediatek/mt76/mt7615/mac.c @@ -1138,7 +1138,7 @@ u32 mt7615_mac_get_sta_tid_sn(struct mt7 offset %= 32; val = mt76_rr(dev, addr); - val >>= (tid % 32); + val >>= offset; if (offset > 20) { addr += 4;