Received: by 2002:a05:6359:c8b:b0:c7:702f:21d4 with SMTP id go11csp898380rwb; Mon, 26 Sep 2022 07:14:47 -0700 (PDT) X-Google-Smtp-Source: AMsMyM5+Lv4qZQGKqyqGaT2dJH3uUVEXqGYN3nqeqwu5Bu2eQwPkfTLjpwug6T+NIVUSrvwOrdmy X-Received: by 2002:a17:906:5a5a:b0:770:86d0:fd8 with SMTP id my26-20020a1709065a5a00b0077086d00fd8mr18599641ejc.164.1664201687109; Mon, 26 Sep 2022 07:14:47 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1664201687; cv=none; d=google.com; s=arc-20160816; b=vyi4J8lae0q7fo5Vt39FXYR1mYAx5nbcqZFg3WEAKWYNwGu6hnBUT/DO99Dr5RzXJA Hs439bp/NLbtiVbpxLRUBxPlF28XSyE+htzDWLNgOm2Ky1kVwZbVZTmNVYibYR8JFMvU yW1IYf//CV5oGn2WMK00Cxut2vKp4h7lroNnZGb/80DVY/D+vRZXSDLyDjgzxWk6VkrR qw0/+O6FAvjtImlq2/RNgZztIXXXlNogYpA5oLCZzXUQO1XOpdKlDljOST134083XW3n nhoHNa2Xv6bzAEsBHz886HwJyNm2G0sKdKs2+ATeQ0FsGtzXVH91Shyt1U0L8rT2/kPB Hc+g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :user-agent:references:in-reply-to:message-id:date:subject:cc:to :from:dkim-signature; bh=gPxTfQrasTVvD7DTl2TpO1T3lJuaLWljlRKT8/NDArs=; b=BSXYRrOUPvPNV+pjdOby6BUJs+MOl9qq/K5J8K1T9pEDfiT9qKLdtD/8PaULKb8WbN NK9QT5KKymdJbnSrNR57prqZ75to7vqmq2rhY0oE9MzCqxBlZkxCrO/phvz+4dR7E6Gr iTrBxkdcOwvzFJs/paTtNaBe8Y+pXjBDqKSSfia3ayu0rvwXNXdT+0rdkI26CiytkKha 77MUnboGH80T4Wt9CMijQ++Vnl+0kYDGAkjljRuH1pFVaF5/sBjlpRusdBhz721VinJ0 qNNw92cMGwYOxM3aBbH3r1/GKE4KNlkkgt+sgTmo8u816qNRCaRirW5hoIMfg8GRiXQu jvXA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b="oOSYu/La"; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id cr11-20020a170906d54b00b0073d7de9711dsi17672972ejc.650.2022.09.26.07.14.09; Mon, 26 Sep 2022 07:14:47 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b="oOSYu/La"; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234554AbiIZL3b (ORCPT + 99 others); Mon, 26 Sep 2022 07:29:31 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:42036 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S237932AbiIZL2R (ORCPT ); Mon, 26 Sep 2022 07:28:17 -0400 Received: from ams.source.kernel.org (ams.source.kernel.org [145.40.68.75]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id D56306B150; Mon, 26 Sep 2022 03:41:19 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id 49180B80942; Mon, 26 Sep 2022 10:41:19 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 98BBBC433D6; Mon, 26 Sep 2022 10:41:17 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1664188878; bh=xLv6Yp4tyzE+V2Ro4LgR0kyqrrBkxn5bGkLAx5w9QAA=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=oOSYu/LaN05Ijg+NnhPLnYQH4TnK4CY/odo9ex39IGeCAfZ8/YzFDlRA4jHNwPoYo /3NsE0j0ybLJ+YCz1tjpw9DCWpau3RHMYdq+ToKyQ+VRvPNjCT1j+b1lvQ9SOaNPdr gHR9/ud2haTjHTP9Zcaubkz8jkUwwU8Ln6mlycL8= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Andy Shevchenko , =?UTF-8?q?Ilpo=20J=C3=A4rvinen?= Subject: [PATCH 5.15 121/148] serial: tegra-tcu: Use uart_xmit_advance(), fixes icount.tx accounting Date: Mon, 26 Sep 2022 12:12:35 +0200 Message-Id: <20220926100800.685080097@linuxfoundation.org> X-Mailer: git-send-email 2.37.3 In-Reply-To: <20220926100756.074519146@linuxfoundation.org> References: <20220926100756.074519146@linuxfoundation.org> User-Agent: quilt/0.67 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-7.2 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_HI, SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Ilpo Järvinen commit 1d10cd4da593bc0196a239dcc54dac24b6b0a74e upstream. Tx'ing does not correctly account Tx'ed characters into icount.tx. Using uart_xmit_advance() fixes the problem. Fixes: 2d908b38d409 ("serial: Add Tegra Combined UART driver") Cc: # serial: Create uart_xmit_advance() Reviewed-by: Andy Shevchenko Signed-off-by: Ilpo Järvinen Link: https://lore.kernel.org/r/20220901143934.8850-4-ilpo.jarvinen@linux.intel.com Signed-off-by: Greg Kroah-Hartman --- drivers/tty/serial/tegra-tcu.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) --- a/drivers/tty/serial/tegra-tcu.c +++ b/drivers/tty/serial/tegra-tcu.c @@ -101,7 +101,7 @@ static void tegra_tcu_uart_start_tx(stru break; tegra_tcu_write(tcu, &xmit->buf[xmit->tail], count); - xmit->tail = (xmit->tail + count) & (UART_XMIT_SIZE - 1); + uart_xmit_advance(port, count); } uart_write_wakeup(port);