Received: by 2002:a05:6359:c8b:b0:c7:702f:21d4 with SMTP id go11csp17976rwb; Mon, 26 Sep 2022 08:45:05 -0700 (PDT) X-Google-Smtp-Source: AMsMyM6PTbDg2TKwSeDiUPH9St1In94DANynAZHuuqCm1SQb5bUVGiyM7Bp5l4AG4WjAec7uXs8Z X-Received: by 2002:a17:902:b288:b0:177:ff40:19cf with SMTP id u8-20020a170902b28800b00177ff4019cfmr22909570plr.117.1664207105651; Mon, 26 Sep 2022 08:45:05 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1664207105; cv=none; d=google.com; s=arc-20160816; b=CzCMvsZL1OhKf9aIwy4gnxWv/INc7MiuKfzAhI1yOmynsdrEOtXKar4T67atQtI+A4 I0h6sq2cfTnNYPdpA0L4yNCf87qpCxFvmduNqFOqDmx/6Gn0g9OfhnneiSsA+YGpB9Sp /YHd/zWk1JUItvFFmZjN2u8iF8LLlwio5E7W7Cw4uA+oGCRQQRL269D7iw2N3zsgntvc DqmHIQxkNcDA+LwnAgb4s8AmOH6KXPAEq1O5qenfGTdzgdz3hCy2tLAwAEGEyRVkWec6 FL0Ve5PFOnGX/KO2YuPuYQzC4b6L8u8FVdPi3THEovlfes+h7lXdduTrtEwogRKvsOu8 OnzA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date:dkim-signature; bh=T7W3vMO9tuQw1ch0loPah1OFffLIuFMRKn5RdUQipcs=; b=azNhIDLOopEDsAXfcqCwetF92kVEY2y4lqn1KbJIIFyA3I15UWFlnXPmuWFPVuj++O Hw6eatmByjEet+xRxX115itH69o6C3BdQ9wo6CMtPiL9f2GNXpiScaiPH6omHp8JdOde LLzthyrd1AvqsxEVVkTnaYxhyjwlJ422R73NjQn3c5rDxBmntSqfM60vOYNUNU5RFu2H ATRqvysVzv0SDsFA9NsmDWQw44MfFPnikz7koXBIR9SNEKztOAJT3qqoPqtWFJ4G5Y+V gT4vZrnHRncue+HFGMo851933/w2O8XESYScWSoduO0ldFKlDOdKgYIyX/62mKhsMoci J2Lw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=yfgZBnie; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id d13-20020a634f0d000000b0043560d14c72si17292147pgb.105.2022.09.26.08.44.12; Mon, 26 Sep 2022 08:45:05 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=yfgZBnie; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S235506AbiIZO5c (ORCPT + 99 others); Mon, 26 Sep 2022 10:57:32 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:40744 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S235446AbiIZO5C (ORCPT ); Mon, 26 Sep 2022 10:57:02 -0400 Received: from mail-wr1-x42a.google.com (mail-wr1-x42a.google.com [IPv6:2a00:1450:4864:20::42a]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id D4B08760E7 for ; Mon, 26 Sep 2022 06:27:58 -0700 (PDT) Received: by mail-wr1-x42a.google.com with SMTP id z6so10264076wrq.1 for ; Mon, 26 Sep 2022 06:27:58 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date; bh=T7W3vMO9tuQw1ch0loPah1OFffLIuFMRKn5RdUQipcs=; b=yfgZBniecjUWpi3bk6V4rQIus/MCIZpz9t4A7SVfoQPg00l0Rk23hmYkPyEaObXEb4 hErU2p41GocomjtVpFRtLhtaVT/pVCvWai5rb66aecDYLhjdoxtTjhCtiAlyt7d+GoDd ExMEssCO5FQeGG9RZtVpGSYpS9DPtffUjQ/gWMr+cXq41hPvghCzcjm/etv6p+RSNuWw dJPvz42iGKt7Ja2hRVDorsq9VDPdrWr5fG8bwkuv8zThTLQskIX9o+zoOWF7yyxCXf1w Q0eiNduP6bFY3YXQ0VhPbuwyLS6qyewDcnGye4M4V/Dq/FQAy3+iRIehVfaFaI11ezH8 z2CQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date; bh=T7W3vMO9tuQw1ch0loPah1OFffLIuFMRKn5RdUQipcs=; b=ghx5p/J/r3Mcz1uKG/SRyeCEvzS+NH41RqYQ48DFY+R/sNUn26Pocu2Bz6GdlajJuF +M8u0DFlrU7CyF49yvumN/Le/sjexdxqRuUso4ld8Ccd7L5+85RgUG8GC61GAy/tmfjw xD5cs8Utj+aCy08/ET64IH3/5o6HDV9Fu6LFtt6cS3C5MwqZICB3tGxX7CH/JWQJB0uR 8eRkV4kQiC4oMvgs0TW+Dhawer4hTDoiIx2t164KZFwnOQg7mwzjDli8Jhr9QuRt6bFt LDRCDA5YKp7fhBkmAWv04RnUC9aaFplZR7E5iihrs85jMNkcB1d3w/EthrCS9QhpRxM0 nYaw== X-Gm-Message-State: ACrzQf1LTnQOnH55X+XPDvMEApLEjTxnIx5M8WPlPxYHlxy4x0KB8P/a VWUstFBF7ZymbSD1ouJff2MyFQ== X-Received: by 2002:a5d:6b09:0:b0:225:37cf:fb8b with SMTP id v9-20020a5d6b09000000b0022537cffb8bmr13370722wrw.179.1664198877330; Mon, 26 Sep 2022 06:27:57 -0700 (PDT) Received: from maple.lan (cpc141216-aztw34-2-0-cust174.18-1.cable.virginm.net. [80.7.220.175]) by smtp.gmail.com with ESMTPSA id bn27-20020a056000061b00b0022762b0e2a2sm15616002wrb.6.2022.09.26.06.27.56 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 26 Sep 2022 06:27:56 -0700 (PDT) Date: Mon, 26 Sep 2022 14:27:54 +0100 From: Daniel Thompson To: cgel.zte@gmail.com Cc: lee@kernel.org, jingoohan1@gmail.com, deller@gmx.de, dri-devel@lists.freedesktop.org, linux-fbdev@vger.kernel.org, linux-kernel@vger.kernel.org, ye xingchen Subject: Re: [PATCH linux-next] backlight: lp8788: use sysfs_emit() to instead of scnprintf() Message-ID: References: <20220923063533.239315-1-ye.xingchen@zte.com.cn> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20220923063533.239315-1-ye.xingchen@zte.com.cn> X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE, SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Sep 23, 2022 at 06:35:33AM +0000, cgel.zte@gmail.com wrote: > From: ye xingchen > > Replace the open-code with sysfs_emit() to simplify the code. > > Signed-off-by: ye xingchen > --- > drivers/video/backlight/lp8788_bl.c | 2 +- This one has the subject right and is a good change. However I'd still prefer it as a single patchset that fixes *all* instances of this code pattern. Daniel.