Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <fea0d8b3-f9e2-d081-e0c0-d81c9ca405d2@linaro.org>
Date:   Mon, 26 Sep 2022 14:53:47 +0200
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101
 Thunderbird/102.3.0
Subject: Re: [PATCH] dt-bindings: display: mediatek: dpi: Add compatible for
 MediaTek MT8188
Content-Language: en-US
To:     "liangxu.xu" <liangxu.xu@mediatek.com>, chunkuang.hu@kernel.org,
        p.zabel@pengutronix.de, airlied@linux.ie, daniel@ffwll.ch,
        robh+dt@kernel.org, krzysztof.kozlowski+dt@linaro.org,
        matthias.bgg@gmail.com, jitao.shi@mediatek.com
Cc:     dri-devel@lists.freedesktop.org,
        linux-mediatek@lists.infradead.org, devicetree@vger.kernel.org,
        linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
        Project_Global_Chrome_Upstream_Group@mediatek.com
References: <20220923014227.6566-1-liangxu.xu@mediatek.com>
 <33e9babb-0492-2f41-d055-45ed32d55906@linaro.org>
 <ff6020d05962e202e917644b06eaa2cff7b2bb99.camel@mediatek.com>
 <8cc90559-6e83-1b6d-2718-d26ceace6362@linaro.org>
 <023b0a09a65042e6fee6b668d3df506f7d8178fd.camel@mediatek.com>
From:   Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
In-Reply-To: <023b0a09a65042e6fee6b668d3df506f7d8178fd.camel@mediatek.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
Precedence: bulk

On 26/09/2022 14:12, liangxu.xu wrote:
> 
> Can I modify it to the following form:
> properties:
>   compatible:
>     oneOf:
>       - enum:
>         - mediatek,mt2701-dpi
>         - mediatek,mt7623-dpi
>         - mediatek,mt8173-dpi
>         - mediatek,mt8183-dpi
>         - mediatek,mt8186-dpi
>         - mediatek,mt8192-dpi
>         - mediatek,mt8195-dp-intf
>       - items:
>           - enum:
>               - mediatek,mt8188-dp-intf
>           - const: mediatek,mt8195-dp-intf
> 
> This means that mt8188 reuses mt8195, so there is no need to add
> compatible to the driver.

I am now confused. You send some bindings which do not match DTS and driver?

This has to stop... please post the bindings with the user - DTS and
optionally driver.

Best regards,
Krzysztof