Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
From:   Ali Saidi <alisaidi@amazon.com>
To:     <renyu.zj@linux.alibaba.com>
CC:     <acme@kernel.org>, <alexander.shishkin@linux.intel.com>,
        <alisaidi@amazon.com>, <german.gomez@arm.com>,
        <james.clark@arm.com>, <john.garry@huawei.com>, <jolsa@kernel.org>,
        <leo.yan@linaro.org>, <linux-arm-kernel@lists.infradead.org>,
        <linux-kernel@vger.kernel.org>, <linux-perf-users@vger.kernel.org>,
        <mark.rutland@arm.com>, <mike.leach@linaro.org>,
        <mingo@redhat.com>, <namhyung@kernel.org>, <peterz@infradead.org>,
        <timothy.hayes@arm.com>, <will@kernel.org>,
        <xueshuai@linux.alibaba.com>, <zhuo.song@linux.alibaba.com>
Subject: Re: [PATCH] perf arm-spe: augment the data source type with neoverse_spe list
Date:   Mon, 26 Sep 2022 14:10:32 +0000
Message-ID: <20220926141032.30734-1-alisaidi@amazon.com>
In-Reply-To: <1664197396-42672-1-git-send-email-renyu.zj@linux.alibaba.com>
References: <1664197396-42672-1-git-send-email-renyu.zj@linux.alibaba.com>
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit
Content-Type: text/plain
Precedence: bulk

> When synthesizing event with SPE data source, commit 4e6430cbb1a9("perf
> arm-spe: Use SPE data source for neoverse cores") augment the type with
> source information by MIDR. However, is_midr_in_range only compares the
> first entry in neoverse_spe.
> 
> Change is_midr_in_range to is_midr_in_range_list to traverse the
> neoverse_spe array so that all neoverse cores synthesize event with data
> source packet.
> 
> Fixes: 4e6430cbb1a9("perf arm-spe: Use SPE data source for neoverse cores")
> Signed-off-by: Jing Zhang <renyu.zj@linux.alibaba.com>

Thanks for catching this, you're absolutely right.

Reviewed-by: Ali Saidi <alisaidi@amazon.com>

Ali