Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <68397430eab0fee46d8c61b8a8d6c2ecd27447d4.camel@linux.ibm.com>
Subject: Re: [PATCH v2 2/3] s390/pci: remove unused bus_next field from
 struct zpci_dev
From:   Niklas Schnelle <schnelle@linux.ibm.com>
To:     Pierre Morel <pmorel@linux.ibm.com>,
        Matthew Rosato <mjrosato@linux.ibm.com>, iommu@lists.linux.dev
Cc:     linux-s390@vger.kernel.org, borntraeger@linux.ibm.com,
        hca@linux.ibm.com, gor@linux.ibm.com,
        gerald.schaefer@linux.ibm.com, agordeev@linux.ibm.com,
        svens@linux.ibm.com, joro@8bytes.org, will@kernel.org,
        robin.murphy@arm.com, jgg@nvidia.com, linux-kernel@vger.kernel.org
Date:   Mon, 26 Sep 2022 15:41:24 +0200
In-Reply-To: <8ba5cee2-5e5c-6b73-3ac7-56e78e432698@linux.ibm.com>
References: <20220922095239.2115309-1-schnelle@linux.ibm.com>
         <20220922095239.2115309-3-schnelle@linux.ibm.com>
         <e0754578-1735-5811-0533-19ef0c6be2b0@linux.ibm.com>
         <8ba5cee2-5e5c-6b73-3ac7-56e78e432698@linux.ibm.com>
Content-Type: text/plain; charset="UTF-8"
Mime-Version: 1.0
Content-Transfer-Encoding: 7bit
Precedence: bulk

On Mon, 2022-09-26 at 11:23 +0200, Pierre Morel wrote:
> 
> On 9/26/22 11:17, Pierre Morel wrote:
> > 
> > On 9/22/22 11:52, Niklas Schnelle wrote:
> > > This field was added in commit 44510d6fa0c0 ("s390/pci: Handling
> > > multifunctions") but is an unused remnant of an earlier version where
> > > the devices on the virtual bus were connected in a linked list instead
> > > of a fixed 256 entry array of pointers.
> > > 
> > > It is also not used for the list of busses as that is threaded through
> > > struct zpci_bus not through struct zpci_dev.
> > > 
> > > Signed-off-by: Niklas Schnelle <schnelle@linux.ibm.com>
> > 
> > Reviewed-by: Pierre Morel <pmorel@linux.ibm.com>
> > 
> > 
> 
> Also couldn't it be detached of the series and posted on its own?

As this is entirely s390 specific this can go via the s390 tree without
re-posting. Since we're still figuring the rest of the series out it
might even make it upstream before that and then we can more easily
refer to it as a pre-requisite.

> 
> > > ---
> > >   arch/s390/include/asm/pci.h | 1 -
> > >   1 file changed, 1 deletion(-)
> > > 
> > > diff --git a/arch/s390/include/asm/pci.h b/arch/s390/include/asm/pci.h
> > > index 7b4cdadbc023..108e732d7b14 100644
> > > --- a/arch/s390/include/asm/pci.h
> > > +++ b/arch/s390/include/asm/pci.h
> > > @@ -117,7 +117,6 @@ struct zpci_bus {
> > >   struct zpci_dev {
> > >       struct zpci_bus *zbus;
> > >       struct list_head entry;        /* list of all zpci_devices, 
> > > needed for hotplug, etc. */
> > > -    struct list_head bus_next;
> > >       struct kref kref;
> > >       struct hotplug_slot hotplug_slot;