Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Mon, 26 Sep 2022 23:00:31 +0800
From:   Leo Yan <leo.yan@linaro.org>
To:     Ali Saidi <alisaidi@amazon.com>
Cc:     renyu.zj@linux.alibaba.com, acme@kernel.org,
        alexander.shishkin@linux.intel.com, german.gomez@arm.com,
        james.clark@arm.com, john.garry@huawei.com, jolsa@kernel.org,
        linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org,
        linux-perf-users@vger.kernel.org, mark.rutland@arm.com,
        mike.leach@linaro.org, mingo@redhat.com, namhyung@kernel.org,
        peterz@infradead.org, timothy.hayes@arm.com, will@kernel.org,
        xueshuai@linux.alibaba.com, zhuo.song@linux.alibaba.com
Subject: Re: [PATCH] perf arm-spe: augment the data source type with
 neoverse_spe list
Message-ID: <YzG+goZySC4K8S4Z@leoy-huanghe.lan>
References: <1664197396-42672-1-git-send-email-renyu.zj@linux.alibaba.com>
 <20220926141032.30734-1-alisaidi@amazon.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20220926141032.30734-1-alisaidi@amazon.com>
Precedence: bulk

On Mon, Sep 26, 2022 at 02:10:32PM +0000, Ali Saidi wrote:
> > When synthesizing event with SPE data source, commit 4e6430cbb1a9("perf
> > arm-spe: Use SPE data source for neoverse cores") augment the type with
> > source information by MIDR. However, is_midr_in_range only compares the
> > first entry in neoverse_spe.
> > 
> > Change is_midr_in_range to is_midr_in_range_list to traverse the
> > neoverse_spe array so that all neoverse cores synthesize event with data
> > source packet.
> > 
> > Fixes: 4e6430cbb1a9("perf arm-spe: Use SPE data source for neoverse cores")
> > Signed-off-by: Jing Zhang <renyu.zj@linux.alibaba.com>
> 
> Thanks for catching this, you're absolutely right.
> 
> Reviewed-by: Ali Saidi <alisaidi@amazon.com>

It's also good for me:
Reviewed-by: Leo Yan <leo.yan@linaro.org>