Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Mon, 26 Sep 2022 10:32:42 -0400
From:   Steven Rostedt <rostedt@goodmis.org>
To:     Zheng Yejian <zhengyejian1@huawei.com>
Cc:     <mingo@redhat.com>, <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] ftrace: Properly unset FTRACE_HASH_FL_MOD
Message-ID: <20220926103242.6d0fc1ea@gandalf.local.home>
In-Reply-To: <20220926152008.2239274-1-zhengyejian1@huawei.com>
References: <20220926152008.2239274-1-zhengyejian1@huawei.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Precedence: bulk

On Mon, 26 Sep 2022 15:20:08 +0000
Zheng Yejian <zhengyejian1@huawei.com> wrote:

> When executing following commands like what document said, but the log
> "#### all functions enabled ####" was not shown as expect:
>   1. Set a 'mod' filter:
>     $ echo 'write*:mod:ext3' > /sys/kernel/tracing/set_ftrace_filter
>   2. Invert above filter:
>     $ echo '!write*:mod:ext3' >> /sys/kernel/tracing/set_ftrace_filter
>   3. Read the file:
>     $ cat /sys/kernel/tracing/set_ftrace_filter
> 
> By some debugging, I found that flag FTRACE_HASH_FL_MOD was not unset
> after inversion like above step 2 and then result of ftrace_hash_empty()
> is incorrect.
> 
> Cc: stable@vger.kernel.org
> Fixes: 8c08f0d5c6fb ("ftrace: Have cached module filters be an active filter")
> Signed-off-by: Zheng Yejian <zhengyejian1@huawei.com>

Thanks, this definitely looks like a bug.

I'll be reviewing these patches later this week.

-- Steve