Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Mon, 26 Sep 2022 14:07:43 -0300
From:   Jason Gunthorpe <jgg@nvidia.com>
To:     Deming Wang <wangdeming@inspur.com>
Cc:     pbonzini@redhat.com, kvm@vger.kernel.org,
        linux-kernel@vger.kernel.org
Subject: Re: [PATCH] vfio: Use filp instead of fd
Message-ID: <YzHcX2VLh+0n2mAP@nvidia.com>
References: <20220926065407.2389-1-wangdeming@inspur.com>
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20220926065407.2389-1-wangdeming@inspur.com>
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?V5AEtnTMZQYEHN774qcvfOlDsrrvUUjQYkrmRJi3xVxXNqG++ip+25uLLxOJ?=
 =?us-ascii?Q?metxOa3QLS6MBjdx833ODDRD6bRgceRjHVBD9VfSzDScUXizMFnB0lZPQ3ut?=
 =?us-ascii?Q?+nEX6z6MxS39I5Rq+eTV9d311coz8CWana20eH1ZB+BWUfptShv6Ac+5FlrV?=
 =?us-ascii?Q?sGg6QhP5JfNBsW9yTfP29S6MgeMphqj137Pk/ZyGBRbtaKEMhaMX8g68f5aD?=
 =?us-ascii?Q?c/CWju6GRu2s3UVO4nCyGsd4cM52oZfkGJ3t4ZuC3vkhZRH4O7yRiDWpCcCS?=
 =?us-ascii?Q?8DWPoKGVMQ18Ywa6pXQf+Re0wDYFcpZO4FiLnHOW9eTO55Ktqa5a8FKyWS5s?=
 =?us-ascii?Q?XhXA1k9kM4B7QSYPdhpnrpc3ZspJeU+ei3JSKXqC64WAn6j1GVo0MN6QZpuE?=
 =?us-ascii?Q?p7QCYwOBzKq6UExDS6uh1GY5nhbZFRnfD7Jfzxtr27UkHY/8/VfF+HCeLVDI?=
 =?us-ascii?Q?fPUa8+tJIzonn5RoPkkXTBKaj8BZEAVp8LxHyKbom13TdxfTUTArEWclmIyS?=
 =?us-ascii?Q?jNFnWaMLXH1ZNsYe/RfN3elJZJoGXL0DbT1/vFaGpvEOIC4qxxt7NKs6deJc?=
 =?us-ascii?Q?i4G4/YKqOtsVTEx88swHnouo6/2Z+ZqGvNfNv/GWX/NUJRbdR3PMmQ/rKzpE?=
 =?us-ascii?Q?zgl1ygQRjPZnVuhgFLlBXDz46XszmOHA7OD/foHo4P2/U9M6yA6jgFip5ZST?=
 =?us-ascii?Q?C5H9LZgNfO75gRgY5GHUCQsRlpZhm77FTc9Sl2umKUj6FDVakqR7rKHPl5qZ?=
 =?us-ascii?Q?ToGJkk7e8jA6zn+neQUkMr70hN97cijfQKZum8mrxx2TIK9pWnCTmyfhL4o3?=
 =?us-ascii?Q?+MAPuzY+hk1/I7laZK3H6J6E0cAxBIr0FRIXdllD5c0ZBhzinHyXXVlEjQpZ?=
 =?us-ascii?Q?mtQD1AGxOkGztcex+4dzYqK8Rh4nSBmCRwdF7//0RHeJnXz/WbeZ/Ty8C58j?=
 =?us-ascii?Q?i9IOimTTm96ES5+orjyzdLTf8+hBUR7ZqQU2qNZWQuQBgU7UkzosnBQauCi5?=
 =?us-ascii?Q?XVACuNqFzMo96qOgXlLZxuy1QVBOcDqvB7BzcZPooNLG6CQ4xoeFuzBocLnT?=
 =?us-ascii?Q?S3nMecTQFfjyzPxd3duLfmnscbN1nl13v/hTY7rU/DMemPDQN9Pexb4B8ZOc?=
 =?us-ascii?Q?1No067OWA2yUfCq2W3/bMam1GFrauRtd0HZrLbJ88vCjDZGMauQBOCJHtiRr?=
 =?us-ascii?Q?nZeg8hmeKySR8r07CkfYvNvQ8iKA9f2ADARPXWPgtYFl3qHPdYijDfeI59Rn?=
 =?us-ascii?Q?rjUxAWIXnUSIWzApUNaKihHQ0Wedzu8fai/gagtqRPdnuj1w4WQrQ9p1R4Db?=
 =?us-ascii?Q?KZDDDNDm8DSXJj2bnFM39pvZurjPLLQP7zVbkvDHko9I6meqIAd1+xvU+/qI?=
 =?us-ascii?Q?iYREVln0SYMlKGuT9N0az9qB7fecoq4Rm3hE0u4ep6Np6nkFeIO6gbJV1PGI?=
 =?us-ascii?Q?w3wC/TQ4J8M1XgKCwzYD72N0PWAd2XH0t53Y990AqZo9d74Ek4Gx/WXtsKrH?=
 =?us-ascii?Q?Vx6n3Gif+4vv4g9QGaqToydKaPCP1JxwkpiReNV680zD1G0/tDKbG4ph1sNs?=
 =?us-ascii?Q?7lec6ktFiv9cZswMsy0=3D?=
X-OriginatorOrg: Nvidia.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 69cb57b7-7065-4366-3dff-08da9fe1a13a
X-MS-Exchange-CrossTenant-AuthSource: MN2PR12MB4192.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 26 Sep 2022 17:07:46.2139
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: Fjw/IJQeShqB4iYqwdohUWp/1x82eGcb5dEo5j/J+voAKWYtlAnAGvjWvb/8ynkt
X-MS-Exchange-Transport-CrossTenantHeadersStamped: CY8PR12MB7588
X-Spam-Status: No, score=-1.2 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,
        DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FORGED_SPF_HELO,
        RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_NONE
        autolearn=no autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Mon, Sep 26, 2022 at 02:54:07AM -0400, Deming Wang wrote:
> The function of kvm_vfio_group_set_spapr_tce and kvm_vfio_group_del
> use fd indirectly.But,it only be used for fd.file. So,we can directly
> use the struct of file instead.
> 
> Signed-off-by: Deming Wang <wangdeming@inspur.com>
> ---
>  virt/kvm/vfio.c | 24 ++++++++++++------------
>  1 file changed, 12 insertions(+), 12 deletions(-)

I thought about changing this too when I was looking at
this. fdget/fdput includes a tiny micro-optimization that is legal
here, however I doubt anyone cares about performance on this path.

Reviewed-by: Jason Gunthorpe <jgg@nvidia.com>

Jason