Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755032AbXFVMkl (ORCPT ); Fri, 22 Jun 2007 08:40:41 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1756180AbXFVMkW (ORCPT ); Fri, 22 Jun 2007 08:40:22 -0400 Received: from gateway-1237.mvista.com ([63.81.120.155]:7888 "EHLO imap.sh.mvista.com" rhost-flags-OK-FAIL-OK-FAIL) by vger.kernel.org with ESMTP id S1756085AbXFVMkU (ORCPT ); Fri, 22 Jun 2007 08:40:20 -0400 Message-ID: <467BC398.1000506@ru.mvista.com> Date: Fri, 22 Jun 2007 16:42:00 +0400 From: Sergei Shtylyov Organization: MontaVista Software Inc. User-Agent: Mozilla/5.0 (X11; U; Linux i686; rv:1.7.2) Gecko/20040803 X-Accept-Language: ru, en-us, en-gb MIME-Version: 1.0 To: Tony Breeds Cc: Daniel Walker , Andrew Morton , john stultz , LKML , LinuxPPC-dev , Thomas Gleixner , Ingo Molnar Subject: Re: [RFC] clocksouce implementation for powerpc References: <20070616101126.296384219@inhelltoy.tec.linutronix.de> <20070616101637.107940593@inhelltoy.tec.linutronix.de> <1182009083.11539.369.camel@imap.mvista.com> <20070620065710.GR9768@bakeyournoodle.com> <46795B9B.2020401@ru.mvista.com> <20070622061047.GW9768@bakeyournoodle.com> In-Reply-To: <20070622061047.GW9768@bakeyournoodle.com> Content-Type: text/plain; charset=us-ascii; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1492 Lines: 43 Tony Breeds wrote: > Thanks for taking the time to look over my patch. >> I guess it's been based on the prior work by John Stultz (and me too :-)? > At some level I guess so. John did send me a patch a while ago. >> If you mean the init. part, this has been already done by me -- I've >>implemented read_persistent_clock() and got rid of xtime setting. What's >>left is to implemet update_persistent_clock() and get rid of >>timer_check_rtc()... > Actually I think that comment is redundant. and should be removed > sorry. I guess you haven't looked thru the -rt patch? There's much more than John's initial patch there now, including the clockevents driver. >>>+ .mult = 0, /* To be filled in */ >>>+ .read = NULL, /* To be filled in */ >>>+ .settimeofday = NULL, /* To be filled in */ >> >> I don't quite understand why not just init them right away? The values >>are fixed anyways. > Well at least mult needs to be calculated at runtime, and I prefer to I was talking about the method intializers specifically. > have the structure near the top of the file at which stage the > read/settimeofday functions aren't defined. I don't think it's justified anyway. > Yours Tony WBR, Sergei - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/