Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Mon, 26 Sep 2022 14:28:13 -0300
From:   Jason Gunthorpe <jgg@nvidia.com>
To:     Li Zhijian <lizhijian@fujitsu.com>
Cc:     Zhu Yanjun <zyjzyj2000@gmail.com>,
        Leon Romanovsky <leon@kernel.org>, linux-rdma@vger.kernel.org,
        yangx.jy@fujitsu.com, Bob Pearson <rpearsonhpe@gmail.com>,
        linux-kernel@vger.kernel.org
Subject: Re: [PATCH] RDMA/RXE: Add send_common_ack() helper
Message-ID: <YzHhLQgIK9AlYkcq@nvidia.com>
References: <1659335010-2-1-git-send-email-lizhijian@fujitsu.com>
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <1659335010-2-1-git-send-email-lizhijian@fujitsu.com>
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?B25NJFdstihEk5Mmf24e5ESEeSAbafhvPvqgSIcIAgGsAJuVfChZuM53+TZt?=
 =?us-ascii?Q?6Ejblf3BLYBDnchJh0xDEZmpN4BNUhnz1hZkUC9wLqAUgXq830LI9HrR2esg?=
 =?us-ascii?Q?148Ywbo2IKTNkmdwBKPgbWsBuJAl0+XQx/7pcpwVOlLKdCnFI5F6a23GLTdw?=
 =?us-ascii?Q?z3oVFMGYBxT7ahYLcxc9MwqdgZs11/g0p+G0yN5vVz0aL2B6CpUlKGseDS6d?=
 =?us-ascii?Q?MZui5uTuAL19c0c53kXTm7s3WRHh+i8K16wqAKaMti34znWgpLWtgXjXb2lE?=
 =?us-ascii?Q?1SLO2PKMkrdx7tmo7EmDABiDN+7Mdd8FGk/haM1DfWS+hkZX53HiXi1/q78S?=
 =?us-ascii?Q?QT0ZH1CDtunAUUIhHnkOFBxYwSz8/N78v/E4CiCnYF/wOXIGJZskxLysUnDA?=
 =?us-ascii?Q?9XVC3ZCjQ5bkSujx/8jDyRiYIz5XlRcQQYWQ2sHWU6MB/RSJqRTTlxDVMPcQ?=
 =?us-ascii?Q?SVsma8WXysa9P2CS7zZkyHp1LIGBgCZk+c39br5abfyZt4KCz4KDerVaq7pl?=
 =?us-ascii?Q?2lQof+rMCKysFUKhmMGBj5l1UmtLUB8W2xqOI+aBAGKCEgPC6lK2AJn6e/Vi?=
 =?us-ascii?Q?+6Ti/HBozzGU2Ckje8gDKIw+ankgImay/e3qFrYL8U5jtT/h2K7tL8dlAr7h?=
 =?us-ascii?Q?p+o+WYq0tDRn9est0K6N9NvfbPl8n+vWQKGLuWxLHZ5f5iIFNatAI2l3i97X?=
 =?us-ascii?Q?CYqISwFaLim9CrbLNbrZ8PuX4YKARe91C8vvkDl8l4qfjrmTldMxUHf5yaum?=
 =?us-ascii?Q?V+elizZngL0q8J7nQcTso92SxVStgbP+0O7geTIRxbO7X4HnHkbj6YQXvn5V?=
 =?us-ascii?Q?JZKblC7M76/43grEbxULHeF+DthDa5wa9vg52uYuRELxQcy3mnzUqrDRO9PQ?=
 =?us-ascii?Q?Yywper/vUjxKd2R5q+kxlrPvYkgR56IHd8KrtFaCcGGoOdfJPIBtRUrdoAi6?=
 =?us-ascii?Q?ufO0LQNgueJKFL+ERxfTyjHLVnqsX0360JvHGKKqqVK+Ax3cnuTnrC5U6640?=
 =?us-ascii?Q?wP1VNb4Z7sERWJ250MBQN5fHEg1DMZeD6iP1Q8NW3QQwlcy9nXaSIvm1hKyB?=
 =?us-ascii?Q?Z1CmMp8KQWK5hIm3EWFMmT4S0+OdH50M5S7TJajbgVe7PPMEZRmspFvyu8mr?=
 =?us-ascii?Q?TyrITFPvc4crU2gzP+5UXmWdexS2JJ6AXEm86GtoMniJPMaFRVk8zszlJvGh?=
 =?us-ascii?Q?9xDt35u//aYRDwoTtIHpaRC2fbN8uEh6L92sTpnagIv+xSKnM5qteIrkg6JW?=
 =?us-ascii?Q?KTizp1iwFGbLA6l9OQFvM2fq+gThrkKP8bG3WDPS3So7hyU8Bi8reDRrBXiZ?=
 =?us-ascii?Q?/gNux/FFu4Df/hlo6h8/a0JHD/iQZNob3emhMqN5OyHd4fy5KncLND6LoYVv?=
 =?us-ascii?Q?tDMbk4M3t5dYr76f4HD1ndbpqk7sQbPvCVSkYvmP1+VVgCMCMFfuzs+gGOtC?=
 =?us-ascii?Q?TDyy+dJylblk4XjoqPMahuT7QVYjIJYQOYMU4k0kZ3YtcONPbL0SWPaecZJN?=
 =?us-ascii?Q?botgHIUCl1bzPcR1egxBVan/NGVx2i3Wf4jN7wWduD7JcH4olHzlKgABv/mI?=
 =?us-ascii?Q?SUpmSCWphNTbGpyVh20=3D?=
X-OriginatorOrg: Nvidia.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 98005229-9b79-4953-5071-08da9fe47e77
X-MS-Exchange-CrossTenant-AuthSource: MN2PR12MB4192.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 26 Sep 2022 17:28:15.3204
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: /2OiMHqBKhQ++KfWiz4OL2TRcJC2qFFbIU5U24Q0lhQWdXbfy03cp6ALp5xg8Wap
X-MS-Exchange-Transport-CrossTenantHeadersStamped: MW4PR12MB7029
X-Spam-Status: No, score=-1.2 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,
        DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FORGED_SPF_HELO,
        RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_NONE
        autolearn=no autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Mon, Aug 01, 2022 at 06:23:30AM +0000, Li Zhijian wrote:
> Most code in send_ack() and send_atomic_ack() are duplicate, move them
> to a new helper send_common_ack().
> 
> In newer IBA SPEC, some opcodes require acknowledge with a zero-length read
> response, with this new helper, we can easily implement it later.
> 
> Signed-off-by: Li Zhijian <lizhijian@fujitsu.com>
> ---
>  drivers/infiniband/sw/rxe/rxe_resp.c | 43 ++++++++++++++----------------------
>  1 file changed, 17 insertions(+), 26 deletions(-)

Applied to for-next, thanks

If someone wants to standardize on rxe_ prefixes in the driver please
send that as a series

Jason