Received: by 2002:a05:6359:c8b:b0:c7:702f:21d4 with SMTP id go11csp264381rwb; Mon, 26 Sep 2022 12:02:32 -0700 (PDT) X-Google-Smtp-Source: AMsMyM4dLcnWv9XCdau/+ZTourdfVFuMxvVYwVdJlR1+XJAT4JHU/2wDM70d+mQ9Lvgdng8oXilh X-Received: by 2002:a17:90b:1bc7:b0:200:7f05:3c2 with SMTP id oa7-20020a17090b1bc700b002007f0503c2mr207572pjb.95.1664218951883; Mon, 26 Sep 2022 12:02:31 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1664218951; cv=none; d=google.com; s=arc-20160816; b=s/PiQox/GLJKBWfbIfj4ICSQW34mp1w384ZIrSl4HE6pG1th60/GEMisWh9//VU+eT iaf0eJQx/9cPq69Swku0vA9B8twDNX+M3yr0hbMdcBS+6PvIblJKQc0QFPn9oh4zdH8A BE0UjCiDfINmv10O5HIOMGTmsN8zIoHyTKJKp1JPanOCl4nkWVfmJ4WtacxbD7C1ysGB t4iM9i2yIDhWBbUtj1Q7/xiJJVPML8cxLmRudPXccE/uqqBfXGl594z6VlC/mhGOZ4rw CyFBBzjheynBe59ZxwfK6O5+n1Ju50FPzllv0BejcSnbl2/9XzyhZJ5skj6X/ZsUxC54 FyKw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date:dkim-signature; bh=aaQPbG0xc8cO8CY+sDVDBPoIq1DASoXAvqG8pMdSfu4=; b=S8eu5D5M2ULHqYEtbkZGi0zyNnr8m5dsFrvouuvPKQkmMWTthF3T0/BpNykEmdMdQQ +9VJ2E1yKb494R+9AAHc7IbP5cy0egYrTCaZHB/3Qxf5/UstupjiWJpHWHZw98Q3JUbQ 6mknuEB/kgi32vwxfj9gZHtBv22KvuVPmGMxo2H4IqkIt58t9BLieAYSiN2jhh/6oSbd wuiYKFFaH1qxqS+xcDQJtZtZikOrO3sNsaEhYiZLQwBCD3io3T1itMc1QRT0PJ3RpFnn NHCs0HpjUUILAIv+voGbKtsJjUvSHLGmO/rNglIYCemxiD4K8f57snDNPzfPU7cz/07L OQ5Q== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@alien8.de header.s=dkim header.b=iNWiwo0a; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=alien8.de Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id h4-20020a654804000000b0043afcda38afsi18988738pgs.417.2022.09.26.12.02.15; Mon, 26 Sep 2022 12:02:31 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@alien8.de header.s=dkim header.b=iNWiwo0a; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=alien8.de Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231325AbiIZSMm (ORCPT + 99 others); Mon, 26 Sep 2022 14:12:42 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:52424 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231313AbiIZSMT (ORCPT ); Mon, 26 Sep 2022 14:12:19 -0400 Received: from mail.skyhub.de (mail.skyhub.de [IPv6:2a01:4f8:190:11c2::b:1457]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id A2A191EAFB for ; Mon, 26 Sep 2022 11:00:01 -0700 (PDT) Received: from zn.tnic (p200300ea9733e74d329c23fffea6a903.dip0.t-ipconnect.de [IPv6:2003:ea:9733:e74d:329c:23ff:fea6:a903]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.skyhub.de (SuperMail on ZX Spectrum 128k) with ESMTPSA id 349A81EC01CE; Mon, 26 Sep 2022 19:59:55 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=alien8.de; s=dkim; t=1664215195; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:in-reply-to:in-reply-to: references:references; bh=aaQPbG0xc8cO8CY+sDVDBPoIq1DASoXAvqG8pMdSfu4=; b=iNWiwo0aB86gJNicJ8bbb5zo1rLFMMbpHq9XPRP04SBXnroKgkd1G2sC3NBPuFsklzNEKf Oh6mu9ITQZGbpkQXB48T0xEO2R8Qy4HnxgoGsPvjRr+66+7XVto7p8AAyV+wP1To+Z0obi fc9GmAw6X+XIp0gu/P6ZkY4OxXDyGN0= Date: Mon, 26 Sep 2022 19:59:50 +0200 From: Borislav Petkov To: "H. Peter Anvin" Cc: Li Zetao , tglx@linutronix.de, mingo@redhat.com, dave.hansen@linux.intel.com, x86@kernel.org, brijesh.singh@amd.com, michael.roth@amd.com, venu.busireddy@oracle.com, linux-kernel@vger.kernel.org Subject: Re: [PATCH -next] x86/sev: Remove unused variable "err" in enforce_vmpl0() Message-ID: References: <20220923113209.3046960-1-lizetao1@huawei.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Sep 26, 2022 at 10:52:08AM -0700, H. Peter Anvin wrote: > The boot code really needs to be refactored, especially that the > real-mode BIOS code is built in the root of that tree. You're going to have to expand on that a bit and give more details as to what do you mean exactly. I think you mean arch/x86/realmode/ but I'm not sure... Thx. -- Regards/Gruss, Boris. https://people.kernel.org/tglx/notes-about-netiquette