Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Mon, 26 Sep 2022 11:01:04 -0700
From:   Ira Weiny <ira.weiny@intel.com>
To:     Bo Liu <liubo03@inspur.com>
CC:     <dan.j.williams@intel.com>, <vishal.l.verma@intel.com>,
        <dave.jiang@intel.com>, <nvdimm@lists.linux.dev>,
        <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] dax: Remove usage of the deprecated ida_simple_xxx API
Message-ID: <YzHo4JOZ3wF57vLS@iweiny-desk3>
References: <20220926012635.3205-1-liubo03@inspur.com>
Content-Type: text/plain; charset="us-ascii"
Content-Disposition: inline
In-Reply-To: <20220926012635.3205-1-liubo03@inspur.com>
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?OZFXdyu81/+PIAt9Ax7JIJaNK/DosWJBnmL3vVwrcKb1IY/+qPkpq8g201wq?=
 =?us-ascii?Q?0qJxbARuTFazUVf9UfjEuhS+JEwcKX2Z1AoiD7ELL4nNi97J0xqre8RyUnB8?=
 =?us-ascii?Q?ns+pi4X4v5Poiu649C40VmMVlwYdkccfO0wsUiesIAz5/WSxv3pZxznoRVFA?=
 =?us-ascii?Q?mHLtBxPvbIicFMNf1dNKgOmFjnLjK3N1B2lRwJvH/cR6xxin99iNWPXOY5dQ?=
 =?us-ascii?Q?dM25/3ENBnFTViusYizhEXQnETg0y2T5cu6Ry8NVwFl+TnzP9DufeFQ3Ka4g?=
 =?us-ascii?Q?7391dhK3Tt38b1vZO43LlMYjYIhMrRG2KUEIYPO7Rqe1d4M+cvqDd4Y1+2rx?=
 =?us-ascii?Q?LU8MoBmgVU/cZmuqhTLpLrkl8enh+rAPzvQQnz5s2WF514t6FQEfIc43fU4H?=
 =?us-ascii?Q?wqfGHx/bV+cjSp7jl+uFV4cvJ0GHjbrYXUCKkX8HVJeAqjeCXRrYEIYLV8sS?=
 =?us-ascii?Q?jT3o+DR6ixikeVi59z9rL0rSQSz9GCpxbcKy0BFnSQMUjdIiu0Xi/whjdgdG?=
 =?us-ascii?Q?icibgjWI3Rfxir7VAqN8JbIBi1I7ny+3Y/F/xdmMeDnOkvnzfmHAnrJjV8/8?=
 =?us-ascii?Q?4WDT++hN35SKlP9iWHF9OSwTX30LUT3HXJfPu8ncKH5rcTz2vkPNaBXyolEa?=
 =?us-ascii?Q?RRqFqTry+H+9g3FrzOZ1HlS3THOMaL4yC/MRlrTwMUzPgGH4EQtAHLxDeJ7Y?=
 =?us-ascii?Q?kB6anEb+0xRUvGiqUSFk06FajeK4HG5Hxjjkbr0DCnr9gBaaB9H9PJWcjMiB?=
 =?us-ascii?Q?7Q9l3SQHwIeyPnSwMs18Vaib3NtifvbZU0gfEVTTVYZaLt8VRdTTXnUBGZcF?=
 =?us-ascii?Q?mSK+P93tWImFBMX5DXLdoWNs3WIAk9FKUr2mr7L8/C3kfPdG9VhpPK5Ray+Z?=
 =?us-ascii?Q?AV/QtF/wyMCZ6+iKk3S4UwjpZ4p+hqfmAaUYDv1t5YPEkMcDbqQSWiqN0oD6?=
 =?us-ascii?Q?UQHiutS6/ovtBhSmfIKYhdK2/vKdMgJrOk4Vh7UDc9jOyZp/6F0QFaUTL5ao?=
 =?us-ascii?Q?b49xW1wQL4UkWOpp68CyG8ucoujgj08ImBFJ9eN2jxKy7Rc0GSl9Ictf5mcN?=
 =?us-ascii?Q?AhYJl2ZQ1QuewD5Unz86k/dQ1oVNBwOgSVuJWstpi8+mUNDLRXjxsaQqH4Z0?=
 =?us-ascii?Q?LMOlFUuhsq0HgJBrdt1JamqA5nkg8wET+d8QJNJSwVZ7bMFCgo2rRUB7zOCC?=
 =?us-ascii?Q?Rw3jOA7azSe0BQ7+AQ5I2d8CoATK0MIYP40cQDn+cYBzIs8AfOsWPhqUoXn3?=
 =?us-ascii?Q?DNjTG0KR98zDV0RwcQS/Q65tIu5mD1c+i6l2p5frbXLZcwRwggrCZArZ6IPP?=
 =?us-ascii?Q?UslWKJe7HOSCHH/QuuDPxg+CdQvi8u5fajoQU0u4/xu+FYQSn3jqkbJ9a4UL?=
 =?us-ascii?Q?a+ZkhwlWtmRKvIT9HSOVODGISuZZdPyAwad920cQSpy/N62LUGacOLtZ+xfg?=
 =?us-ascii?Q?iYyMt1RhBDO29IlnGWw7lHKjBS9GSl8TxrG35gj7+y8RPtMIOq7giSasSFkw?=
 =?us-ascii?Q?hC7KA0MFp8PDd/wr59o3bNmzFWzvV7ZYYBUjNSx4WuxwwUn7u2n9v6k5mzio?=
 =?us-ascii?Q?9wxHc0MtbL2z94iF8nVFsQvJPpOg+J95/+dOVHGm?=
X-MS-Exchange-CrossTenant-Network-Message-Id: 13a4cd30-4a29-4126-cef4-08da9fe91750
X-MS-Exchange-CrossTenant-AuthSource: SA1PR11MB6733.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 26 Sep 2022 18:01:09.4808
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: +YreBaKbfxq5vqdbCjDu4cVBV+O7wrfLN3kyFvLVBA7AHxnIVss1esKJ87E8WjQEm2FWYs/HqagRsEE0TfmVQg==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: IA0PR11MB7308
X-OriginatorOrg: intel.com
X-Spam-Status: No, score=-4.5 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,
        DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_MED,
        SPF_HELO_NONE,SPF_NONE autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Sun, Sep 25, 2022 at 09:26:35PM -0400, Bo Liu wrote:
> Use ida_alloc_xxx()/ida_free() instead of
> ida_simple_get()/ida_simple_remove().
> The latter is deprecated and more verbose.
> 
> Signed-off-by: Bo Liu <liubo03@inspur.com>

Reviewed-by: Ira Weiny <ira.weiny@intel.com>

> ---
>  drivers/dax/super.c | 6 +++---
>  1 file changed, 3 insertions(+), 3 deletions(-)
> 
> diff --git a/drivers/dax/super.c b/drivers/dax/super.c
> index 9b5e2a5eb0ae..da4438f3188c 100644
> --- a/drivers/dax/super.c
> +++ b/drivers/dax/super.c
> @@ -363,7 +363,7 @@ static void dax_free_inode(struct inode *inode)
>  {
>  	struct dax_device *dax_dev = to_dax_dev(inode);
>  	if (inode->i_rdev)
> -		ida_simple_remove(&dax_minor_ida, iminor(inode));
> +		ida_free(&dax_minor_ida, iminor(inode));
>  	kmem_cache_free(dax_cache, dax_dev);
>  }
>  
> @@ -445,7 +445,7 @@ struct dax_device *alloc_dax(void *private, const struct dax_operations *ops)
>  	if (WARN_ON_ONCE(ops && !ops->zero_page_range))
>  		return ERR_PTR(-EINVAL);
>  
> -	minor = ida_simple_get(&dax_minor_ida, 0, MINORMASK+1, GFP_KERNEL);
> +	minor = ida_alloc_max(&dax_minor_ida, MINORMASK, GFP_KERNEL);
>  	if (minor < 0)
>  		return ERR_PTR(-ENOMEM);
>  
> @@ -459,7 +459,7 @@ struct dax_device *alloc_dax(void *private, const struct dax_operations *ops)
>  	return dax_dev;
>  
>   err_dev:
> -	ida_simple_remove(&dax_minor_ida, minor);
> +	ida_free(&dax_minor_ida, minor);
>  	return ERR_PTR(-ENOMEM);
>  }
>  EXPORT_SYMBOL_GPL(alloc_dax);
> -- 
> 2.27.0
> 
>