Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
MIME-Version: 1.0
References: <20220923063533.239315-1-ye.xingchen@zte.com.cn> <YzGo2o3bVLnOiQJr@maple.lan>
In-Reply-To: <YzGo2o3bVLnOiQJr@maple.lan>
From:   Han Jingoo <jingoohan1@gmail.com>
Date:   Mon, 26 Sep 2022 11:49:30 -0700
Message-ID: <CAPOBaE7sMPR9YgfLV2Y12E=jxO72PhOzJ=G=tdTkN-Af1CMuRA@mail.gmail.com>
Subject: Re: [PATCH linux-next] backlight: lp8788: use sysfs_emit() to instead
 of scnprintf()
To:     Daniel Thompson <daniel.thompson@linaro.org>
Cc:     cgel.zte@gmail.com, lee@kernel.org, deller@gmx.de,
        dri-devel@lists.freedesktop.org, linux-fbdev@vger.kernel.org,
        linux-kernel@vger.kernel.org, ye xingchen <ye.xingchen@zte.com.cn>
Content-Type: text/plain; charset="UTF-8"
Precedence: bulk

On Mon, Sep 26, 2022 Daniel Thompson <daniel.thompson@linaro.org> wrote:
>
> On Fri, Sep 23, 2022 at 06:35:33AM +0000, cgel.zte@gmail.com wrote:
> > From: ye xingchen <ye.xingchen@zte.com.cn>
> >
> > Replace the open-code with sysfs_emit() to simplify the code.
> >
> > Signed-off-by: ye xingchen <ye.xingchen@zte.com.cn>
> > ---
> >  drivers/video/backlight/lp8788_bl.c | 2 +-
>
> This one has the subject right and is a good change. However I'd still
> prefer it as a single patchset that fixes *all* instances of this code
> pattern.

Yes, I agree with Daniel's opinion.

Xingchen,
Please make a "Single" patch for including "ALL" fixes
for this pattern in the 'drivers/video/backlight' directory.
Thank you.

Best regards,
Jingoo Han

>
>
> Daniel.