Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Mon, 26 Sep 2022 20:16:39 +0100
From:   Arnaldo Carvalho de Melo <acme@kernel.org>
To:     Leo Yan <leo.yan@linaro.org>
Cc:     Namhyung Kim <namhyung@kernel.org>, Ingo Molnar <mingo@redhat.com>,
        Mark Rutland <mark.rutland@arm.com>,
        Alexander Shishkin <alexander.shishkin@linux.intel.com>,
        Jiri Olsa <jolsa@kernel.org>,
        Adrian Hunter <adrian.hunter@intel.com>,
        linux-perf-users <linux-perf-users@vger.kernel.org>,
        linux-kernel <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] perf record: Fix segmentation fault in
 record__read_lost_samples()
Message-ID: <YzH6lxeZ2KYfK6lx@kernel.org>
References: <20220924113346.1110909-1-leo.yan@linaro.org>
 <CAM9d7ci2RJOTz08eGRgLMVpS0TmwN=q=UNA_Z3wbSHCC2pMygQ@mail.gmail.com>
 <YzGiMdIRRE8ibCiD@kernel.org>
 <YzG9Mz8t6aNn1ZwX@leoy-huanghe.lan>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <YzG9Mz8t6aNn1ZwX@leoy-huanghe.lan>
Precedence: bulk

Em Mon, Sep 26, 2022 at 10:54:43PM +0800, Leo Yan escreveu:
> On Mon, Sep 26, 2022 at 01:59:29PM +0100, Arnaldo Carvalho de Melo wrote:
> 
> [...]
> 
> > > > Fixes: a49aa8a54e86 ("perf record: Read and inject LOST_SAMPLES events")
> > > > Signed-off-by: Leo Yan <leo.yan@linaro.org>
> > > 
> > > Thanks for the fix and sorry for the inconvenience.
> > > Actually I sent the same fix a few weeks ago.
> > > 
> > > https://lore.kernel.org/r/20220909235024.278281-1-namhyung@kernel.org
> > 
> > collecting it now, and adding that Fixes from Leo's patch, ok?
> 
> Yeah, I think it's good to add Fixes tag.  Just remind, actually
> Namhyung has mentioned Fixed tag in above link:
> 
> "I didn't add a Fixes tag as it's not sent to Linus yet. But in case you want it.
> 
>   Fixes: a49aa8a54e86 ("perf record: Read and inject LOST_SAMPLES events")
> "

I'll add it.

Sometimes I think about combining fixes with patches in my tree that
didn't made it into Linus tree yet, so that we avoid having problems
with 'git bisect', but I also try not to rebase acme/perf/core.

Perhaps in the future 'git bisect' will look at Fixes: tags :-)

- Arnaldo