Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
From:   Sean Anderson <sean.anderson@seco.com>
To:     "David S . Miller" <davem@davemloft.net>,
        Jakub Kicinski <kuba@kernel.org>,
        Madalin Bucur <madalin.bucur@nxp.com>,
        Camelia Alexandra Groza <camelia.groza@nxp.com>,
        netdev@vger.kernel.org
Cc:     Eric Dumazet <edumazet@google.com>,
        Paolo Abeni <pabeni@redhat.com>,
        linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org,
        Russell King <linux@armlinux.org.uk>,
        "linuxppc-dev @ lists . ozlabs . org" <linuxppc-dev@lists.ozlabs.org>,
        Sean Anderson <sean.anderson@seco.com>
Subject: [PATCH net-next v5 4/9] net: fman: memac: Add serdes support
Date:   Mon, 26 Sep 2022 15:03:16 -0400
Message-Id: <20220926190322.2889342-5-sean.anderson@seco.com>
In-Reply-To: <20220926190322.2889342-1-sean.anderson@seco.com>
References: <20220926190322.2889342-1-sean.anderson@seco.com>
Content-Transfer-Encoding: 8bit
Content-Type: text/plain
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?Um0qXIKrszPfmbJeQUOxyEL8fc9bl1WULt3R9d6Gp7H+XW+i/KyXYmZbQVC2?=
 =?us-ascii?Q?u3h8mkrCqIRcIRoOsKFqDM9MTufQq1dVt8nyUIV03SzJYrx9AuB4ruBo/nal?=
 =?us-ascii?Q?mvFj30tecfuv1720XV3t1Yynw5B7TnUu0YA/H/rgGsEy4Pa+kq+1omGOHI1r?=
 =?us-ascii?Q?XCHCfeo034nfxyW4q4mcqAU06qSTXLbZW4CRjZ1FUw0D4MPHG1DzvzKP4J2A?=
 =?us-ascii?Q?pFz3m3+fxXO32qvC6RqlSUoLUFFiKanTyx04se/5QepzvW3eUMBIkQgBFHEU?=
 =?us-ascii?Q?F/0vHyQnRz/2ZCN7X1bH7lU9F3X7T6pkmKWk5vRTiooCPjyK35iJFepR4KJ/?=
 =?us-ascii?Q?/3JnKlOa18ihsfVqPRT/hR9fXPCDuuXwwQ1L78tUsDqFqEaRWkaO/IzmW+SD?=
 =?us-ascii?Q?jQrZ9c5OTeVD+t4mBawZ2S6CjnYR/uR7RIeR3pwVEizWsXs4smXyksZLoQoK?=
 =?us-ascii?Q?8QAtY5wyFFNVXe/82gg09ln9R6ziWedBTNdDIdxg1+6DmB55uU0jSgATePXF?=
 =?us-ascii?Q?Avpr7l5ila7jPGifhj8S4Pfd0+bfAgRWhAlVynU3jxg6Fe5k4NEBI5NdFoTb?=
 =?us-ascii?Q?+ALPVnYjwC2UdfLu1eJfosDxloHviepfL1bl7rwgQmpvsvymUzaR+qv5AU3+?=
 =?us-ascii?Q?r6leLTY3Au/FU+Mbezor72qHKIsaHnDprt2kgxFnV4QCZwJWz1zpu18tjKL0?=
 =?us-ascii?Q?ffpwkVlKkwtytpCJSuAE6116HN+Lek7cSY1wAnFvH19MxTvkHvrJXV7ptm9d?=
 =?us-ascii?Q?POKFzUl+FvhL//XCqNdj7ZFv96nGXTSYf//npRrmf5Cz6Y39LmXCzkbMNGkn?=
 =?us-ascii?Q?VNY06DHq3HmyuAFM4JviuX/5HBpU9DpjfrY2vs/RN5ak6ZH8g5wACmedCvjq?=
 =?us-ascii?Q?fiD6edvDim2qSGbjmhhSLT+JPGMcl4RMTAFlyLcgD2xmZkLBtiw9ftnSHKUz?=
 =?us-ascii?Q?H/TTijxLkRc8DJyq5N01B/nQ40ImDU2DEd8dwSs4mjUGoeSc9udnH8dvE/KE?=
 =?us-ascii?Q?/lVdK9o9zDOCgVe7iKqOepiYpOB7ukWDbHTEFjwlkyUX1zgrrciWW69X39d5?=
 =?us-ascii?Q?vdsKUqm2a6DJFdEqPR0frcV6e4n6yYS/ZMcipOB8mW9Bk6Ssv1WjVlViC/8G?=
 =?us-ascii?Q?9G23mZ6MEHsoSyE+k2HUGi3RYraWR9EUwgj0ge9C6XmLfjTLSzO43/K8Ud3C?=
 =?us-ascii?Q?obaN4WySHSkIkhYfko3EQN6u9Z/UBLRejQ81u8zy+NsG71nIUTbg9k+cVBg+?=
 =?us-ascii?Q?QGlzqm32ngJWTtu6kUnwbwTSqFI6VEZefmAPZvSNa15IJu7pVYo78inPqbp4?=
 =?us-ascii?Q?gSTRz85dt5t1aWu8+keDgNZkuGMFO3HtTJ7qha29GljH8WK7IafAqRTdf4yV?=
 =?us-ascii?Q?m/BBUOQYNYWM2RJsNunhBdVWN4xDgO1Z53ZIyMTYmXp8TEf8zPxkJ5HtQD8u?=
 =?us-ascii?Q?D/vH0QLCdcJjccypPXv2M32r/A+mqB9b56hCrCZCnQdlUbwfPwjX8Dvyocge?=
 =?us-ascii?Q?OdU23tabnuw1Xl4d0tIu6lax6sJh6HkFrS+gteZTeo7wMFpxpjO9dmWi9TTq?=
 =?us-ascii?Q?fMN/MUkK0d1zW4xq1QMf+sEmhKGQALYvzsU3VWkBKAltS3AQlXXkh4PARfCD?=
 =?us-ascii?Q?Tg=3D=3D?=
X-OriginatorOrg: seco.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 004b2d87-e84b-4da8-d933-08da9ff1d221
X-MS-Exchange-CrossTenant-AuthSource: DB7PR03MB4972.eurprd03.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 26 Sep 2022 19:03:38.8652
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: bebe97c3-6438-442e-ade3-ff17aa50e733
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: UrdgqBgQbyG4csQBqxKWVnRIp96OFwKsoiZYZHFtDUYP502IylmaUvkaV/KRoo7lgghjTWmxR5BGRxWplivhLg==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: PAWPR03MB9246
X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE,
        RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_PASS autolearn=ham
        autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

This adds support for using a serdes which has to be configured. This is
primarly in preparation for the next commit, which will then change the
serdes mode dynamically.

Signed-off-by: Sean Anderson <sean.anderson@seco.com>
---

(no changes since v4)

Changes in v4:
- Don't fail if phy support was not compiled in

 .../net/ethernet/freescale/fman/fman_memac.c  | 49 ++++++++++++++++++-
 1 file changed, 47 insertions(+), 2 deletions(-)

diff --git a/drivers/net/ethernet/freescale/fman/fman_memac.c b/drivers/net/ethernet/freescale/fman/fman_memac.c
index 32d26cf17843..56a29f505590 100644
--- a/drivers/net/ethernet/freescale/fman/fman_memac.c
+++ b/drivers/net/ethernet/freescale/fman/fman_memac.c
@@ -13,6 +13,7 @@
 #include <linux/io.h>
 #include <linux/phy.h>
 #include <linux/phy_fixed.h>
+#include <linux/phy/phy.h>
 #include <linux/of_mdio.h>
 
 /* PCS registers */
@@ -324,6 +325,7 @@ struct fman_mac {
 	void *fm;
 	struct fman_rev_info fm_rev_info;
 	bool basex_if;
+	struct phy *serdes;
 	struct phy_device *pcsphy;
 	bool allmulti_enabled;
 };
@@ -1203,17 +1205,56 @@ int memac_initialization(struct mac_device *mac_dev,
 		}
 	}
 
+	memac->serdes = devm_of_phy_get(mac_dev->dev, mac_node, "serdes");
+	err = PTR_ERR(memac->serdes);
+	if (err == -ENODEV || err == -ENOSYS) {
+		dev_dbg(mac_dev->dev, "could not get (optional) serdes\n");
+		memac->serdes = NULL;
+	} else if (IS_ERR(memac->serdes)) {
+		dev_err_probe(mac_dev->dev, err, "could not get serdes\n");
+		goto _return_fm_mac_free;
+	} else {
+		err = phy_init(memac->serdes);
+		if (err) {
+			dev_err_probe(mac_dev->dev, err,
+				      "could not initialize serdes\n");
+			goto _return_fm_mac_free;
+		}
+
+		err = phy_power_on(memac->serdes);
+		if (err) {
+			dev_err_probe(mac_dev->dev, err,
+				      "could not power on serdes\n");
+			goto _return_phy_exit;
+		}
+
+		if (memac->phy_if == PHY_INTERFACE_MODE_SGMII ||
+		    memac->phy_if == PHY_INTERFACE_MODE_1000BASEX ||
+		    memac->phy_if == PHY_INTERFACE_MODE_2500BASEX ||
+		    memac->phy_if == PHY_INTERFACE_MODE_QSGMII ||
+		    memac->phy_if == PHY_INTERFACE_MODE_XGMII) {
+			err = phy_set_mode_ext(memac->serdes, PHY_MODE_ETHERNET,
+					       memac->phy_if);
+			if (err) {
+				dev_err_probe(mac_dev->dev, err,
+					      "could not set serdes mode to %s\n",
+					      phy_modes(memac->phy_if));
+				goto _return_phy_power_off;
+			}
+		}
+	}
+
 	if (!mac_dev->phy_node && of_phy_is_fixed_link(mac_node)) {
 		struct phy_device *phy;
 
 		err = of_phy_register_fixed_link(mac_node);
 		if (err)
-			goto _return_fm_mac_free;
+			goto _return_phy_power_off;
 
 		fixed_link = kzalloc(sizeof(*fixed_link), GFP_KERNEL);
 		if (!fixed_link) {
 			err = -ENOMEM;
-			goto _return_fm_mac_free;
+			goto _return_phy_power_off;
 		}
 
 		mac_dev->phy_node = of_node_get(mac_node);
@@ -1242,6 +1283,10 @@ int memac_initialization(struct mac_device *mac_dev,
 
 	goto _return;
 
+_return_phy_power_off:
+	phy_power_off(memac->serdes);
+_return_phy_exit:
+	phy_exit(memac->serdes);
 _return_fixed_link_free:
 	kfree(fixed_link);
 _return_fm_mac_free:
-- 
2.35.1.1320.gc452695387.dirty