Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Mon, 26 Sep 2022 22:04:21 +0200
From:   Andrew Lunn <andrew@lunn.ch>
To:     Rob Herring <robh@kernel.org>
Cc:     Pali =?iso-8859-1?Q?Roh=E1r?= <pali@kernel.org>,
        Liam Girdwood <lgirdwood@gmail.com>,
        Mark Brown <broonie@kernel.org>,
        Gregory Clement <gregory.clement@bootlin.com>,
        Sebastian Hesselbarth <sebastian.hesselbarth@gmail.com>,
        Marcin Wojtas <mw@semihalf.com>, alsa-devel@alsa-project.org,
        devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
        linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH 1/5] ASoC: kirkwood: enable Kirkwood driver for Armada
 38x platforms
Message-ID: <YzIFxWq7Kt0SudLz@lunn.ch>
References: <20220920132648.2008-1-pali@kernel.org>
 <20220920132648.2008-2-pali@kernel.org>
 <20220926194832.GA2668987-robh@kernel.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=iso-8859-1
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <20220926194832.GA2668987-robh@kernel.org>
Precedence: bulk

On Mon, Sep 26, 2022 at 02:48:32PM -0500, Rob Herring wrote:
> On Tue, Sep 20, 2022 at 03:26:44PM +0200, Pali Roh?r wrote:
> > From: Marcin Wojtas <mw@semihalf.com>
> > 
> > The audio unit of Marvell Armada38x SoC is similar to the ones comprised by
> > other Marvell SoCs (Kirkwood, Dove and Armada 370). Therefore KW audio
> > driver can be used to support it and this commit adds new compatible string
> > to identify Armada 38x variant.
> > 
> > Two new memory regions are added: first one for PLL configuration and
> > the second one for choosing one of audio I/O modes (I2S or S/PDIF).
> > For the latter purpose a new optional DT property is added ('spdif-mode').
> > 
> > kirkwood-i2s driver is extended by adding a new init function for Armada
> > 38x flavor and also a routine that enables PLL output (i.e. MCLK)
> > configuration.
> > 
> > Signed-off-by: Marcin Wojtas <mw@semihalf.com>
> > Tested-by: Star_Automation <star@marvell.com>
> > Reviewed-by: Nadav Haklai <nadavh@marvell.com>
> > Reviewed-by: Lior Amsalem <alior@marvell.com>
> > Tested-by: Lior Amsalem <alior@marvell.com>
> > Signed-off-by: Hezi Shahmoon <hezi@marvell.com>
> > Reviewed-by: Neta Zur Hershkovits <neta@marvell.com>
> > [pali: Fix support for pre-38x SoCs]
> > Signed-off-by: Pali Roh?r <pali@kernel.org>
> > ---
> >  .../devicetree/bindings/sound/mvebu-audio.txt |  14 +-
> >  sound/soc/kirkwood/kirkwood-i2s.c             | 136 +++++++++++++++++-
> >  sound/soc/kirkwood/kirkwood.h                 |   2 +
> >  3 files changed, 149 insertions(+), 3 deletions(-)
> > 
> > diff --git a/Documentation/devicetree/bindings/sound/mvebu-audio.txt b/Documentation/devicetree/bindings/sound/mvebu-audio.txt
> > index cb8c07c81ce4..4f5dec5cb3c2 100644
> > --- a/Documentation/devicetree/bindings/sound/mvebu-audio.txt
> > +++ b/Documentation/devicetree/bindings/sound/mvebu-audio.txt
> > @@ -6,9 +6,14 @@ Required properties:
> >    "marvell,kirkwood-audio" for Kirkwood platforms
> >    "marvell,dove-audio" for Dove platforms
> >    "marvell,armada370-audio" for Armada 370 platforms
> > +  "marvell,armada-380-audio" for Armada 38x platforms
> 
> Perhaps be consistent with the 370 string above it.

Hi Rob

That was something i also considered. But actually, all 380
compatibles use armada-380-FOOBAR. So this is inconsistent with
armada370-audio, but consistent with armada-380 in general.

	 Andrew