Received: by 2002:a05:6359:c8b:b0:c7:702f:21d4 with SMTP id go11csp42822rwb; Mon, 26 Sep 2022 14:27:13 -0700 (PDT) X-Google-Smtp-Source: AMsMyM5aBemE5RisBsDsACjVrHjFWniNIM3vw+vgnSEb+150thxoGMFsAwwOlgHZsXxeOnAXMFPq X-Received: by 2002:a05:6402:51cb:b0:451:6ede:88e3 with SMTP id r11-20020a05640251cb00b004516ede88e3mr24161768edd.45.1664227632795; Mon, 26 Sep 2022 14:27:12 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1664227632; cv=none; d=google.com; s=arc-20160816; b=tFRtBiQ3Xpwl3ryW5onL7uQ8kAa2NLis/Me9kkycKsK075pU3bCAJ4mUOboGtoBQrC 7PZFHB7xYE4pdjadkKSRmpB48tATtoP0JN+55qd0tPoduTC7LMl5HYQ2adp4pCz/z1H0 eRMSaRTln28jcNyShXxth2aNY/ESEr0nsBo7nq0WU/+lxFV+72pgIp5xpyw/QoOvh8ll PvL10x0RiEqqz7MyjRMBboSBMvv/630oGPTjwAZ+UaERaWfeMkBS57pPofTOJ3HSQDRk Bw2chDNLn2lyd/+P5luMzIGF5rrdV4TULzjvLiYEE6SwMa7zsyMRJwhslzbklSPsHdEn QIYQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date:dkim-signature; bh=O4LMN3S2OFxEuL98rqNj8vUSOAZXBDFs/bg9a/ub9fA=; b=VTXdG0Z/0Ss0FH09NXMiqcIvpQjJ3LVngr0DDkqmK0I2yKzdLFB5CeQ9aMOxKMrHkh SKZ3ymPN6fptmjZjdAK2oAelRKAbmFYq8c/6g6iuMmykVbX4bp3Tsw7rTCLmSfqYrLeK pmneweU5bIR1tglpJxemTVjJl8mYEdE2DrxD6nje1uB+SkPuFgoNhbtk0+jHPPNKe4gR FUt9R7HDEpx83NpxbUH2qFrCzMpEIpGeOCcEV94ENZfySuGlcgdx8qyoD0kdZgHpl3gH wB9xxlhEzB2xgUwjO6a/TYc1lCM4qDjYdtFOxD+WiqENPv6aVFEMNYEqLjLaztadtFnB k1xA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@alien8.de header.s=dkim header.b=o4RF8pFN; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=alien8.de Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id i39-20020a0564020f2700b0044dbb9afe1fsi16557582eda.467.2022.09.26.14.26.48; Mon, 26 Sep 2022 14:27:12 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@alien8.de header.s=dkim header.b=o4RF8pFN; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=alien8.de Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231358AbiIZVLl (ORCPT + 99 others); Mon, 26 Sep 2022 17:11:41 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:47630 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231326AbiIZVLh (ORCPT ); Mon, 26 Sep 2022 17:11:37 -0400 Received: from mail.skyhub.de (mail.skyhub.de [IPv6:2a01:4f8:190:11c2::b:1457]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 60CF75A3F9 for ; Mon, 26 Sep 2022 14:11:36 -0700 (PDT) Received: from zn.tnic (p200300ea9733e74d329c23fffea6a903.dip0.t-ipconnect.de [IPv6:2003:ea:9733:e74d:329c:23ff:fea6:a903]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.skyhub.de (SuperMail on ZX Spectrum 128k) with ESMTPSA id 15B201EC026E; Mon, 26 Sep 2022 23:11:30 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=alien8.de; s=dkim; t=1664226690; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:in-reply-to:in-reply-to: references:references; bh=O4LMN3S2OFxEuL98rqNj8vUSOAZXBDFs/bg9a/ub9fA=; b=o4RF8pFNgH5nnML9hM8RFzrcIG5JMloUgd20rtKM9fXBuE6dF57S+p/C5y9y7J0qRj2c0j v1FwO+5n9Q0EBALFCLkpQ9Teoaw84m5E/UWZ3O05GZUkTYo4HfOi856UZIqW5aX54olvan TCm5vkNRC8OUBdzCAR0eJ21WpIqdra4= Date: Mon, 26 Sep 2022 23:11:26 +0200 From: Borislav Petkov To: Juergen Gross Cc: xen-devel@lists.xenproject.org, x86@kernel.org, linux-kernel@vger.kernel.org, Thomas Gleixner , Ingo Molnar , Dave Hansen , "H. Peter Anvin" Subject: Re: [PATCH v3 08/10] x86/mtrr: let cache_aps_delayed_init replace mtrr_aps_delayed_init Message-ID: References: <20220908084914.21703-1-jgross@suse.com> <20220908084914.21703-9-jgross@suse.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20220908084914.21703-9-jgross@suse.com> X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Sep 08, 2022 at 10:49:12AM +0200, Juergen Gross wrote: > -void set_mtrr_aps_delayed_init(void) > -{ > - if (!cache_generic) > - return; > - > - mtrr_aps_delayed_init = true; > -} > - Except that you've removed the accessors and made that bool global. Which is less pretty than it was before... -- Regards/Gruss, Boris. https://people.kernel.org/tglx/notes-about-netiquette