Received: by 2002:a05:6359:c8b:b0:c7:702f:21d4 with SMTP id go11csp58687rwb; Mon, 26 Sep 2022 14:43:36 -0700 (PDT) X-Google-Smtp-Source: AMsMyM4mcK599VD+AjS9SNBy9QyMAe/dXmSEFh/o7QeGkKuVs3ir1oTfv0fCerYYVhLShUfVgBH1 X-Received: by 2002:a05:6a00:2446:b0:528:5da9:cc7 with SMTP id d6-20020a056a00244600b005285da90cc7mr26411577pfj.51.1664228616146; Mon, 26 Sep 2022 14:43:36 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1664228616; cv=none; d=google.com; s=arc-20160816; b=bKshKEOY2EhR1vUqDgFNf6TARKcO2icOQ5ohWJfjSK00r9Xw47cunizcdcqWaChtVH xujCstnV3L7VPCZpvfx/BmD5jAJj39i89/zKsMU0K9QE2pqEtt8wNlWu3FoHHpJ7+qiN uRWHW1DJm95Rfi+UVbWO6DcbgVQBudT10prjYpiYi5FFAD5JtCC6WVf/8oQGxQp1rL3S uGGt6TQz2aDOysCvgPA9za3Q7ZX2aCrXar97DbhhC4jqwaHW0Td4nuM71acvK+aNkYHe vLxpesX/A0zptYI0JD7GKx4XOrlSsC7EG81DKZhVONOzF07znIc9mJvlkw756KmH8P15 jcHA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:subject:cc:to:from:date :dkim-signature; bh=Gcr19OWfD5XtrjDsLPbyq3U/DMZUhJXVejASslQQh64=; b=O4R6t9/D9uM4IXvkZ4HS0QynZ1ksbrYyM2+mDhHF2YOlFkQ/jRqufzbOyYuFYucZOY YRxCGY8xB7NWN72gA3nNvcqyE9Phx2Trc0xiLi8qUN/z2dVemDWyuq1GxzWBwX1ekq8T 0twSnylW5yCdDU6bblCwYxsIsco0JUq0kg/SqU2hqcBaRqf1B7ceUwYDmU41qaMcRdkO 9fngQhjRDr+vBFBDzLWP0dRswBO94mvwK8rPo8o+wAfpAnvT2USC6f975utZRr2zGXEv FrU5Ug0HE8cr0c/wmW3H2yNv5+j8yl8ElDctUEpESxCLdEtG6WASQ4OENzjMGbR4n7N0 /3tA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=PbSei11B; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id n2-20020a170902f60200b0017824e7065csi12275848plg.128.2022.09.26.14.43.23; Mon, 26 Sep 2022 14:43:36 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=PbSei11B; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231159AbiIZUlO (ORCPT + 99 others); Mon, 26 Sep 2022 16:41:14 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:46092 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231197AbiIZUkq (ORCPT ); Mon, 26 Sep 2022 16:40:46 -0400 Received: from ams.source.kernel.org (ams.source.kernel.org [145.40.68.75]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 58CADAB432; Mon, 26 Sep 2022 13:40:33 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id 7EB68B8111B; Mon, 26 Sep 2022 20:40:28 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 1929AC433D6; Mon, 26 Sep 2022 20:40:26 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1664224827; bh=seglhfOiNMrFtc/ni/J5+ETY9FK/ht2gFC/YZWLxHZU=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=PbSei11B61mV/PgvFyJSKsXf4YV/P1/Ost3I4y+1GWEKuzFebR8BJVL65E6y+kDoh pgaU/naJjvS8En8kklC0OYzxOjvYj4T7epxxXb1w3hHaON2Y3HEYrmFOHwsHRCZOJ1 LPUwr2sJal9u+EPfd9CeSTlLGP8C7y4ZrQRqp3lmIm3PWFSphtjm6VhBH9zZz/4Yk2 tB7GhijyTGl04kkxICmK+9E8aOZZnDdrxb94aJPFt71vStkor2i+K6yI+J8uUXzzhw CAAtBRtaF+XnjTkZWc2GF3PIce1yNkHT+6tf3TYUamasnYdcm1tEMBGDwGWX934eGb IitbYJ6kFPEQQ== Date: Mon, 26 Sep 2022 13:40:25 -0700 From: Jakub Kicinski To: Vladimir Oltean Cc: netdev@vger.kernel.org, "David S. Miller" , Eric Dumazet , Paolo Abeni , Xiaoliang Yang , Rui Sousa , Claudiu Manoil , Alexandre Belloni , UNGLinuxDriver@microchip.com, Horatiu Vultur , Andrew Lunn , Vivien Didelot , Florian Fainelli , Michael Walle , Vinicius Costa Gomes , Maxim Kochetkov , Colin Foster , Richie Pearn , Kurt Kanzenbach , Vladimir Oltean , Jesse Brandeburg , Tony Nguyen , Giuseppe Cavallaro , Alexandre Torgue , Jose Abreu , Jamal Hadi Salim , Cong Wang , Jiri Pirko , Gerhard Engleder , linux-kernel@vger.kernel.org Subject: Re: [PATCH v2 net-next 02/12] tsnep: deny tc-taprio changes to per-tc max SDU Message-ID: <20220926134025.5c438a76@kernel.org> In-Reply-To: <20220923163310.3192733-3-vladimir.oltean@nxp.com> References: <20220923163310.3192733-1-vladimir.oltean@nxp.com> <20220923163310.3192733-3-vladimir.oltean@nxp.com> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-7.2 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_HI, SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, 23 Sep 2022 19:33:00 +0300 Vladimir Oltean wrote: > Since the driver does not act upon the max_sdu argument, deny any other > values except the default all-zeroes, which means that all traffic > classes should use the same MTU as the port itself. Don't all the driver patches make you wanna turn this into an opt-in? What are the chances we'll catch all drivers missing the validation in review?