Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <228f2d97-4816-bb37-f834-f9a2db59054a@linaro.org>
Date:   Mon, 26 Sep 2022 23:33:01 +0200
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101
 Thunderbird/91.11.0
Subject: Re: [PATCH v5 29/30] thermal/intel/int340x: Replace parameter to
 simplify
Content-Language: en-US
To:     Nathan Chancellor <nathan@kernel.org>
Cc:     rafael@kernel.org, linux-kernel@vger.kernel.org,
        linux-pm@vger.kernel.org, rui.zhang@intel.com,
        Srinivas Pandruvada <srinivas.pandruvada@linux.intel.com>,
        Amit Kucheria <amitk@kernel.org>,
        Antoine Tenart <atenart@kernel.org>
References: <20220926140604.4173723-1-daniel.lezcano@linaro.org>
 <20220926140604.4173723-30-daniel.lezcano@linaro.org>
 <YzHb50/4njPa1TR1@dev-arch.thelio-3990X>
From:   Daniel Lezcano <daniel.lezcano@linaro.org>
In-Reply-To: <YzHb50/4njPa1TR1@dev-arch.thelio-3990X>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 8bit
Precedence: bulk


Hi Nathan,

On 26/09/2022 19:05, Nathan Chancellor wrote:

[ ... ]

>> +	int34x_thermal_zone->ops = kmemdup(&int340x_thermal_zone_ops,
>> +					   sizeof(int340x_thermal_zone_ops), GFP_KERNEL);
>> +	if (!int34x_thermal_zone->ops)
>> +		goto err_ops_alloc;
> 
> I assume I was cc'd on this change due to my fix up patch:

> https://lore.kernel.org/20220923152009.1721739-1-nathan@kernel.org/

Yes, right, thanks for sending the fix.

> However, I don't see that applied here. I don't mind it being squashed
> in to keep the build as clean as possible through bisects.

Ok, that makes sense, I will merge with the change it fixes

> Additionally, I did a diff of v4 to v5 to apply on top of next-20220923
> and I noticed there were a significant number of places where there was
> whitespace added where it probably should not have been. 

Yeah, my git configuration does always trim the extra whitespaces when 
applying so I usually don't pay attention to that, but thanks for 
letting me know. I've probably something wrong with my emacs indentation 
setup

> Other than
> that, v5 works on all the machines that had issues so thank you for the
> quick fix!

Thanks for testing


-- 
<http://www.linaro.org/> Linaro.org │ Open source software for ARM SoCs

Follow Linaro:  <http://www.facebook.com/pages/Linaro> Facebook |
<http://twitter.com/#!/linaroorg> Twitter |
<http://www.linaro.org/linaro-blog/> Blog