Received: by 2002:a05:6359:c8b:b0:c7:702f:21d4 with SMTP id go11csp91764rwb; Mon, 26 Sep 2022 15:17:26 -0700 (PDT) X-Google-Smtp-Source: AMsMyM7cKVJDyCzuJraLIGQhvjDM4Paax4wL7bD9EEtFtl696iUxqQ6cRUsiw1hgUybUiDpcqZ0P X-Received: by 2002:a17:906:8a6f:b0:780:96b4:d19e with SMTP id hy15-20020a1709068a6f00b0078096b4d19emr20142143ejc.624.1664230645768; Mon, 26 Sep 2022 15:17:25 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1664230645; cv=none; d=google.com; s=arc-20160816; b=HhiPbbXpyNBSyl8TjwpmHEZg6wBxnMB0Dx20C75cHnXDvLPOJ9Jx5nyII8QTUqbdgk nvDYSdROtjaobBs/+7mXFXg0OjnWkkkuSXFUDhzeHetQjwXw4z1Gj6+Izg32PCiQ66R9 PbcbXpFObBCgpGSZvPrYbAC8LVne9QrRJ6wcqo+kd+iOSMawRAavaq9a5tqyM7Keg39U b1GetcXZMw4Nro25Bqkb8GnscyPVkdTbxFdvlwd9PFJZ1NwL3xNgZYEOw6N7MeUluFSy HiMBZZ/xt9fBleOQwceAhgyGmAuJTTqT4A+8SWrR5mw20QpSpuLnWKuAix/NtfX7LfVV ZA8w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:user-agent:in-reply-to:content-disposition :mime-version:references:message-id:subject:cc:to:from:date :dkim-signature; bh=f2oVW5cv920HtluzlojR1Lmu74tSl8qrPKw3Uc0zNRA=; b=TM9Q05BwDjhzH3dmyagIRds4JhBmpxKDolTUT6Vv91EVoSvX9YLFk42uhuWc47V5fG Rq7b/rUptpweTLVHWDqP+Q8cBPsHF190+wYhtYdJYTAAmxW3jCpHymnOPhPaYDJwPdIb tT3wqNMMDNR3DNbOWMXQO8y8cLlVrEHyMTPDLKJ1Nx4KWc61O19OEqpsY0m1HqWxMl5A IF0tt+CtWzoTe7E32kNTdQX+qAwSRrRWa36BKilqjvg6oXEyZbA2yJO/NLAmBwzHO68d jI+xLTNrouPcQkHT4YanTRG+hG2yrKDN8XC8mibEDJqFvSEmU3F7USFBi4dCp0DKOhOF rH6w== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@quicinc.com header.s=qcppdkim1 header.b=XtRrgQJi; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=quicinc.com Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id ht9-20020a170907608900b0078196f01747si724554ejc.768.2022.09.26.15.17.00; Mon, 26 Sep 2022 15:17:25 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@quicinc.com header.s=qcppdkim1 header.b=XtRrgQJi; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=quicinc.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231274AbiIZVes (ORCPT + 99 others); Mon, 26 Sep 2022 17:34:48 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:37376 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231174AbiIZVeo (ORCPT ); Mon, 26 Sep 2022 17:34:44 -0400 Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 30B281183F; Mon, 26 Sep 2022 14:34:43 -0700 (PDT) Received: from pps.filterd (m0279873.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.17.1.5/8.17.1.5) with ESMTP id 28QLMLlw026751; Mon, 26 Sep 2022 21:34:15 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=quicinc.com; h=date : from : to : cc : subject : message-id : references : mime-version : content-type : in-reply-to; s=qcppdkim1; bh=f2oVW5cv920HtluzlojR1Lmu74tSl8qrPKw3Uc0zNRA=; b=XtRrgQJiv2OAKKUVLos7UsrYBHpfrT+ifm4SLHdo/kqgMtD7NEAiK04ow7VbFtLjWaUX /SFaOFYKIVxlmTKfK8fF3ti7hcd8Ur/8fudeQO20duxa1LpEbQHqj3l++/DdS4BgsUzH 4XJAcWbUQyM/yiHg5k5PC+qu0wrYIs+uo+WSAIzWZQvFn0xri7MnHRgDZAj8bP1dk7K6 3a1D+OICEIiY0VXBYWfWTTsgIQ6u4k2aQ2jA11+HM1pzF7n9/G7Q9cJlV8LiZ/dnExBL MPYGx+2l9TVapbd5UiO7eExBUGo7YGVEmmcY9doq8ZxNUuld0s0kKK+Zb7oPi0rD1a1Y cg== Received: from nasanppmta05.qualcomm.com (i-global254.qualcomm.com [199.106.103.254]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 3jsq8vmufa-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Mon, 26 Sep 2022 21:34:14 +0000 Received: from nasanex01a.na.qualcomm.com ([10.52.223.231]) by NASANPPMTA05.qualcomm.com (8.17.1.5/8.17.1.5) with ESMTPS id 28QLYD49032298 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Mon, 26 Sep 2022 21:34:13 GMT Received: from asutoshd-linux1.qualcomm.com (10.80.80.8) by nasanex01a.na.qualcomm.com (10.52.223.231) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.986.29; Mon, 26 Sep 2022 14:34:13 -0700 Date: Mon, 26 Sep 2022 14:34:13 -0700 From: Asutosh Das To: Avri Altman CC: "mani@kernel.org" , "quic_nguyenb@quicinc.com" , "quic_xiaosenh@quicinc.com" , "quic_cang@quicinc.com" , "quic_nitirawa@quicinc.com" , "quic_rampraka@quicinc.com" , "quic_richardp@quicinc.com" , "stanley.chu@mediatek.com" , "adrian.hunter@intel.com" , "bvanassche@acm.org" , "beanhuo@micron.com" , "martin.petersen@oracle.com" , "linux-scsi@vger.kernel.org" , Alim Akhtar , "James E.J. Bottomley" , Matthias Brugger , open list , "moderated list:ARM/Mediatek SoC support" , "moderated list:ARM/Mediatek SoC support" Subject: Re: [PATCH v1 02/16] ufs: core: Introduce Multi-circular queue capability Message-ID: <20220926213413.GD15228@asutoshd-linux1.qualcomm.com> References: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii"; format=flowed Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.24 (2015-08-30) X-Originating-IP: [10.80.80.8] X-ClientProxiedBy: nasanex01b.na.qualcomm.com (10.46.141.250) To nasanex01a.na.qualcomm.com (10.52.223.231) X-QCInternal: smtphost X-Proofpoint-Virus-Version: vendor=nai engine=6200 definitions=5800 signatures=585085 X-Proofpoint-GUID: 5dXhM2cb4YyM6u6yv3C-R1bycUFppWH2 X-Proofpoint-ORIG-GUID: 5dXhM2cb4YyM6u6yv3C-R1bycUFppWH2 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.205,Aquarius:18.0.895,Hydra:6.0.528,FMLib:17.11.122.1 definitions=2022-09-26_09,2022-09-22_02,2022-06-22_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 impostorscore=0 clxscore=1015 adultscore=0 mlxscore=0 mlxlogscore=999 spamscore=0 priorityscore=1501 suspectscore=0 phishscore=0 malwarescore=0 lowpriorityscore=0 bulkscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2209130000 definitions=main-2209260132 X-Spam-Status: No, score=-2.8 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_LOW,SPF_HELO_NONE, SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sat, Sep 24 2022 at 01:14 -0700, Avri Altman wrote: >> >> + hba->mcq_sup = (hba->capabilities & MASK_MCQ_SUPPORT) >> >> MCQ_SUPP_SHIFT; >Since you are just testing for bit30, MASK_MCQ_SUPPORT is not really needed. >Maybe just: >hba->mcq_sup = (hba->capabilities >> MCQ_SUPP_SHIFT) & 1; > Thanks. Yeah, Mani suggested FIELD* macros as an option too. Let me check that as well and address this in the next version. -asd