Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
MIME-Version: 1.0
References: <20220926183533.1893371-1-aurelien@aurel32.net>
 <CAMdYzYoR2caD2ecN5vGTiHejoE5AhbyKxSgSeU1+SzU7nNVTwg@mail.gmail.com> <YzINPR0htauYppWQ@aurel32.net>
In-Reply-To: <YzINPR0htauYppWQ@aurel32.net>
From:   Peter Geis <pgwipeout@gmail.com>
Date:   Mon, 26 Sep 2022 18:34:04 -0400
Message-ID: <CAMdYzYqo9+DjvWTQMrZ=cDceG3KJOwBvSva0aRs_7rooko5f2Q@mail.gmail.com>
Subject: Re: [PATCH] arm64: dts: rockchip: Add missing rockchip,pipe-grf to
 rk3568 PCIe v3 PHY
To:     Peter Geis <pgwipeout@gmail.com>, linux-kernel@vger.kernel.org,
        Rob Herring <robh+dt@kernel.org>,
        Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
        Heiko Stuebner <heiko@sntech.de>,
        Frank Wunderlich <frank-w@public-files.de>,
        "open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS" 
        <devicetree@vger.kernel.org>,
        "moderated list:ARM/Rockchip SoC support" 
        <linux-arm-kernel@lists.infradead.org>,
        "open list:ARM/Rockchip SoC support" 
        <linux-rockchip@lists.infradead.org>
Content-Type: text/plain; charset="UTF-8"
Precedence: bulk

On Mon, Sep 26, 2022 at 4:36 PM Aurelien Jarno <aurelien@aurel32.net> wrote:
>
> On 2022-09-26 14:58, Peter Geis wrote:
> > On Mon, Sep 26, 2022 at 2:35 PM Aurelien Jarno <aurelien@aurel32.net> wrote:
> > >
> > > This commit fixes the error message
> > >
> > >   rockchip-snps-pcie3-phy fe8c0000.phy: failed to find rockchip,pipe_grf regmap
> >
> > The pipe grf only is used on the rk3588 device for this phy.
>
> Ok, looking at the code in details, I confirm that. Does it mean the
> change should be done at the phy driver level, to only look for
> rockchip,pipe-grf on the rk3588 device?

That would be reasonable, yes.

>
> --
> Aurelien Jarno                          GPG: 4096R/1DDD8C9B
> aurelien@aurel32.net                 http://www.aurel32.net