Received: by 2002:a05:6359:c8b:b0:c7:702f:21d4 with SMTP id go11csp164755rwb; Mon, 26 Sep 2022 16:36:24 -0700 (PDT) X-Google-Smtp-Source: AMsMyM5ghQabnSBcsxoPTkDp2QnZGieRX4UkahwGDobuOO+C2pM2t2QlsYhi4z2uNXYvZ4XlRMW+ X-Received: by 2002:a17:902:bd02:b0:178:1a1c:889 with SMTP id p2-20020a170902bd0200b001781a1c0889mr24244329pls.107.1664235383972; Mon, 26 Sep 2022 16:36:23 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1664235383; cv=none; d=google.com; s=arc-20160816; b=aNYLTJn0uHVvwvd8uPjhmg+kiGxsMhpbQmWlAP4ooLQ5Fd7MzNFJ8Zo4TBetKPw6n7 QN8XVzSKxtk2rJop3CD3I3cNNziiP/WEN+xxElRgyj6ECoAs7opGBqrgVMds6iYA0hom dgN4/zRLnEw78EbOwmAWNV3ruv2C1eknoo/QavDqK24PFXjr2fyA9eUhcehAMsn6zNSX SXS690ZPnahmWztu0kyvh1hL7qFD948D7CUo0HEqFzE74BqSK1ndbITiCVi8cYhGAQXG fgmrv34Z0E2D2uWMYS5V6Lkr/MAi83bBqqo2hSHaMYk3VEeEOjaUCXNKUHeMuSyPI/tI ejpw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date:dkim-signature; bh=Z+V9HKEzE/RCD+QuWbpkWnuj/UNSjdfJYogyydpcU5E=; b=XMPK1XHqsBHCOQwbRye8DBF1KoD/nZ+Qv24svJQN9NnpysuzgOeWZEloKpxaDfeSlw TnpB3qnD9uasTQPCSUQEloBY+r84XFuA2zuNjA6xxLj0IoamCMfUQ9n0XJXQjQSrpGJN nvXxeC3KB1ID7IefWsDOcNlBJLi2BGZOwO6ufPb6Iu8uVs5w6ZuY9GIQGH+6FNFj0MaR iVTj8r73UR2NiTD95gCuIXosb5hr9gdDFej7MxUqdNSLblEmjE+/8U3EBwq9scGNMAKg eQtwlXikPQB7RF2RBhOS4Hu0bBWtZl7rO3ewdFISjsX7VGcPAvEkpCKDqEKkR9CKjf54 DskA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@chromium.org header.s=google header.b=kdUvjIZk; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=chromium.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id a186-20020a621ac3000000b0053e3cf68da1si210746pfa.74.2022.09.26.16.36.10; Mon, 26 Sep 2022 16:36:23 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@chromium.org header.s=google header.b=kdUvjIZk; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=chromium.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229502AbiIZWAW (ORCPT + 99 others); Mon, 26 Sep 2022 18:00:22 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:52268 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229549AbiIZWAU (ORCPT ); Mon, 26 Sep 2022 18:00:20 -0400 Received: from mail-pf1-x42d.google.com (mail-pf1-x42d.google.com [IPv6:2607:f8b0:4864:20::42d]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id EDAB89F0F9 for ; Mon, 26 Sep 2022 15:00:19 -0700 (PDT) Received: by mail-pf1-x42d.google.com with SMTP id b75so8013284pfb.7 for ; Mon, 26 Sep 2022 15:00:19 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date; bh=Z+V9HKEzE/RCD+QuWbpkWnuj/UNSjdfJYogyydpcU5E=; b=kdUvjIZklCh7p0dy2cbAnFPWMnaQ9KU6pSVxgIsJWiq+Rg7+dTzBAtFdhyUWV/brDb IpNU0HceJCKIFZWASfKOAiuYPFrkk0Borpnr6U537aRJejJsQ1FDpSlMfPthP5MEWXSa tH5lEPrVqifpJ/Q2B8PMTZfLFiNA71z5Vn/X4= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date; bh=Z+V9HKEzE/RCD+QuWbpkWnuj/UNSjdfJYogyydpcU5E=; b=px8f5oga04xMTowlt2GBf+7UVazSPB6z2rThaRfwIiI78ssCP63hh/2FDuokGUUmP9 R2S1d1q+nG5ZfD0WXpCk9VSnCcISm7pnKH/Ofpg4Z5H4b8EWNDhVVlU3E4CXlEILdi4k q6SvsAjYhdMuywEZDoHd71J+GbCz1vFCjoizcXxdGez3nJPo+gAzQySWCKIBzMx9p+EZ vPbDiJpNMqn1SRvPzuGJ+Wpmg4eFh6DDn/TRAtLUGAfldEQGiTZViXZP01MLylKBl9r2 HeIRxcIfC3ESalHPnqHdPYZFkzx6X5TwWNtiVfNmVfQ72HLeVdJob6d/RmSyUSJnXSVs WnJg== X-Gm-Message-State: ACrzQf0I3aoVd3b41EgYMYpswep+h2oNsTBvrRqVeducxwHZyg6lzea+ Q7bfoaKRie+/fiyJ8NlpuAF/Aw== X-Received: by 2002:aa7:9e12:0:b0:53e:27d8:b71b with SMTP id y18-20020aa79e12000000b0053e27d8b71bmr25834865pfq.46.1664229619477; Mon, 26 Sep 2022 15:00:19 -0700 (PDT) Received: from www.outflux.net (smtp.outflux.net. [198.145.64.163]) by smtp.gmail.com with ESMTPSA id a24-20020aa794b8000000b0053e6d352ae4sm6408pfl.24.2022.09.26.15.00.18 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 26 Sep 2022 15:00:18 -0700 (PDT) Date: Mon, 26 Sep 2022 15:00:17 -0700 From: Kees Cook To: "Gustavo A. R. Silva" Cc: Jaroslav Kysela , Takashi Iwai , alsa-devel@alsa-project.org, linux-kernel@vger.kernel.org, linux-hardening@vger.kernel.org Subject: Re: [PATCH][next] ASoC: SOF: control.h: Replace zero-length array with DECLARE_FLEX_ARRAY() helper Message-ID: <202209261500.B594CC10@keescook> References: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Spam-Status: No, score=-2.2 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE, SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Sep 26, 2022 at 04:40:55PM -0500, Gustavo A. R. Silva wrote: > Zero-length arrays are deprecated and we are moving towards adopting > C99 flexible-array members, instead. So, replace zero-length arrays > declarations in anonymous union with the new DECLARE_FLEX_ARRAY() > helper macro. > > This helper allows for flexible-array members in unions. > > Link: https://github.com/KSPP/linux/issues/193 > Link: https://github.com/KSPP/linux/issues/211 > Link: https://gcc.gnu.org/onlinedocs/gcc/Zero-Length.html > Signed-off-by: Gustavo A. R. Silva Reviewed-by: Kees Cook -- Kees Cook