Received: by 2002:a05:6359:c8b:b0:c7:702f:21d4 with SMTP id go11csp220882rwb; Mon, 26 Sep 2022 17:39:46 -0700 (PDT) X-Google-Smtp-Source: AMsMyM6UjBkp0ZFPMu6q5CPxj8Tua09VloHQg27hjzAVWtXaY/zrKPTzio89G6hKTUl1OG9QlWD+ X-Received: by 2002:a17:907:2c78:b0:779:7327:c897 with SMTP id ib24-20020a1709072c7800b007797327c897mr20053217ejc.657.1664239186573; Mon, 26 Sep 2022 17:39:46 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1664239186; cv=none; d=google.com; s=arc-20160816; b=T4DIoU8rXXTNbciFIxAGVzbHRoY7s+gbYOX1fQOpajUmcgcz8HheCstz7YnN21T9ve oVnQ6FY4A0z7daocFVtcmQd8HIDqE5yPExLZN6jQwde3zRgcpl0qAbtndaq05l50PFvL /3w3xJH804pxF4GYZ2RDB1eEyNRxXkGzoYt3UsRsuUk0nGrDPbazEX7mmXp9l/LWbg/z doaTUDyT1MRbcN7Teogqe4urw6udsRFd1y4rFjV9UsGKQXmgPAY8O0fxc25l6Wv8tKBw XJuF5eINJS2VX2Ucj4geX+XiBChCdGvhQQ69nGjfyd5vV6bqjIROikP310wAKeHqR/3U w1MA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:subject:cc:to:from:date :dkim-signature; bh=BzP4342DIwMOqqS8Kk9BWuY9SN9rG20j6Y6moZIC1Lo=; b=sLl3Q2tD7VZZaxQjLKeGOehaPjEIgC45CXP73cHC1gN+VdN+9+4mXI3HF8wzmOdvQC omDIrU6MvY9/K1ymYTcUCBPYFr3f5GCfZMzyZ8U4Y7kJI7f0ZL9ut75yhi8CHhssjnuQ w9eyCK7+TPyUp/u3iPhsBjpKtwilxU4JfSF+7fQGbDw51DpUCRLbdlJjxatgFxlUcMG/ 2Dehf+s0ou/ut2o1fa0Ss5hTvIGtwGd9+fT6xJlEuhETM2c60tfletiAbGLp0nxh9DBG TI24H3GYNhSApbPxih6j/MtBwDkj4hq4w+3s7VVk+3qIRpXwV7MFg+ShPOWjP6hN+0H7 GcNA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b="K/Eyzvmi"; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id a26-20020a170906275a00b00783ba3ba6a9si1017979ejd.845.2022.09.26.17.39.20; Mon, 26 Sep 2022 17:39:46 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b="K/Eyzvmi"; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229779AbiI0AdR (ORCPT + 99 others); Mon, 26 Sep 2022 20:33:17 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:55220 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229613AbiI0AdP (ORCPT ); Mon, 26 Sep 2022 20:33:15 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 9489FEE640; Mon, 26 Sep 2022 17:33:14 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 2F5626151F; Tue, 27 Sep 2022 00:33:14 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 36662C433D6; Tue, 27 Sep 2022 00:33:13 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1664238793; bh=F9uwrTRrrB6ehWWU5SZkXZTq8t8gAoqykefYLXGJx/c=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=K/EyzvmioHAobjA0jyeiVZYDyNTnQwrkVVjzWM6SnGxk1HAyiuxjg6e+wLgZjuAwG +AGnSP+mPEcibS/Qy3IBg8KmFSfRp8fJhW6oVvPQV5IzeOdB4um2SjeN/I2xHQSR1y 7xa92B08CE8hYgOsLdz8bJ34cKoVwiV5PflX96wyouyJ2Ghctbrnd5JuuNCRMXyL4U cOc5MOuf/hMu7A/qyyFU+T9laFC41NzHMSG6n1EYM4A0OO6YCyk9wyHl4c7KOj7T0x yiGOX0d3EeNnFsBaNz9t2y87wENyYtKRalViuMTPTB2dX0EHj0vZtr0QpjHT/TwXZ7 u/tujSjHv8Z3A== Date: Mon, 26 Sep 2022 17:33:12 -0700 From: Jakub Kicinski To: Jules Irenge Cc: borntraeger@linux.ibm.com, svens@linux.ibm.com, linux-s390@vger.kernel.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, agordeev@linux.ibm.com Subject: Re: [PATCH 3/7] s390/qeth: Convert snprintf() to scnprintf() Message-ID: <20220926173312.7a735619@kernel.org> In-Reply-To: References: MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-7.2 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_HI, SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, 26 Sep 2022 19:42:38 +0100 Jules Irenge wrote: > Coccinnelle reports a warning > Warning: Use scnprintf or sprintf > Adding to that, there has been a slow migration from snprintf to scnprintf. > This LWN article explains the rationale for this change > https: //lwn.net/Articles/69419/ > Ie. snprintf() returns what *would* be the resulting length, > while scnprintf() returns the actual length. > > Signed-off-by: Jules Irenge Looks legit but please repost this separately. We only see patch 3 of the series.