Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
IronPort-SDR: kb5+IPeVqpLVru73bqvOuIKlcZuAo6gUQHrYjXq2dyM/RU+owiJ6+48+zIhPTXJ2Nl65yOXYom
 /JrBC0qkRg3ApNQ+AUtWHddSadZ9HAVNe22HC5Mm9+jOEgFnE+rmdwCF0auhptUjwA/PSl6C2q
 aVeyIWM7dKXtisTaaj2mNE1l5NbEDLe0xCBpJ/JyNJsaiPy8tqTX0ZnAXqtAnLE2XDAoMDmwH9
 p2B3n0Wbdon4+3GUKTwfYYyWDfvbT8Pkyr799SRQzYkvY2lJZV/PRmhMI/Hs1bwcl3rbhC9sye
 pNp0MOxgjwGnq1WqQx5hEugF
IronPort-SDR: INU/Jese2NFtfdhAW3w9K+Vi4/TITk3gvi/xFbF8LaTLEBSWjaCyH7WNqOe92yh5bmRL9eR3oy
 PomWedIfQk4RwWxldJ9tcUbPlcwoAQJIREjn8kjuG8kJ+ISIxsBm3MmaLd90ocqhkkK+gxBOta
 PvO7qfywEpJDjT2Qa92LmXfQuuZ+/VEtX1ORqooPw7oI4vPJNPjEMyh7wfTtiZ+rRrd5jKXC82
 XHA0icRs9wW4kaiPqK1en+7NtbwrNTd39Q+AuERKA13HauizJTvBWhjH+VyHFb03rCs5HhrB3Z
 WJ4=
WDCIronportException: Internal
Message-ID: <7f557035-0f9d-d93d-ce19-a73116076497@opensource.wdc.com>
Date:   Tue, 27 Sep 2022 11:27:31 +0900
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101
 Thunderbird/102.3.0
Subject: Re: [PATCH v3 4/8] scsi: mvsas: use sas_find_attached_phy() instead
 of open coded
Content-Language: en-US
To:     Jason Yan <yanaijie@huawei.com>, martin.petersen@oracle.com,
        jejb@linux.ibm.com
Cc:     linux-scsi@vger.kernel.org, linux-kernel@vger.kernel.org,
        hare@suse.com, hch@lst.de, bvanassche@acm.org,
        john.garry@huawei.com, jinpu.wang@cloud.ionos.com,
        Jack Wang <jinpu.wang@ionos.com>
References: <20220927022941.4029476-1-yanaijie@huawei.com>
 <20220927022941.4029476-5-yanaijie@huawei.com>
From:   Damien Le Moal <damien.lemoal@opensource.wdc.com>
Organization: Western Digital Research
In-Reply-To: <20220927022941.4029476-5-yanaijie@huawei.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
Precedence: bulk

On 9/27/22 11:29, Jason Yan wrote:
> The attached phy finding is open coded. Now we can replace it with
> sas_find_attached_phy().
> 
> Signed-off-by: Jason Yan <yanaijie@huawei.com>
> Reviewed-by: Jack Wang <jinpu.wang@ionos.com>

Reviewed-by: Damien Le Moal <damien.lemoal@opensource.wdc.com>

> ---
>  drivers/scsi/mvsas/mv_sas.c | 15 ++++-----------
>  1 file changed, 4 insertions(+), 11 deletions(-)
> 
> diff --git a/drivers/scsi/mvsas/mv_sas.c b/drivers/scsi/mvsas/mv_sas.c
> index a6867dae0e7c..f6576ffabe9f 100644
> --- a/drivers/scsi/mvsas/mv_sas.c
> +++ b/drivers/scsi/mvsas/mv_sas.c
> @@ -1190,23 +1190,16 @@ static int mvs_dev_found_notify(struct domain_device *dev, int lock)
>  	mvi_device->sas_device = dev;
>  	if (parent_dev && dev_is_expander(parent_dev->dev_type)) {
>  		int phy_id;
> -		u8 phy_num = parent_dev->ex_dev.num_phys;
> -		struct ex_phy *phy;
> -		for (phy_id = 0; phy_id < phy_num; phy_id++) {
> -			phy = &parent_dev->ex_dev.ex_phy[phy_id];
> -			if (SAS_ADDR(phy->attached_sas_addr) ==
> -				SAS_ADDR(dev->sas_addr)) {
> -				mvi_device->attached_phy = phy_id;
> -				break;
> -			}
> -		}
>  
> -		if (phy_id == phy_num) {
> +		phy_id = sas_find_attached_phy(&parent_dev->ex_dev, dev);
> +		if (phy_id == -ENODEV) {
>  			mv_printk("Error: no attached dev:%016llx"
>  				"at ex:%016llx.\n",
>  				SAS_ADDR(dev->sas_addr),
>  				SAS_ADDR(parent_dev->sas_addr));
>  			res = -1;

Would be nice to keep the -ENODEV error here instead of this generic, and
meaningless, "-1" code. Same for the previous patch too.

> +		} else {
> +			mvi_device->attached_phy = phy_id;
>  		}
>  	}
>  

-- 
Damien Le Moal
Western Digital Research