Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
IronPort-SDR: mk4UssP0QejoeM69QQYi7jdAIfQqz81v6Yk3/cEtaA+ME0D/q1WKsj1rfOq5JYIIwLhL0Dz672
 EDufl5uQiNyE1UG7+yQG4kMpjxLhU6MEIm4guhcB2ao6V0l7q8GcWAbh/XaGBDlnWejJO2YTz5
 A1OyPPgSNCbKv0tJWRCfUA1HEGXa6n90PAAbyu14m0ai+sw2oTtsW1kHzqel4TDbLnRijlSx59
 2SYNed4KmA+CrGzKsK4/I0imhkkthtwPG4OAAAsaXbKomSBEa0MkXDWCotaVF8i5TuCxbKWIZ9
 9mV3ROXnTgodMJCU/jEbSybD
IronPort-SDR: Vi1Iig0EFnWEbtPaXVmWKsZItEmxzsQe+WAhhvwvN5QccytS5gRN4AE881KQSb+nyR02I9s4cW
 2flzhIHovIGV8oVz5FB8PNa5B2DazcyBK0EjEMd++J6sjoblYdxWpRM2dncCEOOUoo8tpP8ZAC
 OcegIeEByQGn1LURnNPYas1JmF/sp1WLI37VBwP/m+szsvD1nz8uCD6CRzXxj3b66yjPiPbBda
 YDOXqcflALTXE6ZuGvTVz0tKRw2EdQFFgzrGqDKUMgYeySlOhvpx83wAzRMcDt/d9PEquYKHHG
 OYQ=
WDCIronportException: Internal
Message-ID: <6654484e-70ce-d34f-ec48-44b0eb2bd0a5@opensource.wdc.com>
Date:   Tue, 27 Sep 2022 11:28:05 +0900
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101
 Thunderbird/102.3.0
Subject: Re: [PATCH v3 5/8] scsi: hisi_sas: use sas_find_attathed_phy()
 instead of open coded
Content-Language: en-US
To:     Jason Yan <yanaijie@huawei.com>, martin.petersen@oracle.com,
        jejb@linux.ibm.com
Cc:     linux-scsi@vger.kernel.org, linux-kernel@vger.kernel.org,
        hare@suse.com, hch@lst.de, bvanassche@acm.org,
        john.garry@huawei.com, jinpu.wang@cloud.ionos.com,
        Jack Wang <jinpu.wang@ionos.com>
References: <20220927022941.4029476-1-yanaijie@huawei.com>
 <20220927022941.4029476-6-yanaijie@huawei.com>
From:   Damien Le Moal <damien.lemoal@opensource.wdc.com>
Organization: Western Digital Research
In-Reply-To: <20220927022941.4029476-6-yanaijie@huawei.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
Precedence: bulk

On 9/27/22 11:29, Jason Yan wrote:
> The attached phy finding is open coded. Now we can replace it with
> sas_find_attached_phy().
> 
> Signed-off-by: Jason Yan <yanaijie@huawei.com>
> Reviewed-by: Jack Wang <jinpu.wang@ionos.com>

Reviewed-by: Damien Le Moal <damien.lemoal@opensource.wdc.com>

> ---
>  drivers/scsi/hisi_sas/hisi_sas_main.c | 12 ++----------
>  1 file changed, 2 insertions(+), 10 deletions(-)
> 
> diff --git a/drivers/scsi/hisi_sas/hisi_sas_main.c b/drivers/scsi/hisi_sas/hisi_sas_main.c
> index 33af5b8dede2..995ccb13fb9d 100644
> --- a/drivers/scsi/hisi_sas/hisi_sas_main.c
> +++ b/drivers/scsi/hisi_sas/hisi_sas_main.c
> @@ -792,17 +792,9 @@ static int hisi_sas_dev_found(struct domain_device *device)
>  
>  	if (parent_dev && dev_is_expander(parent_dev->dev_type)) {
>  		int phy_no;
> -		u8 phy_num = parent_dev->ex_dev.num_phys;
> -		struct ex_phy *phy;
>  
> -		for (phy_no = 0; phy_no < phy_num; phy_no++) {
> -			phy = &parent_dev->ex_dev.ex_phy[phy_no];
> -			if (SAS_ADDR(phy->attached_sas_addr) ==
> -				SAS_ADDR(device->sas_addr))
> -				break;
> -		}
> -
> -		if (phy_no == phy_num) {
> +		phy_no = sas_find_attached_phy(&parent_dev->ex_dev, device);
> +		if (phy_no == -ENODEV) {
>  			dev_info(dev, "dev found: no attached "
>  				 "dev:%016llx at ex:%016llx\n",
>  				 SAS_ADDR(device->sas_addr),

-- 
Damien Le Moal
Western Digital Research