Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
IronPort-SDR: bI7NtMaw2YkKbjFQABgEDnNhMMYA6b8uBAAwU9z85PtRZaSZCyo25OlAT0HGpSFvn3Ft3dPWGd
 WPAiDw4aWy5a0InN/sMurKtx2aaKYShJe2It89odvDsWNkFTWNOfsHldmMY+mMC/wrwEWOj6Ag
 ba8YPLATNU0jvKzKPJqYCrXZhPFh2LibxBgXMJECxPevOGlOuEQ0pJIMZfpjMFftHbLq0UH5Q9
 dSOh+X9HDGKWESgzefiziChRuwWbdBiFs8G+6fM5Egjo6tEyTtOYiOSdcmDMOKlESmZdQ1mRnb
 Bjd+SaG2Qbdt793fbYUhtnkO
IronPort-SDR: TSdCl4g6FtqvlNtAznOAiXM9fwUi9CkqOCfBRyTvM+cwfEPaQpMifEQQD+62H5kSwq1XBEXf1L
 UjI26z5P9ioT6+LIklUtzjFM/mmLvNmXoGSG6wTvIpuMOXXIbvVxCCx4qK+CXRqBMyt9oI1y4h
 oa3GI6yvhNgbDatIL15LmgAOYHwq+n1ua9+1YziXv+0aMcE7IXhP0QrpGNHe8SJP03uTceFiu+
 nwcBRMVKV48fzz2v4DmWNG1TPBlt79RalHhPS0e4yiGEgQTbw4dT68DH5LpnSPkX67tX39o5xw
 6ls=
WDCIronportException: Internal
Message-ID: <4e829dd7-6db3-4dbf-1b8e-9f7bb805f723@opensource.wdc.com>
Date:   Tue, 27 Sep 2022 11:23:09 +0900
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101
 Thunderbird/102.3.0
Subject: Re: [PATCH v3 1/8] scsi: libsas: introduce sas address comparation
 helpers
Content-Language: en-US
To:     Jason Yan <yanaijie@huawei.com>, martin.petersen@oracle.com,
        jejb@linux.ibm.com
Cc:     linux-scsi@vger.kernel.org, linux-kernel@vger.kernel.org,
        hare@suse.com, hch@lst.de, bvanassche@acm.org,
        john.garry@huawei.com, jinpu.wang@cloud.ionos.com
References: <20220927022941.4029476-1-yanaijie@huawei.com>
 <20220927022941.4029476-2-yanaijie@huawei.com>
From:   Damien Le Moal <damien.lemoal@opensource.wdc.com>
Organization: Western Digital Research
In-Reply-To: <20220927022941.4029476-2-yanaijie@huawei.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
Precedence: bulk

On 9/27/22 11:29, Jason Yan wrote:
> Sas address comparation is widely used in libsas. However they are all

s/comparation/comparison

Here and in the patch title.

Other than that, Looks OK to me.

Reviewed-by: Damien Le Moal <damien.lemoal@opensource.wdc.com>

> opencoded and to avoid the line spill over 80 columns, are mostly split
> into multi-lines. Introduce some helpers to prepare some refactor.
> 
> Signed-off-by: Jason Yan <yanaijie@huawei.com>
> ---
>  drivers/scsi/libsas/sas_internal.h | 17 +++++++++++++++++
>  1 file changed, 17 insertions(+)
> 
> diff --git a/drivers/scsi/libsas/sas_internal.h b/drivers/scsi/libsas/sas_internal.h
> index 8d0ad3abc7b5..3384429b7eb0 100644
> --- a/drivers/scsi/libsas/sas_internal.h
> +++ b/drivers/scsi/libsas/sas_internal.h
> @@ -111,6 +111,23 @@ static inline void sas_smp_host_handler(struct bsg_job *job,
>  }
>  #endif
>  
> +static inline bool sas_phy_match_dev_addr(struct domain_device *dev,
> +					 struct ex_phy *phy)
> +{
> +	return SAS_ADDR(dev->sas_addr) == SAS_ADDR(phy->attached_sas_addr);
> +}
> +
> +static inline bool sas_phy_match_port_addr(struct asd_sas_port *port,
> +					   struct ex_phy *phy)
> +{
> +	return SAS_ADDR(port->sas_addr) == SAS_ADDR(phy->attached_sas_addr);
> +}
> +
> +static inline bool sas_phy_addr_match(struct ex_phy *p1, struct ex_phy *p2)
> +{
> +	return  SAS_ADDR(p1->attached_sas_addr) == SAS_ADDR(p2->attached_sas_addr);
> +}
> +
>  static inline void sas_fail_probe(struct domain_device *dev, const char *func, int err)
>  {
>  	pr_warn("%s: for %s device %016llx returned %d\n",

-- 
Damien Le Moal
Western Digital Research