Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
IronPort-SDR: UtbRCdRjQT1C8httVhxNtQeMQ9Z584IlD8WUIhJN1HPYE6i4ZCEV3V0m+euIJ7+0j2D2B5+3li
 XGqDRxadG28DV8n/eKe9CkatK9dxCnz6WXAt/quS6+C6OanZYdiicNiJujCSChMVQztp+OsKoy
 HY/SzfVDAlPOuHQNejhpjt+zFnZT1WNFT3txMjRhNdrTth517DRUoMyvXE+rogqFzRD/ZUzi++
 ZTbjXCu7sv2VZrac8YjNr8yzSOMaS9qdQnjO8Vas3hGJIOOQ9hgHniTcW38xEnGa4Yb+4G0Beq
 wSSDhUpA3XTmJbawxDuT496m
IronPort-SDR: PC2h09zRyANGEJE0B0GzAQHUGy48EKe0lVkECi6KdjGQnBzRWcrpj2dIrpCC8kjxxcLV4ejHzS
 6uDBhId6YRloepNZcUv/n/XlX/aCgFtxx05JudnaGtL4ragI8X4OD3M0JFD20iEjw/JhEi4VBs
 VMYfJs/Dy9X4iRAeq3dIRdG/IYMByVspbKHx6kMk8MYB423sg2Ekkw8WgQMKcYKIArWC1ZRDm3
 bo5VjTfErsoABWXJo+ttib/GNfJV1E1nOlnKPVwXgWQPArqm0qmzL12P/lOjtvgr5cr4TeLs5r
 5mk=
WDCIronportException: Internal
Message-ID: <654fe6d2-4556-8d15-bacc-b6ee1e927d91@opensource.wdc.com>
Date:   Tue, 27 Sep 2022 11:32:04 +0900
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101
 Thunderbird/102.3.0
Subject: Re: [PATCH v3 8/8] scsi: libsas: use sas_phy_match_port_addr()
 instead of open coded
Content-Language: en-US
To:     Jason Yan <yanaijie@huawei.com>, martin.petersen@oracle.com,
        jejb@linux.ibm.com
Cc:     linux-scsi@vger.kernel.org, linux-kernel@vger.kernel.org,
        hare@suse.com, hch@lst.de, bvanassche@acm.org,
        john.garry@huawei.com, jinpu.wang@cloud.ionos.com
References: <20220927022941.4029476-1-yanaijie@huawei.com>
 <20220927022941.4029476-9-yanaijie@huawei.com>
From:   Damien Le Moal <damien.lemoal@opensource.wdc.com>
Organization: Western Digital Research
In-Reply-To: <20220927022941.4029476-9-yanaijie@huawei.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
Precedence: bulk

On 9/27/22 11:29, Jason Yan wrote:
> The sas address comparation of asd_sas_port and expander phy is open
> coded. Now we can replace it with sas_phy_match_port_addr().

Comparison typo again.

> 
> Signed-off-by: Jason Yan <yanaijie@huawei.com>

With that fixed,

Reviewed-by: Damien Le Moal <damien.lemoal@opensource.wdc.com>

> ---
>  drivers/scsi/libsas/sas_expander.c | 3 +--
>  1 file changed, 1 insertion(+), 2 deletions(-)
> 
> diff --git a/drivers/scsi/libsas/sas_expander.c b/drivers/scsi/libsas/sas_expander.c
> index f268291b7584..eabc56966f36 100644
> --- a/drivers/scsi/libsas/sas_expander.c
> +++ b/drivers/scsi/libsas/sas_expander.c
> @@ -1005,8 +1005,7 @@ static int sas_ex_discover_dev(struct domain_device *dev, int phy_id)
>  	}
>  
>  	/* Parent and domain coherency */
> -	if (!dev->parent && (SAS_ADDR(ex_phy->attached_sas_addr) ==
> -			     SAS_ADDR(dev->port->sas_addr))) {
> +	if (!dev->parent && sas_phy_match_port_addr(dev->port, ex_phy)) {
>  		sas_add_parent_port(dev, phy_id);
>  		return 0;
>  	}

-- 
Damien Le Moal
Western Digital Research