Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
IronPort-SDR: 0j9kXyZUFWHerWsdG23nvjGK+JS6LSFIn8eXPhIWfVd+OQDqRDE08Z1sXTylIieJN5kl3nDIaz
 4kfvm6qstefRuWxARUlr3VFJy0DvTcgzI0zlbBTVaHgXjyvAc+k8iukiuSS94NkaTNbjs0x9Bq
 240Nr+HdhiuWn7KCC0qsQI/GEvX4GkpAtUFyRN0zaYbyDWcTDycPsxMXgvsDwtb7BV0RkOY/Z1
 ug6Ogt12wxhH2bgaIvmgCLmDjttAgXPEVJUrqFlmRjO3cNgxh84b18FMSXNoyRUZ3psQRQ+QDF
 hepZAuorin7axfw/HoEgYXW7
IronPort-SDR: 1NqMccdgp2VoIt6zCjwxiYKPnYAp3+D5INh+lIGQ80PNDSvswLKvrZ+H6avvAKl1TfLRk5kkoK
 WXtZv3ak3pLzI03CZqLEYXrRBtNbuwEwnVWMduPjTUUdD6RxYCvCbmE+lnCpXqS109moKB4Kgi
 I3NuOPaPfSzFCLM/F6JKcwqoVSNggUSGBWKuPuOE5yIZdXCDxgnXFHAVPVITRxY3sss470v3a5
 y4moEpQ035duqoy9s3Dr/bkgE1fGt4m5ZGXvdfl3j936n6TEmMt9J64mr9kA/biTmFrLfNHLM7
 edI=
WDCIronportException: Internal
Message-ID: <20bbed3e-272a-0a35-c727-4b0b48d2baae@opensource.wdc.com>
Date:   Tue, 27 Sep 2022 11:31:22 +0900
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101
 Thunderbird/102.3.0
Subject: Re: [PATCH v3 7/8] scsi: libsas: use sas_phy_addr_match() instead of
 open coded
Content-Language: en-US
To:     Jason Yan <yanaijie@huawei.com>, martin.petersen@oracle.com,
        jejb@linux.ibm.com
Cc:     linux-scsi@vger.kernel.org, linux-kernel@vger.kernel.org,
        hare@suse.com, hch@lst.de, bvanassche@acm.org,
        john.garry@huawei.com, jinpu.wang@cloud.ionos.com
References: <20220927022941.4029476-1-yanaijie@huawei.com>
 <20220927022941.4029476-8-yanaijie@huawei.com>
From:   Damien Le Moal <damien.lemoal@opensource.wdc.com>
Organization: Western Digital Research
In-Reply-To: <20220927022941.4029476-8-yanaijie@huawei.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
Precedence: bulk

On 9/27/22 11:29, Jason Yan wrote:
> The sas address comparation of expander phys is open coded. Now we can
> replace it with sas_phy_addr_match().

s/comparation/comparison

All the other patches have the same typo too.

> 
> Signed-off-by: Jason Yan <yanaijie@huawei.com>

With that fixed,

Reviewed-by: Damien Le Moal <damien.lemoal@opensource.wdc.com>

> ---
>  drivers/scsi/libsas/sas_expander.c | 3 +--
>  1 file changed, 1 insertion(+), 2 deletions(-)
> 
> diff --git a/drivers/scsi/libsas/sas_expander.c b/drivers/scsi/libsas/sas_expander.c
> index b2b5103c3e76..f268291b7584 100644
> --- a/drivers/scsi/libsas/sas_expander.c
> +++ b/drivers/scsi/libsas/sas_expander.c
> @@ -2058,8 +2058,7 @@ static int sas_rediscover(struct domain_device *dev, const int phy_id)
>  
>  			if (i == phy_id)
>  				continue;
> -			if (SAS_ADDR(phy->attached_sas_addr) ==
> -			    SAS_ADDR(changed_phy->attached_sas_addr)) {
> +			if (sas_phy_addr_match(phy, changed_phy)) {
>  				last = false;
>  				break;
>  			}

-- 
Damien Le Moal
Western Digital Research