Received: by 2002:a05:6359:c8b:b0:c7:702f:21d4 with SMTP id go11csp373304rwb; Mon, 26 Sep 2022 21:03:47 -0700 (PDT) X-Google-Smtp-Source: AMsMyM7uTMb6ChC48bINBua/VmBVSfVJcyrYwGbqCJ7A3HynjQzzGUf0dpA6qMLzvnfk77SPxeCn X-Received: by 2002:a17:907:b03:b0:770:872d:d7e9 with SMTP id h3-20020a1709070b0300b00770872dd7e9mr20912829ejl.272.1664251427214; Mon, 26 Sep 2022 21:03:47 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1664251427; cv=none; d=google.com; s=arc-20160816; b=YA2F89ZIZNDKeSLQbP1xoG6vcPJyPoBq2AOz+8DAm4wibDwjnE0Dk03DbmXYAW6iwB kbCrQGTfFKfQj4gM1qxxS1J+IgVyV/xeKxcGDPzcHnGR4jvsKW2ZOv7/Pnsy4aDGRcRN cyWKlHlM54Ud9GXlexnYz6/lOtO4Du14PhIYmH8CQNmyHvzmoP4Xgmjo9ARhe55pcIDr Oq9h/2MRqFG2ofbz8LzzBQ3GztyOm6IUTWa8idkC1K/BBwvItrXAIZ6eAshy64A7knft n6anlYMIm0LEP9U+aUj55Jr4IoW1gPWZVLw34M/1z2g6Tkb+Fka/WCMiWirTAN6UAFuN kFIg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date:dkim-signature; bh=A415gP/CRCjugI919Jgs4A7RjNMw5l2C7zh5BSt6/9c=; b=XWajFYrMX98WVwZkHtk81dGcKo6NaTB8E+QBZibRl99yOu+BkIaPnvq/X7wKPfj73p PvGXUo8hpr9xsYq+fNgbjj8LGyo9JmA4nXmjHujWZh54UwYUY8yn48r/qmRGS9vhmxxb TikxNjbgngLqu2isgFEAwWFMnMexum2hiJ0//+K8yvLC/EEt3f0L0WZ9f+tofCrMnWUf O1xM6Ns4Ux6AWjlAozN4uUqu34R9ZPuakzVGVc0jFEv8G6igVEqV1p4bKkSi5g3yma9E Vp4a7JWAuHCYD10Sv/Ht0SqDkVNXt2YJAXKj/imGRhKoSFBBmtycolqH3wcXSsnKyBNj YERA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@chromium.org header.s=google header.b=cw1mNAoz; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=chromium.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id l19-20020a056402255300b00445e20bc95bsi569975edb.428.2022.09.26.21.03.22; Mon, 26 Sep 2022 21:03:47 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@chromium.org header.s=google header.b=cw1mNAoz; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=chromium.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229782AbiI0CbD (ORCPT + 99 others); Mon, 26 Sep 2022 22:31:03 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:59694 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230288AbiI0CbB (ORCPT ); Mon, 26 Sep 2022 22:31:01 -0400 Received: from mail-pg1-x533.google.com (mail-pg1-x533.google.com [IPv6:2607:f8b0:4864:20::533]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 2E5F4D2D7D for ; Mon, 26 Sep 2022 19:30:59 -0700 (PDT) Received: by mail-pg1-x533.google.com with SMTP id e129so2106872pgc.9 for ; Mon, 26 Sep 2022 19:30:58 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date; bh=A415gP/CRCjugI919Jgs4A7RjNMw5l2C7zh5BSt6/9c=; b=cw1mNAoz6pNqX9M9TacTMaWM7ZPCbyB8Mb9RNo7yXHBX9IKQGVa/41aGSh5SNA6ReX rlJ5CyiLsludHGviO+mcCHmKxOv/8lplcVMUt36CtQJX4wiVF2N1YfBw0fLcmU6PXtIB vy23Ig8jYsSrL0qGNTlVykrfFGMrYNkRW5iF0= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date; bh=A415gP/CRCjugI919Jgs4A7RjNMw5l2C7zh5BSt6/9c=; b=YQPeSCkTEZ9JYvRnQGkHYf7/76hm/x0jHfC1yOFRd590x+wRTgyUFUUojj+dyVBbhX uttBEbIDvqyPS2FzUZshqVkohAAFwSLf+LdycV51n3k/gWs9zrXfggYU/msAn8OG81qR Fkh49A/PND0nYUjVE0Ts6cKsaXgMJXcn6LM9fEqR7jKr94VfnwxIINRQ3ujYtj+BJ7uh 8qeXSdcko9AaJzu7QibqUbLZ9y+8RJ2j1dW+OnQDxaGLVMelakCJua9MJtcbSHXB5lw4 O7WsqJmKXAgQu0aYDo6W1oiTGDKfeClr6i8wJIU8xlXKomGxTHtw5fJL8vN7eFNBVKuS lgzQ== X-Gm-Message-State: ACrzQf0lFSxsUnwM3GiKCsrYC5VgcA/comzUJRlLHxnbIYKVc/rndqvu 6Fcz4PHnbcIagUc29HZwmRXBzg== X-Received: by 2002:a63:b957:0:b0:434:c30d:84b0 with SMTP id v23-20020a63b957000000b00434c30d84b0mr23027587pgo.293.1664245858318; Mon, 26 Sep 2022 19:30:58 -0700 (PDT) Received: from www.outflux.net (smtp.outflux.net. [198.145.64.163]) by smtp.gmail.com with ESMTPSA id f11-20020a170902ce8b00b0016ed20eacd2sm144134plg.150.2022.09.26.19.30.57 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 26 Sep 2022 19:30:57 -0700 (PDT) Date: Mon, 26 Sep 2022 19:30:56 -0700 From: Kees Cook To: "Gustavo A. R. Silva" Cc: Andy Gross , Bjorn Andersson , Konrad Dybcio , linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org, linux-hardening@vger.kernel.org Subject: Re: [PATCH][next] soc: qcom: smd-rpm: Replace zero-length array with DECLARE_FLEX_ARRAY() helper Message-ID: <202209261930.A34FE7B@keescook> References: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Spam-Status: No, score=-2.2 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE, SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Sep 26, 2022 at 06:01:08PM -0500, Gustavo A. R. Silva wrote: > Zero-length arrays are deprecated and we are moving towards adopting > C99 flexible-array members, instead. So, replace zero-length arrays > declarations in anonymous union with the new DECLARE_FLEX_ARRAY() > helper macro. > > This helper allows for flexible-array members in unions. > > Link: https://github.com/KSPP/linux/issues/193 > Link: https://github.com/KSPP/linux/issues/224 > Signed-off-by: Gustavo A. R. Silva Reviewed-by: Kees Cook -- Kees Cook