Received: by 2002:a05:6359:c8b:b0:c7:702f:21d4 with SMTP id go11csp448321rwb; Mon, 26 Sep 2022 22:49:40 -0700 (PDT) X-Google-Smtp-Source: AMsMyM4+Y2VIYNuXuqOnveCDd1rbW5X38GBFpmtHOVs/se5HuVHZfAOWLcSekNNh5Q9TbL9VujBP X-Received: by 2002:a05:6402:518e:b0:452:49bc:179f with SMTP id q14-20020a056402518e00b0045249bc179fmr26214478edd.224.1664257780566; Mon, 26 Sep 2022 22:49:40 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1664257780; cv=none; d=google.com; s=arc-20160816; b=H0CjmayOZf3ytYQ8JdbIExW3QkgRcwn5sVB+bw6S4wpMeC3uQyO039YbvhTgq1TvDG KyPvhmuxn9Tf7Q4LVZJbfa6Nqd9EyAtUKSQ9UJueMNVjdhCiJ5ZfNMBcCwkzkJ4zWOcG Kh7PqNIXSM0oOaP1X5WoRfFb1uXSmbo049FrYcaydf770oZkGQm6sN/hNUSfl/zka9Oo a7wrMwXn8ZBUBGX/55jlOuuAA9kJoYnfk4K2hx5gn01cDeT8z32rJphEhe/dl8+98pfM RNQs8Q86bzsDR6zIkqsLUH/vrKQ5Zp2p85O04ohlqCoykPaI/m3tBrA+p/n2Y4LCYjR6 XDyQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date:dkim-signature; bh=h6IzD98+VKyeMTbBvajaEE5sP3Ius/lm9Sa1ohNJ2zI=; b=05Sr2cVJTjVNyCq7jmRh6JkKDFbnasRsID6BAgIvXPUGVML/eqDh7NcFZjfRZ8UVFh oSdvJb56VRx0U266UCNQi059HYiDYeVX1A9PJsWyFGqxnHnvz+fyK8DG0POtHYibD/Uw XbM9tw+iAEDJnqMBQv+pKm2npBFLxJfiWkCDxNuKcS2gnw6yWT7YUJ5DI/DCI8UqGyjm bnTANc8cLJP0jJ6/bbOLjVVzEpT5mQzZkf0IXtzte4vrk2w8ou9ccVk/U9vA+1tQaqRt slOIIxzcUZM1IiMGdwVOwJGBD6KoyIHBSsW2wphamoXgKElYg/AcmtZjg1JmbBfHYv97 6TFQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b=hut3ekNf; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id v3-20020a170906380300b007836ec699a2si273502ejc.186.2022.09.26.22.49.14; Mon, 26 Sep 2022 22:49:40 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b=hut3ekNf; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229774AbiI0FrH (ORCPT + 99 others); Tue, 27 Sep 2022 01:47:07 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:42478 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229477AbiI0FrF (ORCPT ); Tue, 27 Sep 2022 01:47:05 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 213D58E4F6; Mon, 26 Sep 2022 22:47:03 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 402CE61599; Tue, 27 Sep 2022 05:47:02 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id F0F1BC433D6; Tue, 27 Sep 2022 05:47:00 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1664257621; bh=j4JfiaEBwNwqe+T9Byu+AGlx7Ew02BAjsWgOhX/cyPc=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=hut3ekNfSPm324e9zUbtILn/rdqBR5TbZCu/OQUQPJ9BroBz5sjYsSLdSDsQcBuc/ /4vBiz1s6RFZXXEC8YNDkCIb9OWhL5Z4z0oqftkYwMNs+/Q4yWwZfx/zcIN+RsZH0x lRn/att8w/YPhrQWmnyFMiH4Y4ZK5o1cK8jFF9ZU= Date: Tue, 27 Sep 2022 07:47:34 +0200 From: Greg Kroah-Hartman To: Jiri Slaby Cc: linux-kernel@vger.kernel.org, stable@vger.kernel.org, Oliver Neukum , Jean-Francois Le Fillatre , stable , Sasha Levin Subject: Re: [PATCH 5.19 014/207] Revert "usb: add quirks for Lenovo OneLink+ Dock" Message-ID: References: <20220926100806.522017616@linuxfoundation.org> <20220926100807.118539823@linuxfoundation.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Spam-Status: No, score=-7.2 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_HI, SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Sep 27, 2022 at 07:23:46AM +0200, Jiri Slaby wrote: > I wonder, does it make sense to queue the commit (as 011/207) and > immediately its revert (the patch below) in a single release? I doubt > that... > > The same holds for 012 (patch) + 015 (revert). Yes it does, otherwise tools will pick up "hey, you forgot this patch that should have been applied here!" all the time. Having the patch, and the revert, in the tree prevents that from happening. thanks, greg k-h