Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1758200AbXFVPW6 (ORCPT ); Fri, 22 Jun 2007 11:22:58 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1756967AbXFVPWu (ORCPT ); Fri, 22 Jun 2007 11:22:50 -0400 Received: from pentafluge.infradead.org ([213.146.154.40]:58361 "EHLO pentafluge.infradead.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1756783AbXFVPWu (ORCPT ); Fri, 22 Jun 2007 11:22:50 -0400 Subject: Re: Kconfig troubles when using menuconfig - Was: [patch]Re: [linux-usb-devel] linux-2.6.22-rc5-gf1518a0 build #300 failed in zc0301_core.c From: Mauro Carvalho Chehab To: Roman Zippel Cc: Oliver Neukum , linux-usb-devel@lists.sourceforge.net, video4linux-list@redhat.com, =?UTF-8?Q?Toralf_F=F6rster?= , luca.risolia@studio.unibo.it, Jan Engelhardt , LKML In-Reply-To: References: <200706211117.55908.toralf.foerster@gmx.de> <200706211231.53898.luca.risolia@studio.unibo.it> <200706211326.45031.toralf.foerster@gmx.de> <200706211350.14526.oneukum@suse.de> <1182518566.14289.20.camel@gaivota> Content-Type: text/plain; charset=utf-8 Date: Fri, 22 Jun 2007 12:21:37 -0300 Message-Id: <1182525697.14289.47.camel@gaivota> Mime-Version: 1.0 X-Mailer: Evolution 2.10.0-5mdv2007.1 Content-Transfer-Encoding: 8bit X-SRS-Rewrite: SMTP reverse-path rewritten from by pentafluge.infradead.org See http://www.infradead.org/rpr.html Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 2271 Lines: 75 Em Sex, 2007-06-22 às 16:27 +0200, Roman Zippel escreveu: > Hi, > > On Fri, 22 Jun 2007, Mauro Carvalho Chehab wrote: > > > Hi Roman, > > > > Several instabilities on Kconfig started to happen after replacing > > Kconfig menus to use menuconfig, as this one, reported by Oliver: > > > > Em Qui, 2007-06-21 às 13:50 +0200, Oliver Neukum escreveu: > > > Am Donnerstag, 21. Juni 2007 schrieb Toralf Förster: > > > > Right, but IMHO this issue is typical for a problem with the Kconfig definitions of this module. > > > > > > > > I'll set USB devs as Cc: therefore. > > There is too little context here, what was the exact error? > I'm assuming it's the module vs. builtin problem? I also got copied on this without the full context. > The menuconfig patches were a little aggressive here, it created a config > symbol where there was none before and in this case it even changed > dependencies (it turns USB into a bool). Hmm... Probably the change from tristate to bool caused the regression. > I'm also a little irritated by the "default y", if I enable V4L I'm very > tempted to check what other useless stuff has been automatically enabled, > which I have to turn off again. The added "default y" are the ones bellow: menuconfig VIDEO_CAPTURE_DRIVERS bool "Video capture adapters" depends on VIDEO_DEV default y menuconfig V4L_USB_DRIVERS bool "V4L USB devices" depends on USB default y menuconfig RADIO_ADAPTERS bool "Radio Adapters" depends on VIDEO_DEV default y menuconfig DVB_CAPTURE_DRIVERS bool "DVB/ATSC adapters" depends on DVB_CORE default y config DAB boolean "DAB adapters" default y All of them are used just to open a submenu. I'm to keep "default y" for the menuconfig items. Since those don't generate any code (there's no Makefile items associated with the menuconfig vars), this will just improve the usability for the final user (and will allow make oldconfig to work). There's not much sense on selecting V4L support without selecting a V4L driver. Cheers, Mauro - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/