Received: by 2002:a05:6359:c8b:b0:c7:702f:21d4 with SMTP id go11csp550795rwb; Tue, 27 Sep 2022 00:56:56 -0700 (PDT) X-Google-Smtp-Source: AMsMyM7ohr3erL8hUCknTkcVUMKhZaLmQ8fqhISwZjBbxo+sXnUS2CzSAOSW2j4QQVi8qif0RwOz X-Received: by 2002:a05:6a00:9a7:b0:54c:27c4:3ad6 with SMTP id u39-20020a056a0009a700b0054c27c43ad6mr28392593pfg.9.1664265416639; Tue, 27 Sep 2022 00:56:56 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1664265416; cv=none; d=google.com; s=arc-20160816; b=W0dzVKk8tpjbroaNTJGWOWESc5Xf+tB9D6rFaVIpof5zBTGlUz7ia8xhiOXBQs26YS XnXox2nCiEU9X38Uy0eqO/9ssTY/27NpeOa2qfZ233gGlwmkGr311sy/74GP6FK2Y+Zi +F54GFwNjNgQvftIfsrgUSKS0vWlAbPNxlc4bzeMIb91bFbJmImaK2KTdnduLI6zKWF9 bqS7PNI7ec2WhEDfWOT0mtpP7JZoccv89KS8owJISxjVGx79G4wXmlQVNi/NHgHAHp75 pUkWwIerfNRLTkyk3FLVuwjYNZuo9XnQ0q/GOnNJgT3Y+8Y5NcvlGeZ1tvbxmPtONyx0 SYHg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date:dkim-signature; bh=a6SDg1hCTiC4nUEit9cw1kqstKcLw5GLfaq1onnZB1U=; b=PylkJUyJAd2Dzt69BCz8UJDBwuDb4vnPl4ZXCGwDZj7OmOggBhlxZVs1lbI3H+w2iP +LQ7LOY30UIpsKhuoldXjs5YqbpNaD3TSWXPt9fK6ZDpeVMXGvxhRErlnKaPHPjKkJjU GIEXwA5Typjjmea6tY1DQEGQpGqhuk5UCEIpWugPL5IddUmu4DcXXDEBMqdmRnvhTgPP QjS09k0P/bd0mWcSkoFEQCgSqep79iq7c9j2doNSVRL39jLV9O0V7PCo52YRD0ChbQfk NOrATkhR0HNNa+y7j7GmV5teeKkdr8GCwjz5QPf6LKp54/ehWS/Ee3sXWcePs0tMExFs qEJQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=jU3TtDbL; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id m16-20020a170902f65000b001786c622b28si997583plg.537.2022.09.27.00.56.45; Tue, 27 Sep 2022 00:56:56 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=jU3TtDbL; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229982AbiI0HQF (ORCPT + 99 others); Tue, 27 Sep 2022 03:16:05 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:49240 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229493AbiI0HQE (ORCPT ); Tue, 27 Sep 2022 03:16:04 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [IPv6:2604:1380:4641:c500::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id DA97E86899; Tue, 27 Sep 2022 00:16:03 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id B6A6C615D3; Tue, 27 Sep 2022 07:16:02 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 1C8ACC433D6; Tue, 27 Sep 2022 07:16:02 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1664262962; bh=2rBhUwN8aOjx4dsbrO7nxEdpmx2ukolgAtSl/fXvzfs=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=jU3TtDbLbimU5uWXGZkS3IneVkExqfjI5gn5BS8buZA27w4ha96ISHEyyxJzF8m/a AltVPvIt8pDCYSmvzLwEaNJB7OMiXqrp93Eyd/m0AM2TDqM4S6W7bfacd/3ga3RPi/ Wqk8F+Qr97nefIOlnAAaQRoESdl1DnW7PFzTHF3qaXSOaLuXDTRw8esMhwB20L4pY7 40gXeg6f15RWtM0eYaBeYSrwSNCtmx9I9rsul62ISb7ms7ZNqULW0ZBT99qr62E5tc 0w4d8szuSurKtE1pS+AVQyDDHK4WbJ/PalTDe2K4crYkqCWr7AhK7VKP7+nKSs8I6h /bD4Qu/+Uts8w== Received: from johan by xi.lan with local (Exim 4.94.2) (envelope-from ) id 1od4p6-0005H7-10; Tue, 27 Sep 2022 09:16:08 +0200 Date: Tue, 27 Sep 2022 09:16:08 +0200 From: Johan Hovold To: Abhinav Kumar Cc: Johan Hovold , Douglas Anderson , Dmitry Baryshkov , Rob Clark , dri-devel@lists.freedesktop.org, Neil Armstrong , Daniel Vetter , Jonas Karlman , linux-arm-msm@vger.kernel.org, Bjorn Andersson , freedreno@lists.freedesktop.org, linux-kernel@vger.kernel.org, Jernej Skrabec , Stephen Boyd , Robert Foss , Andrzej Hajda , Manivannan Sadhasivam , Kuogee Hsieh , Sean Paul , Steev Klimaszewski , Laurent Pinchart Subject: Re: [Freedreno] [PATCH v2 10/10] drm/msm/dsi: drop modeset sanity checks Message-ID: References: <20220913085320.8577-1-johan+linaro@kernel.org> <20220913085320.8577-11-johan+linaro@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Spam-Status: No, score=-7.2 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_HI, SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Sep 26, 2022 at 11:21:38AM -0700, Abhinav Kumar wrote: > > > On 9/13/2022 1:53 AM, Johan Hovold wrote: > > Drop the overly defensive modeset sanity checks of function parameters > > which have already been checked or used by the callers. > > > > Reviewed-by: Dmitry Baryshkov > > Signed-off-by: Johan Hovold > > The change LGTM, hence > > Reviewed-by: Abhinav Kumar > > I think we can use below fixes tag so that we can pick up this entire > series for the fixes cycle. > > Fixes: 3f0689e66352 ("drm/msm/dsi: check msm_dsi and dsi pointers before > use") Same here. I wouldn't add a Fixes tag unless required by some DRM process. Johan