Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <2f5a510b-082a-60e2-5770-58be086b5fc8@intel.com>
Date:   Tue, 27 Sep 2022 09:50:05 +0200
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101
 Firefox/102.0 Thunderbird/102.2.1
Subject: Re: [PATCH] ASoC: soc-pcm: fix fe and be race when accessing
 substream->runtime
Content-Language: en-US
To:     Eugeniu Rosca <erosca@de.adit-jv.com>,
        Liam Girdwood <lgirdwood@gmail.com>,
        Mark Brown <broonie@kernel.org>,
        Jaroslav Kysela <perex@perex.cz>,
        Takashi Iwai <tiwai@suse.com>, <alsa-devel@alsa-project.org>,
        <linux-kernel@vger.kernel.org>
CC:     Yanmin Zhang <yanmin_zhang@linux.intel.com>,
        Eugeniu Rosca <roscaeugeniu@gmail.com>,
        Jiada Wang <jiada_wang@mentor.com>,
        Zhang Yanmin <yanmin.zhang@intel.com>,
        Ramesh Babu <ramesh.babu@intel.com>,
        Dean Jenkins <Dean_Jenkins@mentor.com>,
        Ramesh Babu B <ramesh.babu.b@intel.com>,
        xiao jin <jin.xiao@intel.com>,
        Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>,
        =?UTF-8?Q?Amadeusz_S=c5=82awi=c5=84ski?= 
        <amadeuszx.slawinski@linux.intel.com>
References: <1664210154-11552-1-git-send-email-erosca@de.adit-jv.com>
From:   Cezary Rojewski <cezary.rojewski@intel.com>
In-Reply-To: <1664210154-11552-1-git-send-email-erosca@de.adit-jv.com>
Content-Type: text/plain; charset="UTF-8"; format=flowed
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?K3hvTUFrOXJjYVh3d1dXUVc0N2JlSjNWc3p0Vm9GNXI5ekFKTkFHVWt0aVBY?=
 =?utf-8?B?Q2UyTG9iT04xMkNIRWRhcWJTTHFzK0lPOUJ3N2hCNXZlTkhVTHF4Zi9PalNq?=
 =?utf-8?B?YmoxQXE3c3BCT2FWYU90L0VmZmc0M2JQb3YvbVdKbjNGZjRkZGJVQ294c2dv?=
 =?utf-8?B?VFpXMVlISklLRVp1YjZVRDlSYnlOM1NHVzN1MENxMGNweHJaTlU1N2FZMkpy?=
 =?utf-8?B?UHVCQmRRMEZFdjhRUit4R2tGTnQ1eEpLeWpaSVNjZjFza1lNMEdlSk9NdDBY?=
 =?utf-8?B?cFR0LzV4M3JSekZ3R043dHpBd3Y0bXhuekZnRFJ2WTFLZGVqcWtTc2lrRFJa?=
 =?utf-8?B?VkJ3L3FYdWQxZ0d5aTZiMzZWTzlYTXFNVS9pZGRQZTBYV0NMWUo0VmYwV2Vj?=
 =?utf-8?B?WDhlNDVkOGNocHR0by9vcGVUSHNCN0FrdSsrS3RYVDZjOElDSzdaVnlXeVdQ?=
 =?utf-8?B?djV6WFJhVFhYYmJvdDdIUWRHdjlNaGQrU0NQNFhiOWNHa1RNbytpeDJHUE9P?=
 =?utf-8?B?YWo1RkIyUnNzbjhON0xLSXJXTWhHc082L3c0QzBhRVNIaTFZVjh3MXV0bG45?=
 =?utf-8?B?a2IwaHRVWVl1QVdHNWxVdmIxb0NEd3FIaGtkK0pBQkp4WnJPYWY4bEZGOXE1?=
 =?utf-8?B?SUVScXJtR1ArVUQ3MWU4dVpMbjc2NmhDZFlLZWdTNmxiWVQyQVROdWdmNnpD?=
 =?utf-8?B?WmVteEpRRHlZa2RRbzZGZHduR2IyT284K09JWmxsbnFMeHZrRzY4WG1iMjlm?=
 =?utf-8?B?Z0NVTnNoRDRZL0VqejZsZnUzRXcvSkdHNFdDd3dBaENrV0EwRThNTWV4VjNJ?=
 =?utf-8?B?WDdVS3J2WCsxRXZWSVZWTzNydnhoNWhwOU4raVlGMWUyZnpCektvbnZOd2o5?=
 =?utf-8?B?MkZKSFJEdGt4a0VSMkY1YkhkYmRQZTJYcTJqNnR0amlpM2xKKzU2Vkt0eE42?=
 =?utf-8?B?UG1zY2Z1TzBJd3NkK3lBRHNSaUMrVGJGVTZGTFltcGlUSmdGT1NNbnFJUEE1?=
 =?utf-8?B?T0hSNkVYTDF5QXBBWU9iRlNpMEY0SlhaNGNOUml6K3RsSkJscXlNRjVPb1Fl?=
 =?utf-8?B?UWJVeDZDMVB0V3FMQWVmc2VnRHRoSmNURGV3YUJLRnFiS1NPYjJhaFJ3d3dD?=
 =?utf-8?B?MWlKWnVQVjlHUXR5Yi9odFl4WXVQeGJRVXlKV1YxYW53eEYzRXcyeWJsK1Qx?=
 =?utf-8?B?MDNnZGpid3lUeGprUE5yWTNkM0Y4QjNhRFFFb2RvTmtJRk95dkFmQVNXYmNq?=
 =?utf-8?B?UWpSSzB0c2hWbEUvZ2xSUWs3OU9jL2IzM2VKU0lBNElQQ0VRaVh3TlIycU1i?=
 =?utf-8?B?b3ErbGpPell1YUM5T3ZHaHpUMmREWk1zZVo3dlhrbi9SblBpK0MxT002N21x?=
 =?utf-8?B?Q3laaFVudGYzc2htT3NkWGo2ZUtyZTZySm5aSW5mQkViMUF0ZG9kNmpLS1BN?=
 =?utf-8?B?Yktza0lsWWdSemV0aC9uZGF4azY3bUtBSzIxREJmY1Z6c2E5Qjk0SGltOWR6?=
 =?utf-8?B?VXJsS2pmenk0NDdmNkJWait2bDh4UkdnclVWNUJ2MnQ1RU80NkFWd1Rrcjdu?=
 =?utf-8?B?NHlmUyttdXBRMlFTeFg5R0dLK0xzZk1jTGE5QloweG8zOGpWYW9yMjUvNnZH?=
 =?utf-8?B?blY1YUdSVGpLQWw4bS83VXp6VTdnK3hselBsQTVJZW5XOU8rc2VJV1prM28y?=
 =?utf-8?B?ZEE1eFZkaXNSVDFDN3JjQlFBdjlvRHZKaDRFQUFaQmlza0ZQODl2NUhUSU92?=
 =?utf-8?B?Myt1a3UxMHV5YzZ3SitLU0d6TG96Qmg3ZGFmaVh2VHdOUXU5MmVqRGMzTnJU?=
 =?utf-8?B?RHpBSlJzSWNXZ2N6TzlFSTJPU09oYmxGVXpYb2t2SGdZdXRvSVZqUURNSG1s?=
 =?utf-8?B?bUZvN3VsQ29kamNEclVITVp2NGJYOTlmRVI1MzcvYWZqbnNRbFN4bXhUcGJ0?=
 =?utf-8?B?blYwSmMwQ1RDajZ5REJwektYU2xaOTJXNGNrT1IwcVhaaUZWcU1tbXJkcXZC?=
 =?utf-8?B?eGNGUVRmb2JHNXR5MkdrWGJkd01VSFdTU0JlQVFENHNPYWUwcUZFS0J4ejI2?=
 =?utf-8?B?S2VJZWRnZ2FnQ05MVUw3U3JoZEx2UnlmYWwrV2tKY0FQVkhPSE1GZFppK0cz?=
 =?utf-8?B?dm91dENEc2pueThVbnhsSXBEang3V2RHYlIwMXJad2hMUkpwZmZWby9OeFFa?=
 =?utf-8?B?RWc9PQ==?=
X-MS-Exchange-CrossTenant-Network-Message-Id: 4c2a8dec-4924-42c1-ba93-08daa05ceaa2
X-MS-Exchange-CrossTenant-AuthSource: DS0PR11MB6375.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 27 Sep 2022 07:50:16.1264
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: crBKLLtamOgVA0+VO0cJLYyoY6ZL5sQ0FnYiNUFr62kerxl+QEeZRR/miIvY+KWet0WERGBx7qXyZv7w3fJpsjY6W/HhZolQzv5oKG3buBw=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN9PR11MB5557
X-OriginatorOrg: intel.com
X-Spam-Status: No, score=-6.8 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,
        DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,NICE_REPLY_A,
        RCVD_IN_DNSWL_MED,RCVD_IN_MSPIKE_H3,RCVD_IN_MSPIKE_WL,SPF_HELO_NONE,
        SPF_NONE autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On 2022-09-26 6:35 PM, Eugeniu Rosca wrote:
> From: xiao jin <jin.xiao@intel.com>
> 
> After start of fe and be, fe might go to close without triggering
> STOP, and substream->runtime is freed. However, be is still at
> START state and its substream->runtime still points to the
> freed runtime.
> 
> Later on, FE is opened/started again, and triggers STOP.
> snd_pcm_do_stop => dpcm_fe_dai_trigger
>                  => dpcm_fe_dai_do_trigger
>                  => dpcm_be_dai_trigger
>                  => dpcm_do_trigger
>                  => soc_pcm_trigger
>                  => skl_platform_pcm_trigger
> skl_platform_pcm_trigger accesses the freed old runtime data and
> kernel panic.
> 
> The patch fixes it by assigning be_substream->runtime in
> dpcm_be_dai_startup when be's state is START.
> 
> Signed-off-by: xiao jin <jin.xiao@intel.com>
> Signed-off-by: Zhang Yanmin <yanmin.zhang@intel.com>
> Signed-off-by: Eugeniu Rosca <erosca@de.adit-jv.com>


Hello,

The change seems to be driven by the skylake-driver problem. With all 
due respect, why not ping owners of the driver first? There are some 
crucial CCs missing.

I'd like to know more about the scenario you guys reproduced the problem 
in. Configuration details and kernel base would be good to know too. 
Since our CI did not detect problem of such sort, if the problem 
actually exists, we would like to append a test or two to cover it later on.


Regards,
Czarek