Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Feedback-ID: i56a14606:Fastmail
User-Agent: Cyrus-JMAP/3.7.0-alpha0-968-g04df58079d-fm-20220921.001-g04df5807
Mime-Version: 1.0
Message-Id: <e0efb8a9-b4b0-47bf-ab84-ea71c3630f9d@www.fastmail.com>
In-Reply-To: <20220927045514.2762299-1-chenhuacai@loongson.cn>
References: <20220927045514.2762299-1-chenhuacai@loongson.cn>
Date:   Tue, 27 Sep 2022 09:51:04 +0200
From:   "Arnd Bergmann" <arnd@arndb.de>
To:     "Huacai Chen" <chenhuacai@loongson.cn>,
        "Thomas Gleixner" <tglx@linutronix.de>,
        "Marc Zyngier" <maz@kernel.org>
Cc:     loongarch@lists.linux.dev, linux-kernel@vger.kernel.org,
        "Xuefeng Li" <lixuefeng@loongson.cn>,
        "Huacai Chen" <chenhuacai@gmail.com>,
        "Jiaxun Yang" <jiaxun.yang@flygoat.com>
Subject: Re: [PATCH] irqchip: Make irqchip_init() usable on pure ACPI systems
Content-Type: text/plain
Precedence: bulk

On Tue, Sep 27, 2022, at 6:55 AM, Huacai Chen wrote:

> @@ -28,7 +28,9 @@ extern struct of_device_id __irqchip_of_table[];
> 
>  void __init irqchip_init(void)
>  {
> +#ifdef CONFIG_OF_IRQ
>  	of_irq_init(__irqchip_of_table);
> +#endif
>  	acpi_probe_device_table(irqchip);
>  }

I think that #ifdef should be in the include/linux/of_irq.h
header, with an empty inline function in the #else path.

   Arnd