Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Tue, 27 Sep 2022 10:59:30 +0300
From:   Dan Carpenter <dan.carpenter@oracle.com>
To:     xkernel.wang@foxmail.com
Cc:     gregkh@linuxfoundation.org, linux-staging@lists.linux.dev,
        linux-kernel@vger.kernel.org
Subject: Re: [PATCH v3] staging: rtl8723bs: fix potential memory leak in
 _rtw_init_xmit_priv()
Message-ID: <YzKtYksCuy+xrum4@kadam>
References: <tencent_F8100CE69CDC080E218AEF7033A5CCFF2507@qq.com>
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <tencent_F8100CE69CDC080E218AEF7033A5CCFF2507@qq.com>
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?LH8vKLJI3sZS+1FMLQHFVmCfSm+JrJftQePGMmZhbQeGmeW2puP4yQ1QqUbP?=
 =?us-ascii?Q?np1TcqS34iCVtFMBA7XIqbdyaU+mVGIyvt9xwseG4nQKzCu1UPaWk6kNzet3?=
 =?us-ascii?Q?Xo4NdnYtCb9vU8adid4y9+7YTeAf/FOc2fH2lHcppvMQveRSnZlhxkXnxHis?=
 =?us-ascii?Q?5Ay1kCjIU21rwt6HEI/i7NPnZs7M57+lNT9YlaIMqR6L9/XWS9aStlIieY0g?=
 =?us-ascii?Q?UFGpGwjMA8kvXvpyUFO5YgbHZAU3aB5yWHCvWxzz1kWpTqvaTGm7mtejnyjK?=
 =?us-ascii?Q?x/UaHRB53iQ2sspZLizNjZLnqutCGt76Aw4zVkB1j3RRjh8iIFYcLcXOQWwC?=
 =?us-ascii?Q?iDCoMiN/uaxmhipwNAlDJkwWV2zdRgUIe7NNYR4ecyvxXwkR4F/YhREC+PZ5?=
 =?us-ascii?Q?S8/pT7EOCOLz06o7nKzNXrGuV+K5dA0RFfWzvccWi8YSLicp0XlW68fBA3il?=
 =?us-ascii?Q?wpFVE7uocwsybIBJw+tNTKQ1WH9Dv9rGOgw9mfsCMmIPrIF/SHJSVqvLpm98?=
 =?us-ascii?Q?GfF4YjZ7ekTB8sF5Iqi8c1e5cwX+RN/33wl2qmIW1wRkJwzBF3yYVptw74V2?=
 =?us-ascii?Q?1vPcP4CH9Gr4Q+phsrv1Gg4vBu+KcJnmjUDCM/7bSwbpsU7Vjoerelkvx2Ir?=
 =?us-ascii?Q?XxZT5Dd6vfXfAZ5Dje9QbbNv2FZEdLceW/h2SycpzV0b0vv3bH4RMo370HuX?=
 =?us-ascii?Q?n+aK7PDy+4gPhLwO3woOeLvAETtgumgEDpsMLPn4ce12spINu6TbrMIu7tOO?=
 =?us-ascii?Q?V9OX3DcoxXepqSPYFugQ++DYhd63W62OuN25voaX2zPOWPVwlx/5O81lPHQI?=
 =?us-ascii?Q?G2ZN4AMlbYw5OSWOjN9hNIBib6uowa0WL0mGtj3QFSDTxTOqc8H8XA7SWFgP?=
 =?us-ascii?Q?ECyj41cUSwanf9H+BghdagFl/JJOgz//00CsK6/ra/zgm8ly+i0GvpIKhema?=
 =?us-ascii?Q?q+qKbquhOWFP2p9OIKxxfiJIik4YAURTfdqIFB43DEcjFG+D5TbzTZSDXJFw?=
 =?us-ascii?Q?NcaunGtXaqAyav/wsn2ffd31zYDb2ZKETvTJ7KyP+rJu/9lqINiiJU0D3CVw?=
 =?us-ascii?Q?eCqY6/Q42LQZZPtTDVAN1Gpj9CzYXPHS+UQNtQrGKVp1yps3lYAaofKZSwjj?=
 =?us-ascii?Q?+STEgCqOEur/uUomVjEdIUq00TF7G9MKa1yaW7eDcX1xkcSkiG7Np1jV+kF3?=
 =?us-ascii?Q?srQErMj252xywiZf26gDHzssXwdu9eFngWzmzRJ8Vq+T5SoS1GRDfQ2q21vz?=
 =?us-ascii?Q?rHSHVbkJD1DfnIUbyRxvjDt1u0g1LlahugEIgupCZ4yBLdZqVX+Yjx0Zp4GS?=
 =?us-ascii?Q?OCqXQMVjTo8IK7a4gkC/a1Z7vVDgUxsq6ibO4s8YYsRTNj7T98hv2Vfb9+ZE?=
 =?us-ascii?Q?ksdsYLtiLW0OJgdwmQjqiS5EZehXoomSeJwxSX9shjB6Akq5QXQDk6R+LAI5?=
 =?us-ascii?Q?rHllTsKBwvffygcSrobgNbxBltshDDCKOYP1/g11fQK8R+4D+5mXGHBxZ77f?=
 =?us-ascii?Q?3WirP3M2SeKSvLZ+7FmqgMQ0mMenHNc1Foq2JbmHmNx9/+g350YoB5btSBCi?=
 =?us-ascii?Q?X/FTiIkwfzhh3eqxv7GLGuVtHQhLh6xwAZDKfDqV?=
X-OriginatorOrg: oracle.com
X-MS-Exchange-CrossTenant-Network-Message-Id: df8ca91e-c9f3-440e-c781-08daa05e39c6
X-MS-Exchange-CrossTenant-AuthSource: CY4PR1001MB2358.namprd10.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 27 Sep 2022 07:59:38.4919
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: kiFH/rL2aeE3ZVEw7imEvHBzGERZDgKTskB+wdKq7pCQXr3MjwhJuQk97YAZLU5oSl1o+WRbIO4LEsB5D/pVvmIDL+p6RazeLpPJscm/trs=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH7PR10MB6154
X-Proofpoint-Virus-Version: vendor=baseguard
 engine=ICAP:2.0.205,Aquarius:18.0.895,Hydra:6.0.528,FMLib:17.11.122.1
 definitions=2022-09-27_02,2022-09-22_02,2022-06-22_01
X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 malwarescore=0 bulkscore=0 phishscore=0
 mlxscore=0 mlxlogscore=836 adultscore=0 spamscore=0 suspectscore=0
 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2209130000
 definitions=main-2209270047
X-Proofpoint-GUID: pxEZwsWpHlZKUenK470Z8ANYG1etTyx1
X-Proofpoint-ORIG-GUID: pxEZwsWpHlZKUenK470Z8ANYG1etTyx1
X-Spam-Status: No, score=-2.8 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_LOW,
        RCVD_IN_MSPIKE_H2,SPF_HELO_NONE,SPF_NONE autolearn=ham
        autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Mon, Sep 26, 2022 at 03:54:57PM +0800, xkernel.wang@foxmail.com wrote:
> From: Xiaoke Wang <xkernel.wang@foxmail.com>
> 
> In _rtw_init_xmit_priv(), there are seven error paths for allocation
> failures without releasing the resources but directly goto `exit`, while
> the exit section only executes `return res;`, which can lead to various
> memory leaks.
> 
> To properly release them, this patch unifies the error handlers of
> _rtw_init_xmit_priv() and several error handling paths are added.
> According to the allocation sequence, each error will jump to its
> corresponding error handling tag.
> 
> As there is no proper device to test with, no runtime testing was
> performed.
> 
> Signed-off-by: Xiaoke Wang <xkernel.wang@foxmail.com>

This seems to introduce a similar use after free as mentioned in the
change to the other rtl driver.

list_add() followed by a free.

regards,
dan carpenter