Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
From:   David Laight <David.Laight@ACULAB.COM>
To:     'Sean Anderson' <seanga2@gmail.com>,
        "David S . Miller" <davem@davemloft.net>,
        Eric Dumazet <edumazet@google.com>,
        Jakub Kicinski <kuba@kernel.org>,
        Paolo Abeni <pabeni@redhat.com>,
        "netdev@vger.kernel.org" <netdev@vger.kernel.org>
CC:     Nick Bowler <nbowler@draconx.ca>,
        Rolf Eike Beer <eike-kernel@sf-tec.de>,
        Zheyu Ma <zheyuma97@gmail.com>,
        open list <linux-kernel@vger.kernel.org>
Subject: RE: [PATCH net-next v2 07/13] sunhme: Convert FOO((...)) to FOO(...)
Thread-Topic: [PATCH net-next v2 07/13] sunhme: Convert FOO((...)) to FOO(...)
Thread-Index: AQHYz7ig+qNCRawu/kW9+5ipsBz0Rq3y7U4Q
Date:   Tue, 27 Sep 2022 07:58:35 +0000
Message-ID: <9412f706a4934d218019d74c5f4b74ae@AcuMS.aculab.com>
References: <20220924015339.1816744-1-seanga2@gmail.com>
 <20220924015339.1816744-8-seanga2@gmail.com>
In-Reply-To: <20220924015339.1816744-8-seanga2@gmail.com>
Accept-Language: en-GB, en-US
MIME-Version: 1.0
Content-Language: en-US
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8BIT
Precedence: bulk

From: Sean Anderson
> Sent: 24 September 2022 02:54
> 
> With the power of variadic macros, double parentheses are unnecessary.
> 
> Signed-off-by: Sean Anderson <seanga2@gmail.com>
> ---
> 
> Changes in v2:
> - sumhme -> sunhme
> 
>  drivers/net/ethernet/sun/sunhme.c | 272 +++++++++++++++---------------
>  1 file changed, 136 insertions(+), 136 deletions(-)
> 
> diff --git a/drivers/net/ethernet/sun/sunhme.c b/drivers/net/ethernet/sun/sunhme.c
> index 7d6825c573a2..77a2a192f2ce 100644
> --- a/drivers/net/ethernet/sun/sunhme.c
> +++ b/drivers/net/ethernet/sun/sunhme.c
> @@ -134,17 +134,17 @@ static __inline__ void tx_dump_log(void)
>  #endif
> 
>  #ifdef HMEDEBUG
> -#define HMD(x)  printk x
> +#define HMD printk

That probably ought to be:
	#define HMD(...) printk(__VA_ARGS__)

(and followed through all the other patches)

	David

-
Registered Address Lakeside, Bramley Road, Mount Farm, Milton Keynes, MK1 1PT, UK
Registration No: 1397386 (Wales)