Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Tue, 27 Sep 2022 11:05:29 +0300
From:   Dan Carpenter <dan.carpenter@oracle.com>
To:     kbuild@lists.01.org, Horatiu Vultur <horatiu.vultur@microchip.com>
Cc:     lkp@intel.com, kbuild-all@lists.01.org,
        linux-kernel@vger.kernel.org,
        Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
        Srinivas Kandagatla <srinivas.kandagatla@linaro.org>
Subject: [char-misc:char-misc-testing 29/36] drivers/nvmem/lan9662-otpc.c:43
 lan9662_otp_wait_flag_clear() warn: signedness bug returning '(-110)'
Message-ID: <202209261902.qJDWZGUZ-lkp@intel.com>
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?tHQS84MaRk4B3260ihNRNfsIsB/B6uKyqj1y4iOfzm3Nx1FopTUgWwG8A89o?=
 =?us-ascii?Q?7mzq+EtcmFQgfTUGi7wHVrfy1peXA9oLIOsXHaVdZ0Iz9pai1ZOY2GeZPvtn?=
 =?us-ascii?Q?Vw1Ve60guRSqOFLT/7UBp5DHhZdwwNbJqd98K5kPD3b7kP3kFZc9mQljTkPF?=
 =?us-ascii?Q?+1AKK2KWp16i3xVd2FoBZugGLV1aF2Qyjve18VRxz9lD3fIrFVDYHB8H4ADf?=
 =?us-ascii?Q?aMOd2tMdR5DIeq1VVyx1FwfeylBGyKa7yecVZ8oVtYJdGN9TWyriKH1YabDt?=
 =?us-ascii?Q?dT4UMm4xpnWhypgJKNjAloABM34KRDANYSV//JAy3snv6RNvBbSoPrhVlHyz?=
 =?us-ascii?Q?8WMfWGcamezDAQT0Fws7ivhuLfeTN6criFUHkXAVwRVSiZvq5ZKQeB79Tsw4?=
 =?us-ascii?Q?EBrcuHMvF9QmOYM4+Q9b6JvEJfJK92jfUMMgPoONeGpY35WyuQ8vQSu1hmeR?=
 =?us-ascii?Q?do0pR+GK1AM48jwrbRHcKxS2GUxSxTqJ6ThwZN3ccnhRM+I/1lyt2xvzrwdX?=
 =?us-ascii?Q?CiGqlxiPl+Y0r1t9JgiIjfPdSes7ondRfRxzfsIn62iN2NgrhJx3MhBNDGfJ?=
 =?us-ascii?Q?xnAWAmtrJGiE3ayy0UlTCEnfdj8XfSSbV2TDgz3KEEbiDVpWEuvWpZZhSfJj?=
 =?us-ascii?Q?ZNCTazb5xH6Qhy/BJsL8g4Bc7KsrusgZyXc7TLkMP5LFZBUAsHml5u9EUCeY?=
 =?us-ascii?Q?v2RXKCVAke1zj5njFxAKcbns6s0PpknJfuVJ9qPGBSCHy4Co0ggPnb1aFSLv?=
 =?us-ascii?Q?MlnIo9RGs0vomfHz8+T8L2fOoP01abDMyR7b4eTCL32j0ixoyLE3+KEed9je?=
 =?us-ascii?Q?tYkk6uPNhQ9GV6txHgwX7aW696DhqgD8gdv9kdswX0sKj3CxcFFX0FKH48o3?=
 =?us-ascii?Q?d8F9oga9S/P2BSsLsf4pPN+VNZVRUxyUHs9Obr94fK/J4IWwFwNEyTv/QrXj?=
 =?us-ascii?Q?mS/HMlwvYEQgHLrIvFa39ApvIsEeisgsiQB0ZC31MR8p4K1v+otjNCpzQ89A?=
 =?us-ascii?Q?EUbqIMHngriHd5wbrZ/m4HDPdJO99DZaqvun9rOrpwhfUWCmFB9VkCaOSmmW?=
 =?us-ascii?Q?lKd3jL/DTVYVuFGRWUHso8t0MKcvoTQBszasJ3Es2dfXvO3HKyu3SML1z0op?=
 =?us-ascii?Q?RuWDA1B5U9YQ3kIQ47rJsogxHbMw6J/lPuBaLcR7D4vC62OclaLMvxI/Cjkt?=
 =?us-ascii?Q?pTnCSgBQ0MQnbwjohEzXv1LhfgX1Qdf/Pf+StNpuqh+/pUlwAA8SBAtkBW+e?=
 =?us-ascii?Q?5qUVztA+AITrWXDSOZM9pMuAvJmrIZAGHfMRkjDxVE+Dk96X+T3M+RHUlSxZ?=
 =?us-ascii?Q?IbcL2KBNntgcJABKkUINGccKNRC7JYkMYjGgpGiJnO5rScCFXeWKS5lc0qVX?=
 =?us-ascii?Q?UmXVjbuagVpG7IUOljesug1gtZbWXEbU8Kf5ItPgqfsKaB4ES8QGb0T6mCyP?=
 =?us-ascii?Q?k860Cn1cqOC/kJwyJFQvZc6OakD41pKpx4j6vk9Ay8Oo9iy+ocr+kt4R7tpS?=
 =?us-ascii?Q?EuQBhXUvGJkzdFm5qHGvGeWUWwKJrdjFnxuHM5kO/6LHgVQFILcVpgu8cCVb?=
 =?us-ascii?Q?kmtF4HbZcrN7m9zdnMvQY8G6ip1gnrUXBYE+eiju?=
X-OriginatorOrg: oracle.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 2489313f-17a1-4d5f-718d-08daa05f1252
X-MS-Exchange-CrossTenant-AuthSource: CY4PR1001MB2358.namprd10.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 27 Sep 2022 08:05:42.0138
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: rWzhRqgvrAZHtec7GSdMlcnwIBkDoqXChx1+DDdMosGYwQuBaw9DnVmDTm/MDRHVQbc+zZ03DKADocJJJpUXHtz9SGFGmGzuW3x4FIdzuZA=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM6PR10MB4345
X-Proofpoint-Virus-Version: vendor=baseguard
 engine=ICAP:2.0.205,Aquarius:18.0.895,Hydra:6.0.528,FMLib:17.11.122.1
 definitions=2022-09-27_02,2022-09-22_02,2022-06-22_01
X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 mlxscore=0 malwarescore=0 phishscore=0
 suspectscore=0 adultscore=0 bulkscore=0 mlxlogscore=999 spamscore=0
 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2209130000
 definitions=main-2209270047
X-Proofpoint-ORIG-GUID: HyMbdxjm5EV8vxNFQpEq_AEbiOxleMjH
X-Proofpoint-GUID: HyMbdxjm5EV8vxNFQpEq_AEbiOxleMjH
X-Spam-Status: No, score=-2.8 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_LOW,
        RCVD_IN_MSPIKE_H2,SPF_HELO_NONE,SPF_NONE autolearn=ham
        autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

tree:   https://git.kernel.org/pub/scm/linux/kernel/git/gregkh/char-misc.git char-misc-testing
head:   0f65caa911019561d71ceb70f0d1c7a965b3045f
commit: 9e8f208ad5229ddda97cd4a83ecf89c735d99592 [29/36] nvmem: lan9662-otp: add support
config: openrisc-randconfig-m041-20220926
compiler: or1k-linux-gcc (GCC) 12.1.0

If you fix the issue, kindly add following tag where applicable
| Reported-by: kernel test robot <lkp@intel.com>
| Reported-by: Dan Carpenter <dan.carpenter@oracle.com>

smatch warnings:
drivers/nvmem/lan9662-otpc.c:43 lan9662_otp_wait_flag_clear() warn: signedness bug returning '(-110)'

vim +43 drivers/nvmem/lan9662-otpc.c

9e8f208ad5229d Horatiu Vultur 2022-09-16  39  static bool lan9662_otp_wait_flag_clear(void __iomem *reg, u32 flag)
9e8f208ad5229d Horatiu Vultur 2022-09-16  40  {
9e8f208ad5229d Horatiu Vultur 2022-09-16  41  	u32 val;
9e8f208ad5229d Horatiu Vultur 2022-09-16  42  
9e8f208ad5229d Horatiu Vultur 2022-09-16 @43  	return readl_poll_timeout(reg, val, !(val & flag),
9e8f208ad5229d Horatiu Vultur 2022-09-16  44  				  OTP_SLEEP_US, OTP_TIMEOUT_US);


readl_poll_timeout() returns zero on success or a negative error code.
Better to make lan9662_otp_wait_flag_clear() return ints.  Returning
false/true (as opposed to true/false or zero/negative) for
success/failure is pants.

9e8f208ad5229d Horatiu Vultur 2022-09-16  45  }