Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
MIME-Version: 1.0
References: <20220805090957.470434-1-j220584470k@gmail.com>
In-Reply-To: <20220805090957.470434-1-j220584470k@gmail.com>
From:   Joel Stanley <joel@jms.id.au>
Date:   Tue, 27 Sep 2022 07:57:06 +0000
Message-ID: <CACPK8Xc-kxwLS6Eb36Jig4mDiz_Z1ynEc127MUOsSsrC0z=xrQ@mail.gmail.com>
Subject: Re: [PATCH 1/1] ARM: dts: aspeed-g6: enable more UART controllers
To:     Ken Chen <j220584470k@gmail.com>
Cc:     Rob Herring <robh+dt@kernel.org>, Andrew Jeffery <andrew@aj.id.au>,
        devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
        linux-aspeed@lists.ozlabs.org, linux-kernel@vger.kernel.org,
        Potin.Lai@quantatw.com, Cosmo.Chou@quantatw.com,
        Michael Garner <garnermic@fb.com>
Content-Type: text/plain; charset="UTF-8"
Precedence: bulk

On Fri, 5 Aug 2022 at 09:13, Ken Chen <j220584470k@gmail.com> wrote:
>
> Setup the configuration of UART6, UART7, UART8, and UART9 in
> aspeed-g6.dtsi.
>
> Signed-off-by: Ken Chen <j220584470k@gmail.com>
> ---
>  arch/arm/boot/dts/aspeed-g6.dtsi | 64 +++++++++++++++++++++++++++++++-
>  1 file changed, 62 insertions(+), 2 deletions(-)
>
> diff --git a/arch/arm/boot/dts/aspeed-g6.dtsi b/arch/arm/boot/dts/aspeed-g6.dtsi
> index 8c0de3f27883b..fe7cef6b5e976 100644
> --- a/arch/arm/boot/dts/aspeed-g6.dtsi
> +++ b/arch/arm/boot/dts/aspeed-g6.dtsi
> @@ -34,8 +34,12 @@ aliases {
>                 serial2 = &uart3;
>                 serial3 = &uart4;
>                 serial4 = &uart5;
> -               serial5 = &vuart1;
> -               serial6 = &vuart2;

As Andrew mentioned, this may be "ABI" for existing systems. They
expect the vuart to be ttyS5. However, since the beinning they also
have a udev rule that creates a symlink, so it may not be an issue:

bmc:~# ls -la /dev/ttyVUART0
lrwxrwxrwx    1 root     root             5 Jun 10 05:25 /dev/ttyVUART0 -> ttyS5

Can you test your patch with an existing userspace to verify?

I have applied the rest of the patch with the aliases part removed.

> +               serial5 = &uart6;
> +               serial6 = &uart7;
> +               serial7 = &uart8;
> +               serial8 = &uart9;
> +               serial9 = &vuart1;
> +               serial10 = &vuart2;
>         };
>
>
> @@ -745,6 +749,62 @@ uart4: serial@1e78f000 {
>                                 status = "disabled";
>                         };
>
> +                       uart6: serial@1e790000 {
> +                               compatible = "ns16550a";
> +                               reg = <0x1e790000 0x20>;
> +                               reg-shift = <2>;
> +                               reg-io-width = <4>;
> +                               interrupts = <GIC_SPI 57 IRQ_TYPE_LEVEL_HIGH>;
> +                               clocks = <&syscon ASPEED_CLK_GATE_UART6CLK>;
> +                               no-loopback-test;
> +                               pinctrl-names = "default";
> +                               pinctrl-0 = <&pinctrl_uart6_default>;
> +
> +                               status = "disabled";
> +                       };
> +
> +                       uart7: serial@1e790100 {
> +                               compatible = "ns16550a";
> +                               reg = <0x1e790100 0x20>;
> +                               reg-shift = <2>;
> +                               reg-io-width = <4>;
> +                               interrupts = <GIC_SPI 58 IRQ_TYPE_LEVEL_HIGH>;
> +                               clocks = <&syscon ASPEED_CLK_GATE_UART7CLK>;
> +                               no-loopback-test;
> +                               pinctrl-names = "default";
> +                               pinctrl-0 = <&pinctrl_uart7_default>;
> +
> +                               status = "disabled";
> +                       };
> +
> +                       uart8: serial@1e790200 {
> +                               compatible = "ns16550a";
> +                               reg = <0x1e790200 0x20>;
> +                               reg-shift = <2>;
> +                               reg-io-width = <4>;
> +                               interrupts = <GIC_SPI 59 IRQ_TYPE_LEVEL_HIGH>;
> +                               clocks = <&syscon ASPEED_CLK_GATE_UART8CLK>;
> +                               no-loopback-test;
> +                               pinctrl-names = "default";
> +                               pinctrl-0 = <&pinctrl_uart8_default>;
> +
> +                               status = "disabled";
> +                       };
> +
> +                       uart9: serial@1e790300 {
> +                               compatible = "ns16550a";
> +                               reg = <0x1e790300 0x20>;
> +                               reg-shift = <2>;
> +                               reg-io-width = <4>;
> +                               interrupts = <GIC_SPI 60 IRQ_TYPE_LEVEL_HIGH>;
> +                               clocks = <&syscon ASPEED_CLK_GATE_UART9CLK>;
> +                               no-loopback-test;
> +                               pinctrl-names = "default";
> +                               pinctrl-0 = <&pinctrl_uart9_default>;
> +
> +                               status = "disabled";
> +                       };
> +
>                         i2c: bus@1e78a000 {
>                                 compatible = "simple-bus";
>                                 #address-cells = <1>;
> --
> 2.31.1
>