Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <af9fa1c4-0db1-6776-c362-d375f934422e@theobroma-systems.com>
Date:   Tue, 27 Sep 2022 10:51:51 +0200
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101
 Thunderbird/102.3.0
Subject: Re: [PATCH 1/3] Input: add `SW_BOOT_ALT`
To:     Jeff LaBundy <jeff@labundy.com>
Cc:     Quentin Schulz <foss+kernel@0leil.net>, robh+dt@kernel.org,
        krzysztof.kozlowski+dt@linaro.org, heiko@sntech.de,
        dmitry.torokhov@gmail.com, klaus.goger@theobroma-systems.com,
        devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
        linux-rockchip@lists.infradead.org, linux-kernel@vger.kernel.org,
        linux-input@vger.kernel.org
References: <20220922101211.3215888-1-foss+kernel@0leil.net>
 <20220922101211.3215888-2-foss+kernel@0leil.net> <YyyZRt5j180KzGqc@nixie71>
 <7add41ad-2cff-adef-08c4-dbc02f7c7c31@theobroma-systems.com>
 <Yy3qj432McMJ/5rl@nixie71>
 <953e4d00-110e-b337-3c6c-af008c843046@theobroma-systems.com>
 <YzJYZrw09dXEihnn@nixie71>
Content-Language: en-US
From:   Quentin Schulz <quentin.schulz@theobroma-systems.com>
In-Reply-To: <YzJYZrw09dXEihnn@nixie71>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?ZW1uZEc3UkZZTU5ueGJxOCswWWs1Y1VCaUdaN3RVMkRuUmdvY3Arc0FPUnFV?=
 =?utf-8?B?VFF6SS81aW0vMEFlN2NuMjdYNUZkOVI1NDNzc1krQldSeEQ4UnhjS2dVb1Z6?=
 =?utf-8?B?aGR0UWNIazBXZVRCYVZHMFhMUisrL2MyWENIOWU2QzN4YkNYcGJkd0FPU3Rl?=
 =?utf-8?B?Y3VablZkY0dBNkRQaUwvdDRocm1WUVc0V2hLdXVmeDF6NXZRQTR0S3pjMml0?=
 =?utf-8?B?NWpaV1cxY3Q1WmZuVDhnSEFQVXRhOWpBc1NPNDUxTjNOSXRyOEE1VDVsVmt6?=
 =?utf-8?B?ZDVzUFdaY2Q1OER6ai9BYTRSN3ZEb0g0Vk1OUEZmU0I4bXY3Ukd6QkRXUzUy?=
 =?utf-8?B?aGs1RVNoR1JndXdWZ2s0OVdaUXBUejJnempSWjN6WEFmMktaODJoby9NalNM?=
 =?utf-8?B?ODBaOVNNYVdIVEZuL29xWmJNUnFoZkNEbkUvcnlFWTZncnJDcFBtTkNka2pw?=
 =?utf-8?B?V1VHNkdpNjdDOURnREhxTGx5RnpFVlBzdHUzQmVabjJ2N3FjdHZyVGhLc2I2?=
 =?utf-8?B?MUhtSmRiSXFRUnZxTjVUdkxkV3BuejArckpLMkk1V21EZnUrM1ZOTVcyVzd3?=
 =?utf-8?B?d2ZpTEJhcy9nVEI5VFU0clJmTXozeERtWUdRRGpwbUxsb29kUTZZSElPVHNh?=
 =?utf-8?B?Q3Zya3F1K0MzSVNka0RxSFJ5TVBzTEFZOTByVDdCVzVsSytjSUpYbit6QkNy?=
 =?utf-8?B?VmFnTG1WNnZxQitPWk9pZXdZRUpyNGdyRnkxcWJGUzd2NTdiV05XbDk0WFZk?=
 =?utf-8?B?MUFDanFiSTIwNVhxdE1CM1NROHNjOVo2cFA1MTRVNmpSV21JZHdvTVd6enFH?=
 =?utf-8?B?VHFtNjFTYnk2Q2ZVMXZqeU5oa2wxemxYbWxWT1dkVzh1NHh3ZGFqRTIwNGNU?=
 =?utf-8?B?cTFqZ3Y4NXZRZm54TXVEbzFXOTlrU25kc1B2Qkg5aGFrYW9ScGNZRnZLS0tx?=
 =?utf-8?B?MUdUK256RFo0SmU1dHQycDVNYmRYL2JjQjcweFZDdStCcmJOSWtXL2N4czEr?=
 =?utf-8?B?Mis4dCs3V2dYRHNiZUF4NTk1dzRsSVNRc0RZMXdtZjB0b2wxRWpNWjBoRlBn?=
 =?utf-8?B?YkhRazFIcjNLZ0xnS1AwYXE3YU1JdTVod2o5ZnZCYTdhc3RYMnZNcVVRaFZ3?=
 =?utf-8?B?akVwcFEvYmtTVnAwOWI3ekVGM3pwejZ2cTBXNDVwcEx3OUhlUFI1T3BTaDg5?=
 =?utf-8?B?ZTlnZzR6TmsyT2h6VmRPeDNNdWtTRUZCRTdtMElCb2dtTkt2ZFVxU1RQVUox?=
 =?utf-8?B?RDY2em9VNWE5amNrdnFyRUhraGFGenNjSUo3VkpZRTIvZ1U0eVAxOXhNa1hk?=
 =?utf-8?B?WURLOXRPRzZlZEJLVjlKU1M3aDhCLzFkdlNHaTFPMG5GVUkvZ1pUSms2MWsv?=
 =?utf-8?B?aEUyMExMQW9PRDc2U0JTSWlQZzR2TUFZT3pyMVE1S29yVlMxRTNiTzRuQ0tQ?=
 =?utf-8?B?RHBzVEJqTWpQSUJ6bjRwMWE1ekZMZFFOUit2ZHZZM2JxL2l3WlUxSU8zQW40?=
 =?utf-8?B?a2NYSUpsV0lXUmx6aTltUHdCWkd0cmtHRDB2MWcxZzRFcDl1YTRZdHI1djBw?=
 =?utf-8?B?Tmd4Q3BCWmFzT1h0WFFWRm12aFViaVVleThONC93SGpFS2tDUWh1b2ZKWGhw?=
 =?utf-8?B?aTIvUDhRYmNQVEt5c1BIL2tiSVVUZUZXZHN4RHVlWk0zMEJaWFNwMm9iOFBD?=
 =?utf-8?B?Y3N2VjY0RWxPVUl2YW9QNGllQk1EV1ZBcHlYRzVYSTFnVXQ4cUlHdjBqY0lx?=
 =?utf-8?B?bjRlMW1lSTYwNC84SXlpSmNpVVhZRVpkclAwaFZraTNOaWd0MXkyajlNNGxt?=
 =?utf-8?B?cE9wWllGUTRaNkRBWmh5d2NMMm9ySmVuUEtPWlpDMVBIeE5PbWRjRVBhQ1RU?=
 =?utf-8?B?MGFJRG85T1RTQXExa3dEbTM4cmtTL3hzSW5paTcvMjAxTnRxSjRLYjFpQ21l?=
 =?utf-8?B?RElEL3NFR3Nib0huc2FnQ3RrQ0V0UVF0b3ZBbFpVUjVLbTlTUWZJU2FZeDVE?=
 =?utf-8?B?MTdkQnhJbXRvS3lsSFdwYXdYMkoyUFQ5cnhPbSt4M3ZRUmFSanU2eGRsdlRT?=
 =?utf-8?B?bE1QSnVSV002VjZEVktNc212MGVCOWdYaG5XS3N6M0xkZzFGNThBVnh0Y1Rz?=
 =?utf-8?B?MmZKL01ZMGFZUmJ5Sm1tdllTSW5JSE9adStkWXU2V1dLTGc5RGQ5Nmd2SVY3?=
 =?utf-8?Q?veuzJHj1x+GJnNzWWTU57wM=3D?=
X-OriginatorOrg: theobroma-systems.com
X-MS-Exchange-CrossTenant-Network-Message-Id: ba71b27f-e62f-4074-914a-08daa0658642
X-MS-Exchange-CrossTenant-AuthSource: DU2PR04MB8536.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 27 Sep 2022 08:51:53.2090
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 5e0e1b52-21b5-4e7b-83bb-514ec460677e
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: zeL2OJ6ZhfaaGqUstSxXqQ2E0yzMxT2AtkvFUf7wnrnh0zLQ8bU3iucZ8mnMvPUMG+XdUIENmBwkpPZ/0rUrMGs8BdskP6yPlpnPUBl/+hm/BljtZOEevr9fCwEC7MNR
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB8PR04MB7018
X-Spam-Status: No, score=-4.4 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,NICE_REPLY_A,RCVD_IN_DNSWL_NONE,
        RCVD_IN_MSPIKE_H2,SPF_HELO_NONE,SPF_PASS autolearn=ham
        autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Hi Jeff,

On 9/27/22 03:56, Jeff LaBundy wrote:
> Hi Quentin,
> 
> On Mon, Sep 26, 2022 at 11:37:45AM +0200, Quentin Schulz wrote:
>> Hi all,
>>
>> On 9/23/22 19:19, Jeff LaBundy wrote:
>> [...]
>>>>
>>>> I have this switch on the board and I want to expose its state to the user,
>>>> if this new event code is not possible/a good idea what would you suggest we
>>>> could use?
>>>>
>>>> Note that we already support the same switch but in a different way: https://urldefense.proofpoint.com/v2/url?u=https-3A__git.kernel.org_pub_scm_linux_kernel_git_torvalds_linux.git_tree_arch_arm64_boot_dts_rockchip_rk3399-2Dpuma-2Dhaikou.dts-23n167&d=DwIBAg&c=_sEr5x9kUWhuk4_nFwjJtA&r=LYjLexDn7rXIzVmkNPvw5ymA1XTSqHGq8yBP6m6qZZ4njZguQhZhkI_-172IIy1t&m=vObtDja6hUlL_kVvKRILCvaQfklw1gl7TAW7cm5_9H_Yi00zkzGV6-D3yzazR2gU&s=0Xo-7CDmMoriaTNn_hJdMwftLlcY-tgopPcgzXfQtJE&e=
>>>> We are just configuring the GPIOs into the GPIO mode with a pull-up, and
>>>> then it's up to the user to use gpiod or gpio-sysfs to check the state of
>>>> the GPIO used for this switch. I don't like this, very not user-friendly and
>>>> was looking for something better :)
>>>
>>> Actually, that's exactly what I was going to suggest. What in particular
>>> is not user-friendly about it?
>>>
>>
>> The implementation we currently have in place for Puma Haikou is just muxing
>> the pins in their GPIO function with a pull-up. Nothing else. This means the
>> user still needs to know exactly which GPIO number is for which
>> signal/event. Not that great. Also does not allow for a consistent user
>> "experience" across modules on the same devkit (different GPIOs depending on
>> the SoM).
>>
>> I had hoped gpio-hog in input mode would expose it to userspace but it does
>> not seem to?
> 
> No, I don't believe that is the case. That being said, you should be
> able to grep /sys/kernel/debug/gpio for the hog node's label and get
> the pin state (lo or hi).
> 
>>
>> Anything to recommend so that we can export a GPIO line for a specific
>> function to usersapce without needing the user to know which GPIO number
>> they should look at?
> 
> If debugfs won't work for your purposes, another option is to request
> the GPIO from a general-purpose platform driver and return one of two
> strings via sysfs.
> 

This board will be fully supported upstream and I don't feel like this 
general-purpose platform driver would be accepted, but maybe I'm wrong.

I didn't know about the /sys/kernel/debug/gpio file just yet for some 
reason, so that's one way to do it, thanks for the info.

Good thing is that the kernel requests this pin in GPIO input mode so at 
least that's one less possible misconfiguration from userspace. Not so 
good thing is that you need to grep in this file and it's not that great 
for scripts :) We'll discuss internally what feels the best to us and go 
for it, thanks for the tips!

I'm wondering if allowing sysfs/libgpiod to access the state of GPIOs 
requested by the kernel would make sense on the subsystem level though. 
I'm sure I'm missing obvious security/HW-limitations pitfalls, but I 
think allowing userspace to get the value of a GPIO input pin requested 
by the kernel would be nice? Nothing for the input subsystem folks though :)

>>
>> While I have your attention, I was wondering about the BATTERY event. We
>> have a BATLOW button, following the Q7 standard:
>> """
>> Battery low input. This signal may be driven active low by external
>> circuitry to signal that the system battery is low or may be used to
>> signal some other external battery management event.
>> """
>>
>> Oddly vague, but the EV_BATTERY event is not really more precise though (at
>> least didn't find more precise information and the introducing commit is a
>> bit vague too on the usage). Was just wondering if there was any specific
>> usage for this event or if I'm using it correctly here?
> 
> Do you mean KEY_BATTERY?
> 

Yes sorry.

Cheers,
Quentin