Received: by 2002:a05:6359:c8b:b0:c7:702f:21d4 with SMTP id go11csp643324rwb; Tue, 27 Sep 2022 02:36:53 -0700 (PDT) X-Google-Smtp-Source: AMsMyM4AYOwVYdpIMhW7o2mx7bB2eDlM5tU6eA3Yk9YxgNrhzjJL3DNNeSWKHsbFsxWgTg7C3/rK X-Received: by 2002:a17:902:e547:b0:178:7cf4:90e9 with SMTP id n7-20020a170902e54700b001787cf490e9mr25856744plf.158.1664271412778; Tue, 27 Sep 2022 02:36:52 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1664271412; cv=none; d=google.com; s=arc-20160816; b=cl4ei6I+AzOhZM0SpUfMyWtocncNga81d++T5/WTJ4+88PF1d7jF2ANBSLgU/nyFJx pYotcg5A6rV1LODPR3TIyrFm0MslXtoqQ91zjAJw4BkcIrMENW0Gbn3bCC6m4NeXSREQ EMW918G8Cm+Iiq2v9TZu1ehMGhf0ZMZWGl5kkBsCEHKGtGQWya+DTsi22ic+mNnNav99 O2gIF1Qcxt4lr61kTlprQvMjWkdNVfcnzoLFkPLhdXLZ7o2NpGHVuHnNRWuci17rvfoX b8scjDrstp2YeXnl+m7hPR1oQ1p1XGeSMEv5+oTmoGgSyNnnnDZfILYxM+WO8bQk1jxD Z/yg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:in-reply-to:from :references:cc:to:content-language:subject:user-agent:mime-version :date:message-id:dkim-signature; bh=xy/vZrVEyKAC936wld9SdePzf0CNuc4X8kChnAdBCQk=; b=zuVey/UlKSaxk94ZG+/UbzpiK5OFL2zuEtwkclg1c0LTO8BAwAiO7Kuk78ZdLowFt7 9cW/q/Kok7wnPigKvJUtYJeT10z+CUGW8AkXN/8l3z9SoA9E8u9SFuIIUxxmfbq0vOql C3zcxvcSqPpP+USp/o8vSQWfZP+770Zf56TT9zR58W+9GU6fHTj1LvLH6C1COW8fhOAb f2SW5Ue/8XblSMWdjtGEfgURAqdfaNHh6tjeCGwb3SSGid4IKTyPcAPci+mE6jIOxCy7 qhtA5l7XP8ZDWoxkld8w328m0k96VS1GKpqPRgmFN/k1yhDpV949RvgcNE2EL8EbqB1A TjbQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=eMnlEZEV; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=redhat.com Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id z16-20020a62d110000000b00536c7c210d3si1284666pfg.171.2022.09.27.02.36.41; Tue, 27 Sep 2022 02:36:52 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=eMnlEZEV; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=redhat.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231602AbiI0JDN (ORCPT + 99 others); Tue, 27 Sep 2022 05:03:13 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:51236 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231437AbiI0JDG (ORCPT ); Tue, 27 Sep 2022 05:03:06 -0400 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id DB336AA3F9 for ; Tue, 27 Sep 2022 02:02:54 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1664269374; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=xy/vZrVEyKAC936wld9SdePzf0CNuc4X8kChnAdBCQk=; b=eMnlEZEV5iaKWvOmFmHf/KKYP1Oh5OgyN0dtYBD+n5r4ykYtBBfXQT2Mv1Uf41zZKBDhJB sJKKaB+PqmB+udxnLHM7v3VOX5BG49KNlwz7q8pngcpux5YtQEY0iZMRTod0ywIjGU1sJf VXmb2XU9uf1LZ/h3KQVJ8D18mJn49Zk= Received: from mail-wr1-f69.google.com (mail-wr1-f69.google.com [209.85.221.69]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_128_GCM_SHA256) id us-mta-664--yfKl-g2OLO7C8v2JaJjEQ-1; Tue, 27 Sep 2022 05:02:53 -0400 X-MC-Unique: -yfKl-g2OLO7C8v2JaJjEQ-1 Received: by mail-wr1-f69.google.com with SMTP id e2-20020adf9bc2000000b0022ae4ea0afcso1924842wrc.8 for ; Tue, 27 Sep 2022 02:02:52 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date; bh=xy/vZrVEyKAC936wld9SdePzf0CNuc4X8kChnAdBCQk=; b=MFz2m4LU0uQZEgM8pRJCyfqDRXIF3skSCk8qXiCYtja7ozQv6zOjYs0bZCs9PUADgA pLwOQxBpD7ryuS1fnDpyb9ziqyBR03QuOTWfVqct2oWBZRhxB+TeBDvR+MMfoNDjTDxz BNsPyXGbhRcJwnS7DITrSuvJNAzA+dvpeldi7T+L82mfu172LZXHtgXrW+Qt4hzhVKe5 fAYmvaGZpygU5ACQcsCBfzXc3NLYOSf/hX7yjCD0GaqageBkTJDHpssODJd0EWXo2olv J6g83xEpMQnyffd1+AH2DoJU/8mx8V9/xaVN4fXDhHq1c0Lmsr+8Z/1osJYGcD8PrWVa Tkkg== X-Gm-Message-State: ACrzQf3KmRZqgZ8RVJDla+gLdvdvzeqx8FeutjDOQ9cVn3KybLw3LSeF K0DFBB6Y/VcrIiB+uO6lvxQex7+CBL/0RwttwYA4yLBBhyzt+bG6K40A7KrFYRFS3dzWQ8nFsnT Tfeb6UGp+UFfYjG9wKA4SGVqf X-Received: by 2002:adf:dd8f:0:b0:22a:84ab:4be3 with SMTP id x15-20020adfdd8f000000b0022a84ab4be3mr15951099wrl.40.1664269371780; Tue, 27 Sep 2022 02:02:51 -0700 (PDT) X-Received: by 2002:adf:dd8f:0:b0:22a:84ab:4be3 with SMTP id x15-20020adfdd8f000000b0022a84ab4be3mr15951066wrl.40.1664269371478; Tue, 27 Sep 2022 02:02:51 -0700 (PDT) Received: from [192.168.1.130] (205.pool92-176-231.dynamic.orange.es. [92.176.231.205]) by smtp.gmail.com with ESMTPSA id r2-20020a05600c284200b003b2878b9e0dsm1116996wmb.20.2022.09.27.02.02.50 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 27 Sep 2022 02:02:50 -0700 (PDT) Message-ID: <2a3b6824-7a76-308c-c7a7-cc7c6001dfcb@redhat.com> Date: Tue, 27 Sep 2022 11:02:49 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.2.0 Subject: Re: [v2] drm/msm: add null checks for drm device to avoid crash during probe defer Content-Language: en-US To: Vinod Polimera , "dmitry.baryshkov@linaro.org" , "Vinod Polimera (QUIC)" , "dri-devel@lists.freedesktop.org" , "linux-arm-msm@vger.kernel.org" , "freedreno@lists.freedesktop.org" , "devicetree@vger.kernel.org" Cc: "dianders@chromium.org" , "vpolimer@quicinc.com" , Abhinav Kumar , "linux-kernel@vger.kernel.org" , "swboyd@chromium.org" , "kalyant@quicinc.com" References: <1654249343-24959-1-git-send-email-quic_vpolimer@quicinc.com> <29ae886c-b2b2-2387-87cb-e4a885080418@linaro.org> From: Javier Martinez Canillas In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-4.5 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,NICE_REPLY_A, RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_NONE autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hello Vinod and Dmitry, On 9/27/22 09:31, Vinod Polimera wrote: >> -----Original Message----- >> From: Dmitry Baryshkov >> Sent: Friday, August 26, 2022 2:11 PM >> To: Vinod Polimera (QUIC) ; dri- >> devel@lists.freedesktop.org; linux-arm-msm@vger.kernel.org; >> freedreno@lists.freedesktop.org; devicetree@vger.kernel.org >> Cc: linux-kernel@vger.kernel.org; robdclark@gmail.com; >> dianders@chromium.org; vpolimer@quicinc.com; swboyd@chromium.org; >> kalyant@quicinc.com >> Subject: Re: [v2] drm/msm: add null checks for drm device to avoid crash >> during probe defer >> [...] >> Vinod, do we still want to pursue this fix? If so, could you please >> update it according to the comment. >> I don't think this patch is needed anymore, since AFAICT the issue has been fixed by commit 0a58d2ae572a ("drm/msm: Make .remove and .shutdown HW shutdown consistent") which is already in the drm/drm-next branch. -- Best regards, Javier Martinez Canillas Core Platforms Red Hat