Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Tue, 27 Sep 2022 11:42:33 +0200
From:   Marcus Folkesson <marcus.folkesson@gmail.com>
To:     Jiri Kosina <jikos@kernel.org>,
        Benjamin Tissoires <benjamin.tissoires@redhat.com>
Cc:     linux-kernel@vger.kernel.org, linux-input@vger.kernel.org
Subject: Re: [PATCH] HID: hid-cmedia: use device managed resources
Message-ID: <YzLFieUC3UmJolvn@gmail.com>
References: <20220915123422.520721-1-marcus.folkesson@gmail.com>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha256;
        protocol="application/pgp-signature"; boundary="Zwkxz08vvL+oB5bB"
Content-Disposition: inline
In-Reply-To: <20220915123422.520721-1-marcus.folkesson@gmail.com>
Precedence: bulk


--Zwkxz08vvL+oB5bB
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

Hi,

Do you pick up this (and the similiar
[PATCH] HID: hid-alps: use default remove for hid device
[PATCH] HID: hid-elan: use default remove for hid device
)
patch as well?


On Thu, Sep 15, 2022 at 02:34:22PM +0200, Marcus Folkesson wrote:
> When we do not need to free() any memory in .remove, we can remove
> cmhid_remove as well.
> hid_device_remove() will call hid_hw_stop() as default .remove function
> if no function is specified.
>=20
> Signed-off-by: Marcus Folkesson <marcus.folkesson@gmail.com>
> ---
>  drivers/hid/hid-cmedia.c | 25 +++++--------------------
>  1 file changed, 5 insertions(+), 20 deletions(-)
>=20
> diff --git a/drivers/hid/hid-cmedia.c b/drivers/hid/hid-cmedia.c
> index cab42047bc99..87786a88b119 100644
> --- a/drivers/hid/hid-cmedia.c
> +++ b/drivers/hid/hid-cmedia.c
> @@ -145,11 +145,9 @@ static int cmhid_probe(struct hid_device *hid, const=
 struct hid_device_id *id)
>  	int ret;
>  	struct cmhid *cm;
> =20
> -	cm =3D kzalloc(sizeof(struct cmhid), GFP_KERNEL);
> -	if (!cm) {
> -		ret =3D -ENOMEM;
> -		goto allocfail;
> -	}
> +	cm =3D devm_kzalloc(&hid->dev, sizeof(struct cmhid), GFP_KERNEL);
> +	if (!cm)
> +		return -ENOMEM;
> =20
>  	cm->hid =3D hid;
> =20
> @@ -159,28 +157,16 @@ static int cmhid_probe(struct hid_device *hid, cons=
t struct hid_device_id *id)
>  	ret =3D hid_parse(hid);
>  	if (ret) {
>  		hid_err(hid, "parse failed\n");
> -		goto fail;
> +		return ret;
>  	}
> =20
>  	ret =3D hid_hw_start(hid, HID_CONNECT_DEFAULT | HID_CONNECT_HIDDEV_FORC=
E);
>  	if (ret) {
>  		hid_err(hid, "hw start failed\n");
> -		goto fail;
> +		return ret;
>  	}
> =20
>  	return 0;

Outch, I just saw that we should just return ret here. IOW

  	if (ret)
  		hid_err(hid, "hw start failed\n");

    return ret;

Do you want me to send v2 or do you fix that when applying?

Thanks,
Marcus Folkesson


--Zwkxz08vvL+oB5bB
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQIzBAEBCAAdFiEEBVGi6LZstU1kwSxliIBOb1ldUjIFAmMyxYQACgkQiIBOb1ld
UjJbWw/9HY12MnpVvwj0+jkSVpcFvUH2VZwbyfFLLK7Hgsw8V7X2MQ6cV6BkVF6l
swjIMNrRt6Gm5z535Nd7+0TLkbl2dlY0p5V8Hu8F71NBXKd6oA8GxuFmmLdblg92
09eX0ocE4z779WIrVeIcP+/qsb97BH9gcB8AKO2rQ9CJCuT0GSEl/QXqtKBNbaSJ
Kp05SWC/yL/tzPhylYXqkr57C3/ZYrYPwkObc8gUCG07J9Pw8LwXavo8O6QC00Ic
1qto1W55lWKOuCZ+UboQ/c+vSX8FdQt/xwbtw6nv1WAGfKTtIzrJ73BHgRM5XAm+
aEhahOffwQNfOoPJcGUiWNpJwsAAIITVkaK9UljhKwSUUmhaaFSBQYibvp7XykL6
0TrsbqjZ0fGsyXBA/R4xCpCNH9O64CUgSJYTXWY7YtDIs3+V81n7VCtikDk/2pmm
GHDUzPmUGQwYGX41++dhf5MjPV4Wc+qeUbOudXb1AFgtMNOAXNSb6zrYqAl4J3bW
FT9OYIhxc7wv9O9jGTFN+/L+htOOCKyYbxnVyTORproVrJB+o26DwKBSvRHbCU2x
jJyHBGk+0+cyKtptZP3eMHWFPThCDqNzMhOPIzhSC/2OdZ5o/455QE6c1OU8uMhU
WDh4/Gr3IXDmqNzHUPrQySWa3AS3oK3aq8Oa8whPM1T5IVc1Fwg=
=qdh9
-----END PGP SIGNATURE-----

--Zwkxz08vvL+oB5bB--