Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Tue, 27 Sep 2022 11:05:56 +0100
From:   Vincent Donnefort <vdonnefort@google.com>
To:     Thorsten Leemhuis <regressions@leemhuis.info>
Cc:     tglx@linutronix.de, linux-kernel@vger.kernel.org,
        vschneid@redhat.com, kernel-team@android.com,
        Derek Dolney <z23@posteo.net>, peterz@infradead.org
Subject: Re: [PATCH v5] cpu/hotplug: Do not bail-out in DYING/STARTING
 sections
Message-ID: <YzLLBBRiwuQnD2zc@google.com>
References: <20220725095952.206884-1-vdonnefort@google.com>
 <b5c5b02d-85ca-9d3b-2b3d-8892ab6d22a7@leemhuis.info>
 <42237005-5a6e-9462-bfdd-f1ba0c725c72@leemhuis.info>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <42237005-5a6e-9462-bfdd-f1ba0c725c72@leemhuis.info>
Precedence: bulk

On Tue, Sep 20, 2022 at 11:59:06AM +0200, Thorsten Leemhuis wrote:
> On 17.08.22 11:46, Thorsten Leemhuis wrote:
> > 
> > Hi, this is your Linux kernel regression tracker.
> > 
> > On 25.07.22 11:59, Vincent Donnefort wrote:
> >> The DYING/STARTING callbacks are not expected to fail. However, as reported
> >> by Derek, drivers such as tboot are still free to return errors within
> >> those sections, which halts the hot(un)plug and leaves the CPU in an
> >> unrecoverable state.
> >>
> >> No rollback being possible there, let's only log the failures and proceed
> >> with the following steps. This restores the hotplug behaviour prior to
> >> commit 453e41085183 ("cpu/hotplug: Add cpuhp_invoke_callback_range()")
> >>
> >> Link: https://bugzilla.kernel.org/show_bug.cgi?id=215867
> >> Fixes: 453e41085183 ("cpu/hotplug: Add cpuhp_invoke_callback_range()")
> >> Reported-by: Derek Dolney <z23@posteo.net>
> >> Signed-off-by: Vincent Donnefort <vdonnefort@google.com>
> >> Tested-by: Derek Dolney <z23@posteo.net>
> > 
> > What's the status here? Did that patch to fixing a regression fall
> > through the cracks? It looks like nothing happened for 3 weeks now,
> > that's why I wondered, but maybe I missed something.
> 
> Hmm, Vincent seems to be MIA, at least I see no recent messages from him
> on lore. Odd. But well, it's still a fix for a regression and it's up to
> v5 already; Valentin already added his Reviewed-by, too. Would be a
> shame to waste this.
> 
> Thomas, could you maybe take a look at the patch?  Maybe we're lucky and
> the patch is already good to go...
> 
> Ciao, Thorsten
> 
> #regzbot poke

Hi Thorsten,

AFAIK, this patch is still valid. I don't think I do have any further action on
that though.

[...]